Alexander Putilin
4e440a0ebb
fixes 6111: WebSocket close event shouldn't be Cancelable
2015-05-24 01:38:39 +03:00
Tamir Duberstein
dce048dd54
Use a struct variant for clarity
2015-05-23 16:55:00 -04:00
bors-servo
dd319c1a99
Auto merge of #5727 - jdm:parserinterrupt2, r=mbrubeck
...
...r parsing. Hook up document loading to async networking events.
Relies on https://github.com/servo/html5ever/pull/107 , so we'll likely need to backport it rather than wait for the next rustc upgrade.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5727 )
<!-- Reviewable:end -->
2015-05-21 12:37:06 -05:00
Josh Matthews
ef8a127156
Update test expectations. Mark script loads as complete when the response is complete.
2015-05-21 09:53:19 -04:00
bors-servo
b84aa41c22
Auto merge of #6154 - Nashenas88:websocket-parse-url-typo, r=jdm
...
This is a really small typo fix for an issue I worked on recently.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6154 )
<!-- Reviewable:end -->
2015-05-21 06:59:06 -05:00
Paul Faria
d4be93613b
Adding in a missed algorithm step number in the comments.
2015-05-20 22:17:07 -04:00
bors-servo
1060cfde68
Auto merge of #6152 - glennw:runnable-panic, r=jdm
...
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6152 )
<!-- Reviewable:end -->
2015-05-20 20:01:32 -05:00
Glenn Watson
b84c6fa5db
Fix document load event firing after pipeline is closed.
2015-05-21 08:39:09 +10:00
bors-servo
77099b25d5
Auto merge of #5586 - pcwalton:no-broken-background-image-redux, r=glennw
...
r? @jdm
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5586 )
<!-- Reviewable:end -->
2015-05-20 16:43:31 -05:00
bors-servo
ad53e95080
Auto merge of #6083 - ecoal95:layerize-canvas, r=pcwalton
...
I've done a bit of job to get this done. Right now readback is still used, but we have a `LayerId` -> `CanvasRenderer` map on the paint task, that we can use to get rid of that.
I'd want review, to see if this is a good approach (I know it's not the initial `CanvasId` -> renderer approach, but it's pretty similar, since a canvas involves a `PaintLayer`).
I had to do a bit of refactoring to avoid cyclic dependencies between canvas and gfx. I'd want you to review them too.
It's mergeable and doesn't break any tests :P
Some of my main concerns:
* Does the canvas render really need to be behind an `Arc<Mutex<T>>`?
* I can't clone a `NativeSurface` right now (that's why the `SendNativeSurface()` msg is unimplemented in the WebGL task). It should be easy to add that to rust-layers, supposing the caller is responsible to mark it as non-leaking, any reason to not do it?
cc @jdm @pcwalton
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6083 )
<!-- Reviewable:end -->
2015-05-20 15:42:06 -05:00
bors-servo
fada39164c
Auto merge of #5858 - pgonda:tabindex-focus-flag, r=jdm
...
Added support for the tabindex field, also added its correct defaults (-2 TODOs for things not supported in Servo yet). Also added tabindex logic into Element::is_focusable_area.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5858 )
<!-- Reviewable:end -->
2015-05-20 14:34:31 -05:00
Patrick Walton
7e7675c1dc
net: Don't load the placeholder image for background images, only for
...
image fragments.
This also changes the way the placeholder is handled in the image cache
task to decode it up front instead of each time an image fails to load,
both because it was more convenient to implement that way and because
it saves CPU cycles to do so.
This matches the behavior of Gecko and WebKit. It improves the look of
our cached copy of Wikipedia.
2015-05-20 12:00:33 -07:00
Josh Matthews
8082df7d0d
Make external script sources load asynchronously, yet still block further parsing. Hook up document loading to async networking events.
2015-05-20 14:22:09 -04:00
Patrick Walton
1a3395e077
script: Implement the width
and height
attributes for iframes per
...
HTML5 § 4.8.6.
Improves Amazon and Ars Technica.
2015-05-20 11:15:25 -07:00
ecoal95
3350522306
Layerize canvas
...
Note that this keeps using readback right now, `NativeSurface` painting
will be implemented soon.
Also see https://github.com/servo/servo/issues/6142
2015-05-20 19:10:50 +02:00
Peter
1c96eed544
fixes #5603 , adds support for tabindex
2015-05-20 10:34:16 -04:00
bors-servo
6481058309
Auto merge of #6139 - michaelwu:rustup-fixes, r=SimonSapin
...
Mutable transmutes and wrong transmutes fixed.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6139 )
<!-- Reviewable:end -->
2015-05-20 01:55:43 -05:00
bors-servo
d869a3c7a8
Auto merge of #6127 - Nashenas88:websockets-invalid-urls, r=Ms2ger
...
Fix #6061 .
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6127 )
<!-- Reviewable:end -->
2015-05-20 01:13:57 -05:00
Paul Faria
66e9b33a52
Fixed definition of Close and Send in WebSocket.webidl and updated implementation in websocket.rs.
2015-05-19 23:59:22 -04:00
Paul Faria
51ae7334f5
Responded to more code review comments. Simplified code a lot.
2015-05-19 23:54:38 -04:00
Paul Faria
fe0b77d669
Responded to code review comments, general cleanup
2015-05-19 23:54:36 -04:00
Paul Faria
8e78564dc3
Fixing one missed trailing whitespace, and fixed url
2015-05-19 23:54:34 -04:00
Paul Faria
0362d254b8
Removing trailing whitespace
2015-05-19 23:54:31 -04:00
Paul Faria
31b709a7c2
Initial work on #6061 .
2015-05-19 23:54:29 -04:00
bors-servo
c51e9f0455
Auto merge of #6131 - glennw:jquery-exit-fix, r=jdm
...
This fixes a hang found while testing the jQuery test suite.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6131 )
<!-- Reviewable:end -->
2015-05-19 21:44:45 -05:00
bors-servo
e2b0922d42
Auto merge of #6084 - WriterOfAlicrow:radiobutton-fix, r=jdm
...
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6084 )
<!-- Reviewable:end -->
2015-05-19 20:49:32 -05:00
Patrick Walton
7d9eda916b
script: Implement the color
attribute of the <font>
element.
...
Improves Hacker News.
2015-05-19 16:31:20 -07:00
Michael Wu
7772984e0b
Fix borrow_unchecked in LayoutDataRef
2015-05-19 15:27:40 -04:00
Patrick Walton
72f031e2a1
layout: Support inline incremental reflow, and stop reconstructing all
...
flows when mousing over the document.
This exposes more "jumpiness" on sites like Hacker News, but the bug
that causes it was pre-existing.
2015-05-19 11:08:27 -07:00
Glenn Watson
35a570ab66
Fix several hangs / panics during pipeline cleanup of in progress loads.
...
This fixes a hang found while testing the jQuery test suite.
2015-05-19 16:14:25 +10:00
bors-servo
0f1f71b56f
Auto merge of #6064 - nox:characterdata-overflow, r=Ms2ger
...
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6064 )
<!-- Reviewable:end -->
2015-05-17 13:40:30 -05:00
Keith Yeung
ea2bc0023b
Made open event in WebScoket not cancelable ( fixes #6101 )
2015-05-18 00:35:23 +08:00
bors-servo
9f2079f6ba
Auto merge of #6067 - Jinwoo-Song:backgroundclip, r=pcwalton
...
This property determines the background painting area, which determines the area
within which the background is painted.
Spec: http://dev.w3.org/csswg/css-backgrounds-3/#background-clip
Fixes #6066 .
r? @pcwalton
cc @yichoi
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6067 )
<!-- Reviewable:end -->
2015-05-15 22:05:05 -05:00
WriterOfAlicrow
11a4aac2a2
fixup! Fix for Issue #6073
2015-05-15 23:04:15 -04:00
WriterOfAlicrow
85c88c707f
Fix for Issue #6073
2015-05-15 22:44:10 -04:00
Jinwoo Song
a51d5de860
Implement 'background-clip' property in CSS3 Background
...
This property determines the background painting area, which determines the area
within which the background is painted.
Spec: http://dev.w3.org/csswg/css-backgrounds-3/#background-clip
Fixes #6066 .
2015-05-16 09:43:46 +09:00
bors-servo
65c30224a1
Auto merge of #6043 - mukilan:get_root_element, r=Ms2ger
...
The [current implementation](http://mxr.mozilla.org/servo/source/components/script/dom/element.rs#666 ) is wrong as it always tries to cast the furthest ancestor into an element.
When the method is invoked on an element that is in the document tree, this will be the `Document` node, which is not an element. The ```last().map(ElementCast::to_temporary)``` returns Some(None) hence the method will return ```None```, while the correct behaviour is to return the ```html``` node.
This PR interprets the line ```"furthest ancestor element node of whatever node is being discussed"``` in the spec to mean ```"find the furthest ancestor that is an element node"```.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6043 )
<!-- Reviewable:end -->
2015-05-15 03:35:37 -05:00
bors-servo
8c40272824
Auto merge of #6046 - Jinwoo-Song:background_origin, r=pcwalton
...
This property determines the background positioning area, that is the position of
the origin of an image specified using the 'background-image' CSS property.
'background-origin' is ignored when background-attachment is fixed.
Spec: http://dev.w3.org/csswg/css-backgrounds-3/#background-origin
Fixes #6045 .
r? @pcwalton
cc @yichoi
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6046 )
<!-- Reviewable:end -->
2015-05-14 20:53:02 -05:00
Jinwoo Song
b1b22c0c53
Implement 'background-origin' property in CSS3 Background
...
This property determines the background positioning area, that is the position of
the origin of an image specified using the 'background-image' CSS property.
'background-origin' is ignored when background-attachment is fixed.
Spec: http://dev.w3.org/csswg/css-backgrounds-3/#background-origin
Fixes #6045 .
2015-05-15 10:02:58 +09:00
Anthony Ramine
d0f62c7b73
Fix overflow in CharacterData
2015-05-15 01:59:59 +02:00
bors-servo
8faa9f877d
Auto merge of #5902 - nox:length, r=jdm
...
Blocked by https://github.com/w3c/testharness.js/pull/124 .
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5902 )
<!-- Reviewable:end -->
2015-05-14 13:37:10 -05:00
Anthony Ramine
d9619853e2
Fix length value of interface methods
2015-05-14 19:11:10 +02:00
Anthony Ramine
0e8bd5dd98
Partially implement getter of Document
2015-05-14 18:28:43 +02:00
Anthony Ramine
69220dfc10
Make HTMLFormElement name attribute use an atom
2015-05-14 18:28:42 +02:00
Anthony Ramine
70e67d5e11
Make HTMLImageElement name attribute use an atom
2015-05-14 18:28:40 +02:00
Anthony Ramine
b86672af0c
Implement HTMLAppletElement.name
2015-05-14 18:28:39 +02:00
Anthony Ramine
2176aab642
Import string_cache::Atom into the attributes' macros
2015-05-14 18:28:38 +02:00
Mukilan Thiyagarajan
3c56c58e38
Fix implementation of Element::get_root_element
2015-05-14 18:22:28 +05:30
bors-servo
7bda431e61
Auto merge of #6044 - Ms2ger:cleanup, r=jdm
...
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6044 )
<!-- Reviewable:end -->
2015-05-14 07:16:42 -05:00
Ms2ger
d84c3e7a30
Fix some overlong lines.
2015-05-14 13:26:13 +02:00