Commit graph

1964 commits

Author SHA1 Message Date
Anthony Ramine
2770886196 Remove unrooted() methods 2015-04-28 09:22:45 +02:00
Anthony Ramine
af21229c0e Remove the Comparable trait 2015-04-28 09:22:45 +02:00
Anthony Ramine
7197052c0d Uniformise root() methods
They now live in traits Rootable, OptionalOptionalRootable, OptionalRootable
and ResultRootable.
2015-04-28 09:22:45 +02:00
bors-servo
cac6ef8077 Auto merge of #5874 - nox:hasfeature, r=Ms2ger
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5874)
<!-- Reviewable:end -->
2015-04-28 01:30:51 -05:00
Manish Goregaokar
369a568264 Make RootedVec/RootCollection #[no_move]; improve code (fixes #5737) 2015-04-28 04:35:58 +05:30
Glenn Watson
4e76200b2c Remove node dirty on img width/height that is no longer needed. 2015-04-28 08:51:43 +10:00
Manish Goregaokar
dcb0a0eab6 Fix some no_move errors 2015-04-28 04:20:45 +05:30
Manish Goregaokar
63714ebc5f Add the rust-tenacious move-protection lint, use it for Root<T> (fixes #5724) 2015-04-28 04:20:40 +05:30
snf
cdcd6670ba fix defineproperty for cases with namedsetter 2015-04-27 23:47:22 +01:00
Anthony Ramine
6e75889e41 Fix DOMImplementation.hasFeature() 2015-04-27 23:11:53 +02:00
bors-servo
8ecb9d681c Auto merge of #5692 - pgonda:get_attributes-memory-safety, r=jdm
Changes Element::get_attributes to use a `&mut Rooted<JS<Attr>>` param instead of returning a `Vec<Temporary<Attr>>`, fixes  #5684.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5692)
<!-- Reviewable:end -->
2015-04-27 15:25:30 -05:00
bors-servo
b0a7d1bf86 Auto merge of #5777 - tamird:ICE-attr-prefix-atom, r=jdm
Rebase of https://github.com/Ms2ger/servo/commits/ICE-attr-prefix-atom

Some of the changes weren't necessary since the internals had been refactored some in the interim. In any case, I was unable to reproduce the ICE reported in https://github.com/rust-lang/rust/issues/18957.

@Ms2ger

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5777)
<!-- Reviewable:end -->
2015-04-27 14:37:38 -05:00
Ms2ger
9435565f85 Pass an Atom to Element::create. 2015-04-27 12:31:37 -07:00
Ms2ger
e8b02acb1d Pass Atom to Attr:new for the prefix argument. 2015-04-27 12:20:23 -07:00
Ms2ger
89a0c004d5 Store an Atom for Attr::prefix. 2015-04-27 11:51:13 -07:00
bors-servo
eefa3eba25 Auto merge of #5872 - nox:canvasgradient, r=saneyuki
The argument should be a double.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5872)
<!-- Reviewable:end -->
2015-04-27 13:45:17 -05:00
bors-servo
9ec2ce0dec Auto merge of #5868 - nox:document-legacy, r=jdm
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5868)
<!-- Reviewable:end -->
2015-04-27 13:06:29 -05:00
Anthony Ramine
e8e7357e99 Fix CanvasGradient.addColorStop()
The argument should be a double.
2015-04-27 19:42:48 +02:00
Patrick Walton
48299a53cb layout: Implement most of border-collapse per CSS 2.1 § 17.6.2.
Known issues:

* Collapsed borders do not correctly affect the border-box of the table
  itself.

* The content widths of all cells in a column and the content height of
  all cells in a row is the same in this patch, but not in Gecko and
  WebKit.

* Corners are not painted well. The spec does not say what to do here.

* Column spans are not handled well. The spec does not say what to do
  here either.
2015-04-27 17:12:07 +02:00
Peter
a270f3e39b Switched Element::Get_attributes to use a RootedVec instead of returning a Vec<Temporary>, fixes #5684 2015-04-27 10:04:54 -04:00
bors-servo
92359c7b9a Auto merge of #5850 - nox:nullary-callbacks, r=jdm
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5850)
<!-- Reviewable:end -->
2015-04-27 08:42:42 -05:00
Anthony Ramine
16973624c8 Implement Body.bgColor and Document.bgColor 2015-04-27 15:28:37 +02:00
bors-servo
56105e9f2f Auto merge of #5865 - gfxmonk:implicit-submit, r=Manishearth
With submission-blocking rules from https://html.spec.whatwg.org/multipage/forms.html#implicit-submission.

I wasn't sure if/where it would be relevant to add new tests (I couldn't find any existing tests in wpt to enable), so just let me know if this needs tests.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5865)
<!-- Reviewable:end -->
2015-04-27 08:05:25 -05:00
Anthony Ramine
34070b1348 Complete Document WebIDL interface 2015-04-27 13:05:56 +02:00
Tim Cuthbertson
69110297c9 Implement implicit form submission from input elements 2015-04-27 19:46:41 +10:00
Anthony Ramine
afafde5191 Change MutNullableJS<T> to MutNullableHeap<JS<T>> 2015-04-27 10:45:38 +02:00
ecoal95
79a5dae170 WebGL context hardware acceleration + error detection 2015-04-27 04:16:47 +02:00
bors-servo
ea00e949a4 Auto merge of #5860 - GlassAndOneHalf:remove-jstraceable, r=jdm
This PR solves Issue #5849.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5860)
<!-- Reviewable:end -->
2015-04-26 19:00:06 -05:00
Jacob Taylor-Hindle
be876b2124 Remove #[jstraceable] annotation for the RootedVec type [Issue #5849] 2015-04-27 00:19:22 +01:00
Ms2ger
e3440c8a59 Move bgcolor over to the new infrastructure.
Note that I call is_htmltabledatacellelement in
synthesize_presentational_hints_for_legacy_attributes, rather than
is_htmltablecellelement (which was used in
get_simple_color_attribute_for_layout), because that function was never called
for th elements.
2015-04-26 22:25:11 +02:00
Anthony Ramine
4e7b9d319c Remove useless unsafe methods on LayoutJS<T> 2015-04-26 21:39:11 +02:00
Anthony Ramine
9369b616ce Remove useless unsafe methods on JS<T> 2015-04-26 21:39:09 +02:00
Ms2ger
582ee1c2b3 Create a new infrastructure for presentational hints. 2015-04-26 21:25:06 +02:00
Ms2ger
852d973a70 Sort imports in element.rs. 2015-04-26 19:28:09 +02:00
Anthony Ramine
d4f809f95e Fix generation of nullary callbacks 2015-04-26 16:49:43 +02:00
bors-servo
1389be3782 Auto merge of #5847 - Ms2ger:slice, r=SimonSapin
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5847)
<!-- Reviewable:end -->
2015-04-26 05:30:28 -05:00
Ms2ger
a862479ca8 Remove as_slice() calls from script. 2015-04-26 10:52:55 +02:00
Peter
d0f451c2e1 Removed unessary poping in dispatch_event, fixes #5843 2015-04-25 20:22:04 -04:00
bors-servo
b22a6c8095 Auto merge of #5840 - Ms2ger:attrvalue-slice, r=SimonSapin
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5840)
<!-- Reviewable:end -->
2015-04-25 08:59:26 -05:00
Ms2ger
41cc0a939e Replace the Str implementation for AttrValue by a Deref implementation. 2015-04-25 15:24:27 +02:00
Ms2ger
4108af0c11 Introduce AttrValue::atom(). 2015-04-25 15:13:03 +02:00
bors-servo
1f9de5ee2c Auto merge of #5779 - nox:css-escape, r=Ms2ger
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5779)
<!-- Reviewable:end -->
2015-04-25 05:42:41 -05:00
Anthony Ramine
31a26fa384 Implement the CSS interface 2015-04-25 12:36:38 +02:00
Anthony Ramine
7e7b421db9 Fix generation of static JS methods
They now take a global argument.
2015-04-25 12:23:39 +02:00
Dhananjay Nakrani
731411660c Implement HTMLMetaElement.{name,content} (fixes #5663). 2015-04-24 14:45:51 +02:00
bors-servo
1b08211a5e Auto merge of #5806 - nox:splittext, r=Ms2ger
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5806)
<!-- Reviewable:end -->
2015-04-23 09:38:48 -05:00
Anthony Ramine
163d97d270 Implement Text.splitText() 2015-04-23 16:36:50 +02:00
bors-servo
d037187213 Auto merge of #5768 - nox:document-title, r=Ms2ger
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5768)
<!-- Reviewable:end -->
2015-04-23 05:20:45 -05:00
Anthony Ramine
4e95a8c4c9 Implement SVG support for Document.title 2015-04-23 12:19:12 +02:00
bors-servo
43d666f94b Auto merge of #5802 - mmatyas:indentfix, r=jdm
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5802)
<!-- Reviewable:end -->
2015-04-22 19:49:30 -05:00