Ms2ger
024323004d
Remove remaining as_slice / as_mut_slice calls.
2015-04-28 23:31:11 +02:00
Ms2ger
903305416a
Implement Clone for Copy types.
2015-04-28 23:31:10 +02:00
bors-servo
b6fc83cf2b
Auto merge of #5887 - pcwalton:border-collapse-missing-cells, r=mbrubeck
...
This was seen in Twitter and the Google SERPs (sometimes).
r? @mbrubeck
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5887 )
<!-- Reviewable:end -->
2015-04-28 15:32:31 -05:00
Patrick Walton
577f1ea109
layout: Don't panic in border collapse when a row has fewer cells than
...
its previous sibling.
This was seen in Twitter and the Google SERPs (sometimes).
2015-04-28 13:16:01 -07:00
Matt Brubeck
cad5d8b670
Ignore border-spacing for tables with zero cells
2015-04-28 10:30:47 -07:00
bors-servo
32b9c0962b
Auto merge of #5831 - pcwalton:amazon-table-sizing, r=mbrubeck
...
r? @mbrubeck
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5831 )
<!-- Reviewable:end -->
2015-04-28 11:44:39 -05:00
Patrick Walton
f56eb0fe80
layout: Minor whitespace fixes.
2015-04-28 09:26:09 -07:00
Patrick Walton
44a30054a1
layout: Make margin: auto
work properly with tables.
...
Improves the Amazon home page.
2015-04-28 09:26:08 -07:00
bors-servo
ae98f76048
Auto merge of #5883 - servo:dialog, r=Ms2ger
...
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5883 )
<!-- Reviewable:end -->
2015-04-28 10:56:06 -05:00
Dave Hodder
50ea68206d
Add attributes to the HTMLDialogElement interface.
2015-04-28 17:47:37 +02:00
bors-servo
ae99a17a1b
Auto merge of #5877 - glennw:img-cache-tidy, r=pcwalton
...
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5877 )
<!-- Reviewable:end -->
2015-04-28 09:08:44 -05:00
bors-servo
01925f0f8f
Auto merge of #5845 - snf:defineProperty_fix, r=jdm
...
This patch should get rid of #5223 .
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5845 )
<!-- Reviewable:end -->
2015-04-28 07:51:31 -05:00
bors-servo
2fd5ecf3d7
Auto merge of #5694 - pcwalton:anonymous-table-objects, r=mbrubeck
...
Improves Facebook Timeline.
r? @mbrubeck
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5694 )
<!-- Reviewable:end -->
2015-04-28 07:13:53 -05:00
bors-servo
adec683333
Auto merge of #5878 - pcwalton:intrinsic-style-specified-width, r=mbrubeck
...
Improves the front page of Google.
r? @mbrubeck
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5878 )
<!-- Reviewable:end -->
2015-04-28 05:02:32 -05:00
bors-servo
b8ae33e510
Auto merge of #5871 - nox:rootable, r=jdm
...
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5871 )
<!-- Reviewable:end -->
2015-04-28 04:23:05 -05:00
bors-servo
1cb012fc50
Auto merge of #5857 - Ms2ger:preshints, r=pcwalton
...
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5857 )
<!-- Reviewable:end -->
2015-04-28 03:24:14 -05:00
Anthony Ramine
1a30925cad
Remove Temporary::new()
...
Temporary::from_rooted() now takes an Assignable value.
2015-04-28 09:22:46 +02:00
Anthony Ramine
2770886196
Remove unrooted() methods
2015-04-28 09:22:45 +02:00
Anthony Ramine
af21229c0e
Remove the Comparable trait
2015-04-28 09:22:45 +02:00
Anthony Ramine
7197052c0d
Uniformise root() methods
...
They now live in traits Rootable, OptionalOptionalRootable, OptionalRootable
and ResultRootable.
2015-04-28 09:22:45 +02:00
bors-servo
cac6ef8077
Auto merge of #5874 - nox:hasfeature, r=Ms2ger
...
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5874 )
<!-- Reviewable:end -->
2015-04-28 01:30:51 -05:00
Patrick Walton
a92baf7683
layout: Make the style-specified width affect minimum width.
...
Improves the front page of Google.
2015-04-27 18:32:28 -07:00
Manish Goregaokar
369a568264
Make RootedVec/RootCollection #[no_move]; improve code ( fixes #5737 )
2015-04-28 04:35:58 +05:30
Glenn Watson
4e76200b2c
Remove node dirty on img width/height that is no longer needed.
2015-04-28 08:51:43 +10:00
Manish Goregaokar
dcb0a0eab6
Fix some no_move errors
2015-04-28 04:20:45 +05:30
Manish Goregaokar
63714ebc5f
Add the rust-tenacious move-protection lint, use it for Root<T>
( fixes #5724 )
2015-04-28 04:20:40 +05:30
snf
cdcd6670ba
fix defineproperty for cases with namedsetter
2015-04-27 23:47:22 +01:00
Ms2ger
ed052bc080
Move the sink into util::vec.
2015-04-27 23:44:22 +02:00
Patrick Walton
f0954f8799
layout: Generate anonymous table objects as necessary per CSS 2.1 §
...
17.2.1.
Improves Facebook Timeline.
2015-04-27 14:12:44 -07:00
Anthony Ramine
6e75889e41
Fix DOMImplementation.hasFeature()
2015-04-27 23:11:53 +02:00
bors-servo
8ecb9d681c
Auto merge of #5692 - pgonda:get_attributes-memory-safety, r=jdm
...
Changes Element::get_attributes to use a `&mut Rooted<JS<Attr>>` param instead of returning a `Vec<Temporary<Attr>>`, fixes #5684 .
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5692 )
<!-- Reviewable:end -->
2015-04-27 15:25:30 -05:00
bors-servo
b0a7d1bf86
Auto merge of #5777 - tamird:ICE-attr-prefix-atom, r=jdm
...
Rebase of https://github.com/Ms2ger/servo/commits/ICE-attr-prefix-atom
Some of the changes weren't necessary since the internals had been refactored some in the interim. In any case, I was unable to reproduce the ICE reported in https://github.com/rust-lang/rust/issues/18957 .
@Ms2ger
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5777 )
<!-- Reviewable:end -->
2015-04-27 14:37:38 -05:00
Ms2ger
9435565f85
Pass an Atom to Element::create.
2015-04-27 12:31:37 -07:00
Ms2ger
e8b02acb1d
Pass Atom to Attr:new for the prefix argument.
2015-04-27 12:20:23 -07:00
Ms2ger
89a0c004d5
Store an Atom for Attr::prefix.
2015-04-27 11:51:13 -07:00
bors-servo
eefa3eba25
Auto merge of #5872 - nox:canvasgradient, r=saneyuki
...
The argument should be a double.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5872 )
<!-- Reviewable:end -->
2015-04-27 13:45:17 -05:00
Ms2ger
811ea395bc
Avoid creating a vector in can_share_style_with.
2015-04-27 20:25:19 +02:00
bors-servo
9ec2ce0dec
Auto merge of #5868 - nox:document-legacy, r=jdm
...
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5868 )
<!-- Reviewable:end -->
2015-04-27 13:06:29 -05:00
Anthony Ramine
e8e7357e99
Fix CanvasGradient.addColorStop()
...
The argument should be a double.
2015-04-27 19:42:48 +02:00
Simon Sapin
11b3e3b775
Remove some usage of .as_slice()
.
2015-04-27 17:38:37 +02:00
Patrick Walton
0b6f84e6a1
Tidy fix
2015-04-27 17:12:08 +02:00
Patrick Walton
4d46d257cd
Address review comments
2015-04-27 17:12:08 +02:00
Patrick Walton
48299a53cb
layout: Implement most of border-collapse
per CSS 2.1 § 17.6.2.
...
Known issues:
* Collapsed borders do not correctly affect the border-box of the table
itself.
* The content widths of all cells in a column and the content height of
all cells in a row is the same in this patch, but not in Gecko and
WebKit.
* Corners are not painted well. The spec does not say what to do here.
* Column spans are not handled well. The spec does not say what to do
here either.
2015-04-27 17:12:07 +02:00
Peter
a270f3e39b
Switched Element::Get_attributes to use a RootedVec instead of returning a Vec<Temporary>, fixes #5684
2015-04-27 10:04:54 -04:00
bors-servo
92359c7b9a
Auto merge of #5850 - nox:nullary-callbacks, r=jdm
...
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5850 )
<!-- Reviewable:end -->
2015-04-27 08:42:42 -05:00
Anthony Ramine
16973624c8
Implement Body.bgColor and Document.bgColor
2015-04-27 15:28:37 +02:00
bors-servo
56105e9f2f
Auto merge of #5865 - gfxmonk:implicit-submit, r=Manishearth
...
With submission-blocking rules from https://html.spec.whatwg.org/multipage/forms.html#implicit-submission .
I wasn't sure if/where it would be relevant to add new tests (I couldn't find any existing tests in wpt to enable), so just let me know if this needs tests.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5865 )
<!-- Reviewable:end -->
2015-04-27 08:05:25 -05:00
Ms2ger
5fd753fda2
Factor out a handle_parsing_complete function from ScriptTask::Load.
2015-04-27 13:18:56 +02:00
Anthony Ramine
34070b1348
Complete Document WebIDL interface
2015-04-27 13:05:56 +02:00
Tim Cuthbertson
69110297c9
Implement implicit form submission from input elements
2015-04-27 19:46:41 +10:00