Commit graph

7795 commits

Author SHA1 Message Date
bors-servo
df8008cfe6 Auto merge of #11032 - mbrubeck:no-whitespace, r=pcwalton
Filter out whitespace glyphs from display list

Fixes #10244. r? @glennw

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11032)
<!-- Reviewable:end -->
2016-05-07 11:05:14 -07:00
bors-servo
e94f489e55 Auto merge of #11054 - mbrubeck:always-be-updating, r=Ms2ger
Update hyper, openssl, wayland, threadpool, offscreen_gl_context

Gets rid of duplicate versions of bitflags and xml-rs!

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11054)
<!-- Reviewable:end -->
2016-05-07 03:19:24 -07:00
bors-servo
f80641e7a1 Auto merge of #11039 - mbrubeck:strip-trailing, r=pcwalton
Remove redundant code in whitespace stripping

LineBreaker calls Fragment::strip_trailing_whitespace_if_necessary and then recalculates the fragment's inline size.  But this isn't necessary because strip_trailing_whitespace_if_necessary already recalculates the size.

r? @pcwalton

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11039)
<!-- Reviewable:end -->
2016-05-06 21:53:27 -07:00
bors-servo
a153e20c55 Auto merge of #11028 - szeged:webbluetooth, r=jdm
Remove BluetoothDevice members

Five of the BluetoothDevice members has been deleted in the spec:
8d148ba3c3

These were the vendorID, vendorIDSource, deviceClass, productID, productVersion.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11028)
<!-- Reviewable:end -->
2016-05-06 17:07:55 -07:00
bors-servo
17ba9fb5da Auto merge of #10821 - askeing:fix_10782, r=jdm
Checking the browsing_context before change title

fix #10782

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10821)
<!-- Reviewable:end -->
2016-05-06 14:20:45 -07:00
Matt Brubeck
9b680ad58a Update hyper, openssl, wayland, threadpool, offscreen_gl_context
Gets rid of duplicate versions of bitflags and xml-rs!
2016-05-06 08:42:00 -07:00
bors-servo
29ed650160 Auto merge of #11042 - fabricedesre:compositing-warning, r=metajack
Fix a build warning in compositor.rs

Stops the compiler complaining about `root_pipeline` being an unused variable.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11042)
<!-- Reviewable:end -->
2016-05-06 08:10:23 -07:00
bors-servo
d7fa1d8eed Auto merge of #11050 - mskrzypkows:css_issue, r=Ms2ger
Update cssparser to fix CSS.escape test failures

Fixes #10685

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11050)
<!-- Reviewable:end -->
2016-05-06 06:39:18 -07:00
Maciej Skrzypkowski
43b72537dc Update cssparser to fix CSS.escape test failures
Fixed failing tests #10685
2016-05-06 13:54:26 +02:00
bors-servo
bd871d613e Auto merge of #11037 - mbrubeck:parent-damage, r=pcwalton
Don't let restyle damage infect siblings

Currently `compute_layout_damage` does the following for each child of the node it's processing.

1. Update the child with damage from the parent.
2. Update the parent with damage from the child.

When these steps are repeated for the next child, the parent's damage may include flags that came from its previous sibling(s).  This means that damage ends up propagating to later siblings, and not just between parents and children as indended.

This patch propagates the same damage to all children, not including any damage from their siblings.

r? @pcwalton

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11037)
<!-- Reviewable:end -->
2016-05-06 02:01:03 -07:00
bors-servo
6c326cd372 Auto merge of #11034 - mbrubeck:always-be-updating, r=SimonSapin
Update libc, url, image, app_units

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11034)
<!-- Reviewable:end -->
2016-05-05 19:05:55 -07:00
bors-servo
ab12d8098f Auto merge of #11033 - mbrubeck:max-log, r=metajack
Set max log level on all platforms

Servo currently enabled the `release_max_level_info` feature for the log crate
in an Android-specific dependency.  Currently this works for all platforms
because of rust-lang/cargo#2524, but it might break if that issue is fixed.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11033)
<!-- Reviewable:end -->
2016-05-05 18:09:58 -07:00
Fabrice Desré
8489b30042 Fix a build warning in compositor.rs 2016-05-05 17:59:13 -07:00
Matt Brubeck
887f0e6454 Remove redundant code in whitespace stripping
LineBreaker calls Fragment::strip_trailing_whitespace_if_necessary and then
recalculates the fragment's inline size.  But this isn't necessary because
strip_trailing_whitespace_if_necessary already recalculates the size.
2016-05-05 16:46:31 -07:00
Matt Brubeck
dff1de46b2 Don't let restyle damage infect siblings
Currently `compute_layout_damage` does the following for each child of the
node it's processing.

1. Update the child with damage from the parent.
2. Update the parent with damage from the child.

When these steps are repeated for the next child, the parent's damage may
include flags that came from its previous sibling(s).  This means that damage
ends up propagating to later siblings, and not just between parents and
children as indended.

This patch propagates the same damage to all children, not including any
damage from their siblings.
2016-05-05 16:06:27 -07:00
bors-servo
b29ae6383a Auto merge of #11018 - bholley:list_style_type, r=mbrubeck
Geckolib: Implement list-style-type

Corresponding Gecko patch: https://bugzilla.mozilla.org/show_bug.cgi?id=1269933

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11018)
<!-- Reviewable:end -->
2016-05-05 12:23:37 -07:00
Matt Brubeck
f7c82e639e Update libc, url, image, app_units 2016-05-05 11:12:24 -07:00
Matt Brubeck
8f26c15a2e Set max log level on all platforms
Servo currently enabled the `release_max_level_info` feature for the log crate
in an Android-specific dependency.  Currently this works for all platforms
because of rust-lang/cargo#2524, but it might break if that issue is fixed.
2016-05-05 11:07:21 -07:00
Matt Brubeck
0f221521ab Filter out whitespace glyphs from display list
Fixes #10244.
2016-05-05 09:30:28 -07:00
bors-servo
0baf665721 Auto merge of #11017 - mbrubeck:rustup3, r=larsberstrom
Update to Rust nightly 2016-04-29

Patch by @fabricedesre from #11010, updated to fix test-tidy and to not conflict with other PRs in the queue. r? @larsbergstrom

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11017)
<!-- Reviewable:end -->
2016-05-05 09:04:22 -07:00
Fabrice Desré
073bd6ad21 Update to Rust nightly 2016-04-29 2016-05-05 08:12:59 -07:00
bors-servo
15c5c81b1f Auto merge of #11020 - ConnorGBrewster:fix_button_formsubmitter_methods, r=KiChjang
Fix formsubmitter methods for buttons

Fixes #11015
Fixes #11014

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11020)
<!-- Reviewable:end -->
2016-05-05 07:48:40 -07:00
zakorgy
ed92f31ebc Remove BluetoothDevice members 2016-05-05 12:47:52 +02:00
askeing
3c56d41699 Checking the browsing_context before change title, and adding wpt test 2016-05-05 14:12:03 +08:00
bors-servo
8bc4785bed Auto merge of #10999 - heycam:move-width-height, r=SimonSapin
Move width and height from Box to Position.

This helps with style struct alignment between Servo and Gecko.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10999)
<!-- Reviewable:end -->
2016-05-04 19:52:25 -07:00
bors-servo
ec5f826d18 Auto merge of #10998 - bholley:font_weight_and_logging, r=mbrubeck
Geckolib: implement font-weight and logging support

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10998)
<!-- Reviewable:end -->
2016-05-04 18:37:26 -07:00
bors-servo
c1252a40d9 Auto merge of #10993 - pcwalton:fix-animations, r=glennw
compositing: Perform animation-related compositing operations in WebRender.

I accidentally removed this code in #10936.

Fixes transitions.

r? @glennw

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10993)
<!-- Reviewable:end -->
2016-05-04 16:26:08 -07:00
Connor Brewster
169af6f35e fix formsubmitter methods for buttons 2016-05-04 16:39:41 -06:00
bors-servo
97dfcedbcf Auto merge of #11000 - pcwalton:wr-pipeline-relative-events, r=glennw
compositing: Send mouse events to the right pipeline when using WebRender.

Fixes mouse events in browser.html.

Requires servo/webrender_traits#47 and servo/webrender#272.

r? @glennw
cc @paulrouget

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11000)
<!-- Reviewable:end -->
2016-05-04 14:55:09 -07:00
Bobby Holley
f1f36efc96 Geckolib: Implement list-style-type. 2016-05-04 14:23:17 -07:00
bors-servo
35ba29355f Auto merge of #10691 - pcwalton:float-fixes, r=mbrubeck
layout: Fix float speculation with percentage inline sizes, rewrite vertical alignment, fix inline block ascent/descent computation, and fix absolute inline-block hypothetical boxes.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10691)
<!-- Reviewable:end -->
2016-05-04 13:49:23 -07:00
Patrick Walton
2bef5606bd layout: Minor whitespace cleanup. 2016-05-04 13:20:24 -07:00
Patrick Walton
d2511e33c6 layout: When printing out debug info for the float list, include
information about each float.
2016-05-04 13:20:23 -07:00
Patrick Walton
4ae6a68e35 layout: Fix non-vertical-align-correct wording in a comment. 2016-05-04 13:20:23 -07:00
Patrick Walton
0198a9dda8 layout: Include float information in flows' debug output. 2016-05-04 13:20:22 -07:00
Patrick Walton
9e1935c2ed layout: Make the hypothetical box for display: inline-block with
`position: absolute` inline per CSS 2.1 § 10.3.7.
2016-05-04 13:20:22 -07:00
Patrick Walton
b7c9674044 layout: Consider vertical alignment of fragments during line breaking.
This makes the line breaker determine the final block positions of each
line rather than doing it in a separate pass afterward. Not only does
this simplify the code, it makes `vertical-align` and float placement
interact properly.
2016-05-04 13:20:21 -07:00
Patrick Walton
04f05349b1 layout: Check flow descendants of inline block fragments to find their
baselines when aligning inline fragments per CSS 2.1 § 10.8.1.
2016-05-04 13:20:21 -07:00
Patrick Walton
8823f87276 layout: Don't pretend inline fragment sizes are zero when placing them
between floats.
2016-05-04 13:19:52 -07:00
Patrick Walton
94306cd183 layout: Speculate that the inline sizes of floats with percentage
inline sizes are nonzero.

This is a bit of a hack.
2016-05-04 13:19:51 -07:00
Patrick Walton
91907f563b compositing: Send mouse events to the right pipeline when using
WebRender.

Fixes mouse events in browser.html.

Requires servo/webrender_traits#47 and servo/webrender#272.
2016-05-04 11:40:15 -07:00
bors-servo
20fc8b3c8d Auto merge of #10932 - jdm:401, r=SimonSapin
Add the requesting URL to the 401 prompt. Only show the 401 prompt wh…

…en the WWW-Authenticate header is present.

Fixes #10912.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10932)
<!-- Reviewable:end -->
2016-05-04 11:37:16 -07:00
bors-servo
b4f573db1a Auto merge of #10840 - ConnorGBrewster:window_alert, r=jdm
Implement alert dialogs

fix #10812

Implements alert dialogs using tinyfiledialogs

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10840)
<!-- Reviewable:end -->
2016-05-04 09:10:40 -07:00
bors-servo
944a8dc25a Auto merge of #10632 - szeged:bluetooth-ipc, r=jdm
WebBluetooth impementation

Update the current WebBluetooth implementation.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10632)
<!-- Reviewable:end -->
2016-05-04 08:06:06 -07:00
bors-servo
29823cb378 Auto merge of #10934 - emilio:other-gecko-pseudos, r=bholley,mbrubeck
style: Add infrastructure to support lazy pseudo-elements

This builds on top of #10815, so it's really just the last commit the one that should be reviewed.

I tried to apply the new infrastructure to servo, but failed (for now?).

The problem with it is that it'd require `ThreadSafeLayoutElement` to implement `selectors::Element`, which is a lot of work and might be racy (not totally sure about it though). Thus, I prefered to keep selectors eager until knowing that it's safe to do it.

r? @mbrubeck for style changes, @bholley for the geckolib changes (minimal for now, glue + a list of lazy PEs must be added)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10934)
<!-- Reviewable:end -->
2016-05-04 03:42:23 -07:00
bors-servo
1a1ea30f8c Auto merge of #10959 - heycam:color, r=bholley
Support color-typed properties in geckolib

This is on top of https://github.com/servo/servo/pull/10957 though I'm not sure how to make that PR's commits not appear in this one.

r? @bholley

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10959)
<!-- Reviewable:end -->
2016-05-04 01:00:22 -07:00
bors-servo
2e849b7064 Auto merge of #10983 - notriddle:no_alloc_sort_display, r=mbrubeck
Minor reduction in the amount of allocation display list building does

Use `mem::replace` to perform the lifetime-trick without allocating a whole new buffer.

(An older of this switched from the built-in heapsort to a non-allocating introsort. Unfortunately, introsort is not a stable sorting algorithm, and the display list system relies on it being stable.)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10983)
<!-- Reviewable:end -->
2016-05-03 23:51:53 -07:00
Connor Brewster
dc85be4be5 Implement alert dialogs
Fixed conflict

Fixed merge issue

Finished implementation

Disable tinyfiledialogs on Windows

addressed comments

Use ancestor's SubpageId
Move display alert from method to function
Add extra test for nested iframes

Addressed comments

Updated tinyfiledialogs
2016-05-03 22:09:35 -06:00
Cameron McCormack
550d780e17 Move width and height from Box to Position.
This helps with style struct alignment between Servo and Gecko.
2016-05-04 11:06:42 +10:00
Bobby Holley
9fdb791e93 Geckolib: Implement font-weight. 2016-05-03 17:40:03 -07:00