Commit graph

2461 commits

Author SHA1 Message Date
Simon Sapin
284770aa02 Selector matching: tweak variable naming, add comments. 2013-10-02 01:37:03 +01:00
Simon Sapin
02364d7db7 Sorting on specificity needs to be stable for correctness of the cascade. 2013-10-02 01:19:36 +01:00
Simon Sapin
a04e96b7c6 Fix missing license header. 2013-10-02 00:31:57 +01:00
Simon Sapin
20089e4bea New style sytsem: add selector matching
Also make scribt::dom::element::Element::get_attr ASCII case-insensitive
on attribute names, per spec:
http://dom.spec.whatwg.org/#dom-element-getattribute
2013-10-02 00:28:14 +01:00
bors-servo
be5deb2a68 auto merge of #1002 : brson/servo/scriptthread, r=jdm
This appears to fix the problem with the Rust logo stopping during the demo.

Though this is the right way to spawn a SpiderMonkey thread, I'm not entirely sure why this fixes the problem in all scenarios. With enough threads (i.e. `RUST_THREADS=32`), and running with some Rust patches that are available on master (which I applied during testing), I would expect work stealing to not allow starvation here. In my tests though I see the problem even with lots of threads, so this may yet indicate a scheduler bug. Still, SpiderMonkey should get its own thread.
2013-10-01 15:52:41 -07:00
Brian Anderson
38ea00074c Run script in its own thread to avoid starving other tasks 2013-10-01 15:43:45 -07:00
bors-servo
5fc5542590 auto merge of #998 : jdm/servo/tracehook, r=metajack
Needs https://github.com/mozilla-servo/rust-mozjs/pull/38 and https://github.com/mozilla-servo/mozjs/pull/6. Fixes #819. Fixes #962.
2013-09-30 23:27:47 -07:00
Josh Matthews
cb826f9920 Make proxy bindings generate trace and finalization hooks. 2013-09-30 22:14:27 -04:00
bors-servo
74c3859548 auto merge of #996 : kmcallister/servo/azure-skia-fixes, r=larsbergstrom
Fixes #979.
2013-09-30 12:30:10 -07:00
Keegan McAllister
0f758b3d80 Fix crashes and leaks in Azure and Skia
Fixes #979.
2013-09-30 11:57:39 -07:00
bors-servo
1e4e8d5224 auto merge of #995 : jdm/servo/demoborders, r=larsbergstrom
Fixes #993.
2013-09-30 11:53:19 -07:00
Josh Matthews
2a0ec06bf3 Make borders show up on summit.html 2013-09-30 14:45:44 -04:00
Simon Sapin
226ccf7e72 Merge commit '25d6448f28' 2013-09-30 19:21:27 +01:00
Simon Sapin
25d6448f28 Fix SimonSapin/servo-style#2: failed assertion in selector parsing.
Add a test: "parse bootstrap.css without failing"
2013-09-30 17:46:18 +01:00
bors-servo
a3bad43e8a auto merge of #978 : ryanhc/servo/renderbox-cache, r=metajack 2013-09-25 20:06:42 -07:00
Ryan Choi
9fa389938c Update submodule 2013-09-26 11:42:15 +09:00
Ryan Choi
9a3a6f2829 Cache font-style and text-decoration to speed up can_merge_with_box() 2013-09-25 15:50:38 +09:00
bors-servo
c246188605 auto merge of #826 : metajack/servo/android-darwin, r=jdm
This cleans up configure and Makefile.in so that things build correctly on Darwin.

This needs https://github.com/mozilla-servo/nss/pull/6 before it can be merged. Please hold any r+ until that lands and I push the submodule update.
2013-09-24 13:09:40 -07:00
bors-servo
b7d186dec2 auto merge of #977 : kmcallister/servo/redirect, r=jdm 2013-09-24 12:45:44 -07:00
bors-servo
401176b72d auto merge of #966 : tikue/servo/master, r=metajack
Fixes #967 and #965 

This has been wrong for a long time. Previously, only the pipeline associated with the root frame evicted would be shut down. 1) It shouldn't necessarily be closed, because there could be references to it still in the navigation context, and 2) Presumably none of the children pipelines of the root frame were ever exiting.

It's hard to test this right now because #965 covers up other pipeline exiting issues, but when that's fixed, a pathological case in which things would have broken down would be:

1) Load a page with an iframe that contains a link
2) Click the link
3) Press backspace to navigate back
4) Navigate to any new page, at which point the forward page would be evicted from the navigation context, and the outer frame's pipeline would be shut down improperly.
5) Press backspace, at which point there is no longer a pipeline for the old page, because it was shut down prematurely. Presumably this would cause a crash.

I also changed the FrameTree function ```find_mut``` to ```find``` because find_mut implies it's doing something to cause mutability, but the mutability is caused by the type of object being iterated over, nothing else.

Additionally, script was exiting completely when receiving an exit message. Instead, it needs to handle exit messages according to who sent it. It should only close the subframes of the frame whose pipeline sent the exit message. This is now fixed.

Inexplicably, script was also closing the compositor upon receiving an exit message. This doesn't seem like it'd ever be the right thing to do. *Edit: this is _only_ the right thing to do when received from the window.* I've fixed that. I don't think anyone shuts down the compositor now. *Edit: the script shuts down the compositor only when receiving an exit from the window.*
2013-09-23 21:24:42 -07:00
Tim Kuehn
103cd6255d split script_task::ExitMsg into WindowExitMsg and PipelineExitMsg 2013-09-24 00:15:35 -04:00
Tim Kuehn
99f125bb64 script task only exits when the root pipeline exits 2013-09-24 00:03:52 -04:00
Tim Kuehn
c56b015623 find_mut ==> find. it's only mut because of the data type iterated over 2013-09-24 00:03:51 -04:00
Tim Kuehn
d77a07388f exit the correct evicted pipelines 2013-09-24 00:03:51 -04:00
Keegan McAllister
1c6de361b7 Handle HTTP 3xx redirects
Fixes #973.
2013-09-23 14:50:50 -07:00
Keegan McAllister
9bd0e2a3ac Remove an unneeded helper function 2013-09-23 14:50:50 -07:00
Keegan McAllister
69473b6c9c Make some debug prints more useful 2013-09-23 14:50:50 -07:00
bors-servo
d6769de467 auto merge of #972 : metajack/servo/parbuild-bugs, r=kmcallister
This fixes several makefile issues around parallel builds as well as some general cleanup.
2013-09-23 11:27:43 -07:00
Jack Moffitt
7ee000f613 Make rust submodules depend on rust. 2013-09-23 10:40:34 -06:00
Jack Moffitt
59151ad3dc Add *.dSYM to clean targets. 2013-09-23 10:40:09 -06:00
Jack Moffitt
3f9ce9b55e Build rustc with debugging enabled. 2013-09-23 10:39:58 -06:00
Jack Moffitt
194864af97 Fix nss/nspr depdency chain. 2013-09-23 10:38:46 -06:00
Jack Moffitt
3de7a1e4f6 Fix huge bug in makefile prevent rust from building with debugging or with -O. 2013-09-23 10:38:26 -06:00
bors-servo
0096d119f0 auto merge of #968 : luisbg/servo/master, r=larsbergstrom
update_window_title() is called constantly in the compositor loop. This function
always changes the title to "Servo" when in idle state so it is spamming the X
server with constant changes. But this isn't necessary because updating the
title is taken care of when the Rendering or Ready state are changed in
set_ready_state() and set_render_state().

Fixes #830

Happy Software Freedom Day
2013-09-22 16:54:46 -07:00
Luis de Bethencourt
5a95a30e14 Removing unnecessary constant window title update
update_window_title() is called constantly in the compositor loop. This function
always changes the title to "Servo" when in idle state so it is spamming the X
server with constant changes. But this isn't necessary because updating the
title is taken care of when the Rendering or Ready state are changed in
set_ready_state() and set_render_state().

Fixes #830

Happy Software Freedom Day
2013-09-22 19:25:48 -04:00
bors-servo
4f8b20ecc1 auto merge of #953 : saneyuki/servo/test, r=jdm 2013-09-21 07:54:45 -07:00
Tetsuharu OHZEKI
795c07209b Enable to pass a test message. 2013-09-21 15:15:46 +09:00
bors-servo
e576a1cf7e auto merge of #961 : tikue/servo/master, r=kmcallister
* Profiler is now close to a no-op when ```-p``` is not passed in
* The profiler's printing ```Timer``` now stops looping when the profiler is closed
* Most task ```Chans``` are now newtype ```structs```
* Some more ```Cell``` removals in places where ```spawn_with``` is appropriate
2013-09-20 15:39:46 -07:00
Tim Kuehn
5f600f0ec0 fix constellation being inundated with messages from script.
script task sent RendererReadyMsg after every reflow.
now, the renderer sends RendererReady at the appropriate time,
and _only_ if it doesn't have paint permission.
2013-09-20 18:36:26 -04:00
Tim Kuehn
84d731712f cleaned up code in constellation to make it more maintainable 2013-09-20 18:36:15 -04:00
Tim Kuehn
9df66ff021 workaround for broken cross-crate generic newtype structs
add issue number for newtype struct issue
2013-09-20 17:25:08 -04:00
Tim Kuehn
c804db0f93 deactive profiler when not in use; use newtype structs for task chans 2013-09-20 17:25:08 -04:00
bors-servo
17864cb25d auto merge of #963 : larsbergstrom/servo/summit, r=jdm
We need to figure out what we need to implement/fix for the summit, and this page pulls together all of the elements we want to show.
2013-09-20 09:51:57 -07:00
Lars Bergstrom
ee4a468c13 Start pulling together summit demo elements 2013-09-20 11:40:36 -05:00
bors-servo
dafb2c3d7f auto merge of #959 : luisbg/servo/master, r=jdm
Issue #924
2013-09-19 21:09:14 -07:00
Luis de Bethencourt
cfd726f7d6 Rename the node field of the DOM node hierarchy
Renamed the Node elements

Fixes #924
2013-09-19 19:39:38 -04:00
Luis de Bethencourt
2dbd065d91 Rename the element field of the DOM Node hierarchy
Renamed htmlelement, and element

Fixes #924
2013-09-19 19:39:38 -04:00
bors-servo
0ca4c19b57 auto merge of #957 : kmcallister/servo/inline-js, r=jdm 2013-09-19 15:03:52 -07:00
bors-servo
b85497b76a auto merge of #958 : tikue/servo/master, r=pcwalton
Cells are generally less readable, and spawn_with makes many of them unnecessary.
2013-09-19 14:36:56 -07:00
Tim Kuehn
6c28b5cc9c use spawn_with in lieu of cells 2013-09-19 17:28:49 -04:00