Bruno de Oliveira Abinader
e1a7d99df7
Added Element::set_custom_attribute
2014-12-19 14:07:43 -04:00
bors-servo
824788649c
auto merge of #4342 : jdm/servo/cssom, r=jdm,metajack
...
This does not implement any notion of CSSStyleDeclaration objects that do not have an owning element; there's no actual CSS object model in play here. This does support setting and getting properties of the style attribute for HTMLElement, and tries to implement the ambiguous CSS value serialization spec.
2014-12-18 11:54:52 -07:00
Josh Matthews
3cfe8ab53e
Address review comments.
2014-12-18 12:54:02 -05:00
Josh Matthews
9d82e06e64
Implement RemoveProperty, SetProperty, and supported property indices.
2014-12-18 12:54:02 -05:00
Josh Matthews
755ebd6528
Improve color serialization by retaining author-specified keywords.
2014-12-18 12:54:02 -05:00
Josh Matthews
6f8a9b6d46
Implement setting element style properties. Improve serialization to return initial values when unspecified.
2014-12-18 12:54:02 -05:00
Tetsuharu OHZEKI
135ee60f5a
style: Remove glob imports added in #4405
2014-12-19 01:49:24 +09:00
Ms2ger
466faac2a5
Update rustc to revision 3dcd2157403163789aaf21a9ab3c4d30a7c6494d.
2014-12-17 15:19:45 -05:00
bors-servo
5951056973
auto merge of #4133 : mttr/servo/form_resetting, r=jdm
...
We can reset `<input type=text>` fields! I wish I could've done something with checkboxes, but unfortunately, that's it for now.
In addition to that, this PR implements `HTMLInputAttribute.defaultValue`, updates wpt-test to expect passing tests as a result of that implementation, and fixes an index error crash with text inputs.
edit: also includes an html example where one may lazily watch form resets in action: ` tests/html/form_reset_handsfree.html`
2014-12-16 15:03:49 -07:00
Matthew Rasmus
504f968b20
Implements :indeterminate pseudo-class
...
Addresses reviews
2014-12-16 11:34:04 -08:00
Matthew Rasmus
fc0748f50e
Makes layout respect <textarea> rows attribute
...
review addresssing
2014-12-16 11:02:01 -08:00
Matthew Rasmus
2c7f6076d1
Makes layout respect <textarea> cols attribute
2014-12-16 10:44:15 -08:00
bors-servo
746b262ff4
auto merge of #4374 : thiagopnts/servo/dispatch-event, r=Ms2ger
...
servo/pull/4369 with the right commit.
2014-12-16 06:36:47 -07:00
thiagopnts
79487252ca
Add auxiliary method to EventTargetHelpers for events without target
...
fixup! Add auxiliary method to EventTargetHelpers for events without target
2014-12-16 10:01:38 -02:00
Patrick Walton
a1ea44b294
style: Address review comments relating to bgcolor
and column spans
2014-12-15 18:09:44 -08:00
Patrick Walton
56b78de5bc
style: Implement basic column spans.
...
This patch provides some of the groundwork for column spans greater than
1. It implements the column-span CSS property (prefixed so as not to be
exposed to content) as well as the corresponding colspan attribute;
although the former is not well-specified outside of CSS multi-column
layout, INTRINSIC refers to it. Although width is distributed to
spanning columns, they do not yet contribute minimum and preferred
widths; this will be implemented in a follow-up.
Additionally, this patch cleans up some miscellaneous formatting issues
and improves the handling of table rowgroups.
2014-12-15 17:41:51 -08:00
Patrick Walton
14bafb11be
style: Parse the legacy bgcolor
attribute per the HTML5 specification.
...
Additionally, this patch cleans up some miscellaneous formatting issues.
2014-12-15 17:41:44 -08:00
Patrick Walton
10f1ed5e31
style: Parse the legacy border
attribute per the legacy HTML specification.
...
Additionally, this patch cleans up some miscellaneous formatting issues
and refactors files in `layout/css/` somewhat to eliminate needless
levels of indirection. It also fixes our handling of presentational
hints that only apply if border is nonzero.
2014-12-15 17:41:37 -08:00
Patrick Walton
d101c1dd91
script: Improve dirty propagation and fix script-layout synchronization.
...
This fixes race conditions whereby layout and script could be running
simultaneously.
2014-12-15 14:16:04 -08:00
bors-servo
2615be9bab
auto merge of #4189 : chmanchester/servo/rootlint, r=jdm
...
I think this matches the intent of the issue, I'm a rust/servo novice; any suggestions for improvements are welcome. Thanks!
2014-12-11 15:57:58 -07:00
Chris Manchester
d25bc49772
Return early and decline analysis when linting within unsafe functions for must_root analysis.
...
Removes a handful of whitelist annotations obsoleted by this change. fixes #3658
2014-12-09 02:10:39 -05:00
Matthew Rasmus
1b84bd22b8
Implements the :checked pseudo-class for inputs
...
Relevant spec:
https://html.spec.whatwg.org/multipage/scripting.html#selector-checked
Also modifies HTMLInputElement::SetChecked to no longer modify its
checked content value, instead making use of its internal checkedness
state now that we can match `:checked` properly.
2014-12-08 08:40:15 -08:00
bors-servo
c68e2af0a7
auto merge of #4263 : Ms2ger/servo/or_init, r=jdm
2014-12-06 08:01:06 -07:00
Ms2ger
f0ef1f97ad
Use or_init where appropriate.
2014-12-06 15:59:17 +01:00
bors-servo
19c69b1625
auto merge of #4002 : Manishearth/servo/activation, r=jdm
...
Still need to impl `Activatable` on all activatable elements. I'll probably push those changes to this PR, however they can be made separately as well.
2014-12-06 03:55:04 -07:00
Manish Goregaokar
5511e02a78
Add Comparable trait to js.rs; fixups
2014-12-06 02:51:52 -08:00
Ms2ger
6322b0bfab
Clarify the panic in get_uint_attribute.
2014-12-06 10:19:05 +01:00
Manish Goregaokar
e7ac792ed6
Switch to NodeFlags (the footprint has not changed)
2014-12-05 18:34:53 -08:00
Manish Goregaokar
a2f7e0fbd6
Address review comments
2014-12-05 18:34:51 -08:00
Manish Goregaokar
d1547e3a7c
Move InputSubmit to Activatable
2014-12-05 18:32:13 -08:00
Manish Goregaokar
2ed9626f1a
Some reorganization of activation code:
...
- Make method name apply to trait implementor better (When a user agent is to run post-click activation steps on an element, it must run the activation behavior defined for that element)
- Mention invariants and conditions on authentic_click_activation
2014-12-05 18:32:12 -08:00
Manish Goregaokar
ddfa0c7de7
Implement basic (unhooked) framework for element activation
2014-12-05 18:32:12 -08:00
aakashjain
fab09a5137
Fixes #4123
2014-11-29 15:06:17 +05:30
Tetsuharu OHZEKI
1305ac4dd0
Remove Element.node().
2014-11-28 06:05:45 +09:00
bors-servo
60dfb65ab2
auto merge of #4068 : Manishearth/servo/atomify, r=jdm
2014-11-23 22:00:40 -07:00
Manish Goregaokar
534919327d
Use atom! in place of Atom::from_slice where necessary
2014-11-23 22:03:27 +05:30
Rohan Prinja
4b754bd457
implement Document#createAttribute
2014-11-23 14:51:04 +05:30
Ms2ger
86d609abaf
Use RefCell in DOMRefCell to reduce duplicated code.
2014-11-14 21:18:43 +01:00
Josh Matthews
80764f65e3
Add single-line text input with no visible cursor.
2014-11-13 12:53:54 -05:00
Jack Moffitt
d1b433a3b3
Rust upgrade to rustc hash b03a2755193cd756583bcf5831cf4545d75ecb8a
2014-11-13 11:17:43 +10:00
bors-servo
fba6cb9c42
auto merge of #3897 : Ms2ger/servo/enable-reflection, r=Manishearth
2014-11-05 11:12:40 -07:00
Ms2ger
214c356ecd
Pass an Atom to VirtualMethods::parse_plain_attribute.
2014-11-05 16:19:11 +01:00
Ms2ger
cdde96e989
Defer to GetAttribute in HasAttribute.
...
The semantics of has_attribute aren't anywhere close to the ones expected for
Element#hasAttribute, and it fails an assertion when passed non-lower-case
names.
2014-11-05 16:05:06 +01:00
Bruno de Oliveira Abinader
5db3eb0cee
Cleanup Element's AttributeHandlers
...
Remove notify_attribute_{changed,removed} in favor of a unified
notify_content_changed.
2014-10-30 17:14:25 -04:00
bors-servo
7de9ed5fc7
auto merge of #3856 : Ms2ger/servo/tagname, r=Manishearth
...
format!("{}", atom) yields strings like "Atom('span' type=Inline)", which is
not intended here.
2014-10-30 12:27:35 -06:00
Ms2ger
82216fd5c0
Move build_element_from_tag out of the HTML parser.
...
This function is not particular to the parser, so should live in the DOM.
2014-10-30 18:03:19 +01:00
Ms2ger
671a487145
Format Element#tagName correctly when there's a prefix.
...
format!("{}", atom) yields strings like "Atom('span' type=Inline)", which is
not intended here.
2014-10-30 11:51:27 +01:00
Clark Gaebel
a8f80b89f4
layout: Implement flow tree dumping with RUST_LOG=debug is on.
...
r? @pcwalton
2014-10-28 10:14:12 -07:00
Ms2ger
d643ade7e8
Introduce LayoutDocumentHelpers::is_html_document_for_layout for LayoutElementHelpers::html_element_in_html_document_for_layout.
2014-10-23 18:20:11 +02:00
Bruno de Oliveira Abinader
bbab8831e0
Usage of JSRef<Attr> in before_remove_attr & after_set_attr
...
JSRef<Attr> does not require allocating a DOMString for value, which are
unused in most cases. It also provides more access to Attr data.
2014-10-22 11:13:58 -04:00