Commit graph

12863 commits

Author SHA1 Message Date
Philipp Hartwig
8d67914c7f Add form getters for additional elements; update test expectations
This adds form getters for fieldset, label, object, output, select and
textarea elements.
2015-09-27 19:08:53 +02:00
bors-servo
9523283c14 Auto merge of #7643 - jdramani:extra_ptr_dref, r=jdm
Check for Extra pointer dereferencing

Solves issue #7640

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7643)
<!-- Reviewable:end -->
2015-09-27 08:19:30 -06:00
bors-servo
a1fb8cfbb0 Auto merge of #7752 - tamird:fix-osx-notifications, r=nox
mach: fix OS X notifications

Since mach now puts everything into a virtualenv, we need to set the bundle identifier to allow sending notifications.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7752)
<!-- Reviewable:end -->
2015-09-27 07:35:50 -06:00
bors-servo
599fd0094b Auto merge of #7754 - Jayflux:#7744, r=nox
changing test_union.html to union.html fixes #7744



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7754)
<!-- Reviewable:end -->
2015-09-27 06:25:42 -06:00
Jayflux
e6442767ed changing test_union.html to union.html fixes #7744 2015-09-27 11:15:48 +01:00
Jaydeep
2a99915188 Check for Extra pointer dereferencing. Issue #7640. 2015-09-26 19:33:29 -07:00
Tamir Duberstein
b6bbd75479 mach: fix OS X notifications 2015-09-26 16:14:45 -04:00
Corey Farwell
dec0031112 Implement <option> 'defaultSelected' and 'selected' attributes
Continued from #7743
2015-09-26 15:38:54 -04:00
bors-servo
37ce248f31 Auto merge of #7733 - nox:checked, r=Manishearth
Properly consider radio button groups

Radio button groups with missing or empty names are always the only element of their respective radio button group.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7733)
<!-- Reviewable:end -->
2015-09-26 11:21:11 -06:00
bors-servo
d4f5948294 Auto merge of #7746 - eefriedman:debug-dead-code, r=nox
Delete dead code.

(#[cfg(debug)] is false in every normal servo configuration, and the
code in question doesn't compile.)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7746)
<!-- Reviewable:end -->
2015-09-26 10:45:51 -06:00
bors-servo
500d509865 Auto merge of #7747 - frewsxcv:bgcolor, r=Ms2ger
Imlement 'bgcolor' IDL attrs for table elements

The content attributes and presentational hints were implemented in
the #4289 pull request. This just implements the relevant IDL
attributes.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7747)
<!-- Reviewable:end -->
2015-09-26 10:02:43 -06:00
Corey Farwell
a844b080d6 Imlement 'bgcolor' IDL attrs for table elements
The content attributes and presentational hints were implemented in
the #4289 pull request. This just implements the relevant IDL
attributes.
2015-09-26 10:15:58 -04:00
Eli Friedman
f0da2a3701 Delete dead code.
(#[cfg(debug)] is false in every normal servo configuration, and the
code in question doesn't compile.)
2015-09-26 00:23:03 -07:00
bors-servo
d39c8546b6 Auto merge of #7742 - mbrubeck:update-bidi, r=Manishearth
Update unicode-bidi to 0.2.2

Fixes #7701 via servo/unicode-bidi#17.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7742)
<!-- Reviewable:end -->
2015-09-25 14:23:50 -06:00
Matt Brubeck
5667dfe7b0 Update unicode-bidi to 0.2.2
Fixes #7701 via servo/unicode-bidi#17.
2015-09-25 13:01:53 -07:00
bors-servo
b7c003f158 Auto merge of #7741 - Wafflespeanut:warning_fix, r=jdm
fixed the deprecated `as_slice` warning...

I've put its original implementation from [`core/option.rs`](http://doc.servo.org/src/core/option.rs.html#692) instead of the dear departed `as_slice`

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7741)
<!-- Reviewable:end -->
2015-09-25 13:47:37 -06:00
Ravi Shankar
35d7ced89e fixed the 'as_slice' deprecated warning 2015-09-26 00:51:04 +05:30
bors-servo
8027777e24 Auto merge of #7497 - psdh:devtest7473, r=jdm
tests for devtools integration with network requests/responses

Fixes #7473

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7497)
<!-- Reviewable:end -->
2015-09-25 11:35:57 -06:00
bors-servo
0f8c1b4601 Auto merge of #7682 - ecoal95:webgl-texture2d, r=jdm
webgl: Support texImage2D with a canvas as an argument

This involved some refactoring of the 2d context code, which lead to some more test passed there.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7682)
<!-- Reviewable:end -->
2015-09-25 10:52:52 -06:00
Emilio Cobos Álvarez
17a9472745 webgl: Add test for passing a canvas with no context as texture source 2015-09-25 18:47:37 +02:00
Prabhjyot Singh Sodhi
920bb5e4b8 tests for devtools integration with network requests/responses 2015-09-25 22:07:01 +05:30
Emilio Cobos Álvarez
90775a7595 script: Return a white bitmap if the canvas has a size but no context 2015-09-25 18:10:50 +02:00
Emilio Cobos Álvarez
d12dbf94f2 Refactor if let Some(a) { Some(b) } else { None }
Prefer `Option::map` instead.
2015-09-25 16:34:08 +02:00
Emilio Cobos Álvarez
5d7d745ab4 webgl: Add tests for canvas texturing 2015-09-25 16:20:31 +02:00
Emilio Cobos Álvarez
e2b7a01055 webgl: texImage2D with a canvas argument 2015-09-25 16:20:31 +02:00
bors-servo
e04c2c78ee Auto merge of #7651 - jgraham:prefs_reset, r=Ms2ger
Implement resettable and String-valued prefs.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7651)
<!-- Reviewable:end -->
2015-09-25 08:18:06 -06:00
bors-servo
a58e731abd Auto merge of #7738 - Ms2ger:update-css, r=Ms2ger
Update CSS tests to revision 939546644b4d333218fd9c2c0f68c60752ff1e95



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7738)
<!-- Reviewable:end -->
2015-09-25 04:55:03 -06:00
Ms2ger
0ad6e78b23 Update CSS tests to revision 939546644b4d333218fd9c2c0f68c60752ff1e95 2015-09-25 12:54:36 +02:00
bors-servo
b26fac3f78 Auto merge of #7685 - bjwbell:add-twitter-fail-whale-attribution, r=pcwalton
Replace twitter fail whale with redirect to archive.org version

Sorry @pcwalton should have gotten the attribution approved first (https://twitter.com/subcide/status/645149674546966528)

r? @pcwalton

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7685)
<!-- Reviewable:end -->
2015-09-24 20:40:49 -06:00
bors-servo
d7b8751709 Auto merge of #7736 - pcwalton:less-ambitious-optimize-set-property, r=Ms2ger
Less ambitious optimize set property

Splitting the parts that have r+ out of #6823.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7736)
<!-- Reviewable:end -->
2015-09-24 19:57:40 -06:00
Patrick Walton
075fd6818c script: Wrap a long line. 2015-09-24 18:54:54 -07:00
Patrick Walton
5dce5f0c97 script: Stop copying the document URL. 2015-09-24 18:54:53 -07:00
bors-servo
4d1be2f56c Auto merge of #7703 - bjwbell:bugfix-0px-and-non-0px-border-widths, r=pcwalton
gfx: Fix border-radius panic when a corner has 0px and >0px borders

When one border is 0px and the other is >0px then the border corner
drawing code panics when computing the values to use in drawing the
border corner arcs.

This fixes that bug and makes the `draw_corner` function more robust
by explicitly passing an enum, `BorderCorner`, naming which corner is
being drawn e.g. `BorderCorner::TL`.

Add a ref test,
`border_radius_zero_sizes_a.html/border_radius_zero_sizes_ref.html`.

Fixes https://github.com/servo/servo/issues/7700.

r? @pcwalton or @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7703)
<!-- Reviewable:end -->
2015-09-24 18:18:07 -06:00
James Graham
bd4e0a1439 Add pref reset support to the WebDriver API. 2015-09-25 00:58:53 +01:00
James Graham
8d9ab50a96 Add a pref for a default homepage. 2015-09-25 00:58:51 +01:00
James Graham
79e548905e Enable resetable and String prefs.
This allows both boolean and string-type preferences. It
also implements a system where prefs that are read from a
configuration file can be reset back to their initial value,
which is useful in a number of cases e.g. when running tests
to ensure that each test starts with the same values for
the prefs.
2015-09-25 00:58:48 +01:00
Anthony Ramine
e72b77b1e3 Properly consider radio button groups
Radio button groups with missing or empty names are always the only element
of their respective radio button group.
2015-09-25 00:29:03 +02:00
Anthony Ramine
01ea761bd0 Use an atom for HTMLInputElement's name attribute's value 2015-09-25 00:04:43 +02:00
bors-servo
d811f2d1ba Auto merge of #7729 - Ms2ger:reftest-gates, r=jdm
Remove the now-stable append and result_expect feature gates from reftest.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7729)
<!-- Reviewable:end -->
2015-09-24 12:33:46 -06:00
bors-servo
30ffd09eb3 Auto merge of #7675 - jgraham:freeze_crash, r=metajack
Prevent crash trying to freeze script task with no page.

This fixes a crash resulting from a race between loading an initial
document and navigating to a subsequent document. If the navigation
happens before the initial document has had a chance to create its
root page, we crash trying to unwrap a None. Note that the are likely
further similar timing issues with more complex sequences of navigation
and history manipulation.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7675)
<!-- Reviewable:end -->
2015-09-24 11:05:28 -06:00
Ms2ger
67f12639ab Remove the now-stable append and result_expect feature gates from reftest. 2015-09-24 18:42:02 +02:00
bors-servo
2d253cbf83 Auto merge of #7728 - Ms2ger:box-raw, r=mbrubeck
Remove the now-stable box_raw feature gate from cef.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7728)
<!-- Reviewable:end -->
2015-09-24 10:37:40 -06:00
Ms2ger
561368fdd5 Remove the now-stable box_raw feature gate from cef. 2015-09-24 18:36:10 +02:00
James Graham
f8cd0d9b3b Prevent crash trying to freeze script task with no page.
This fixes a crash resulting from a race between loading an initial
document and navigating to a subsequent document. If the navigation
happens before the initial document has had a chance to create its
root page, we crash trying to unwrap a None. Note that the are likely
further similar timing issues with more complex sequences of navigation
and history manipulation.
2015-09-24 13:43:05 +01:00
bors-servo
2623f58a4b Auto merge of #7719 - Manishearth:ghfix, r=Ms2ger
Various fixes to make github less error-prone

r? @Ms2ger

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7719)
<!-- Reviewable:end -->
2015-09-24 03:55:29 -06:00
Manish Goregaokar
982e55ac1c Add better stringifier for DOMException 2015-09-24 11:58:28 +05:30
Manish Goregaokar
b677f0f4ae Add form getter for input/button elements; update test expectations 2015-09-24 11:58:24 +05:30
Manish Goregaokar
ed30923156 Add test for preserveWrapperCallback 2015-09-24 11:58:05 +05:30
Manish Goregaokar
ca31b2d749 Add preserveWrapperCallback (fixes #7218) 2015-09-24 08:06:29 +05:30
bors-servo
b4b3cedc10 Auto merge of #7724 - glennw:expire-anims, r=pcwalton
Ensure that animations expire correctly and stop compositing occurring after they finish.

There were two problems here:

(1) The animation state update function was only called when nodes were dirty or there were new animations.
(2) When all animations for a node expired, the entry from the hash table was not removed.

The result was that once an animation began, the compositor would be running as fast as it can forever.

Fixes #7721.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7724)
<!-- Reviewable:end -->
2015-09-23 18:46:29 -06:00