Commit graph

31212 commits

Author SHA1 Message Date
Connor Brewster
43526c80bb Add a check for when the js execution stack is empty 2018-01-11 11:14:10 -05:00
Connor Brewster
87475b11d3 Implement the create an element for token algorithm 2018-01-11 11:14:10 -05:00
bors-servo
9b3fc43f5a Auto merge of #19744 - emilio:doc-invalidation-preparation, r=upsuper
style: A few trivial changes in preparation for document state invalidation.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19744)
<!-- Reviewable:end -->
2018-01-11 07:50:55 -06:00
Emilio Cobos Álvarez
268f0f75b9
style: Factor out a few invalidation functions that are going to be shared soon. 2018-01-11 14:49:31 +01:00
Emilio Cobos Álvarez
b91efadd8d
style: Move invalidation::element::collector to invalidation::element::state_and_attributes.
Since it's what that file is about.
2018-01-11 14:49:31 +01:00
Emilio Cobos Álvarez
b6a2bff032
style: Move :-moz-locale-dir matching to rust. 2018-01-11 14:47:29 +01:00
bors-servo
1a4df8f876 Auto merge of #19716 - pyfisch:conversions, r=emilio
Use a ToLayout trait for converting from style to webrender types

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19716)
<!-- Reviewable:end -->
2018-01-11 03:41:43 -06:00
bors-servo
f47cd758fa Auto merge of #19743 - EdgarChen:unresolved, r=heycam
style: Remove :unsolved pseudo-class

<!-- Please describe your changes on the following line: -->

This is the servo part changes of https://bugzilla.mozilla.org/show_bug.cgi?id=1417829.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix https://bugzilla.mozilla.org/show_bug.cgi?id=1417829.

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because this PR is to remove a feature.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19743)
<!-- Reviewable:end -->
2018-01-10 21:06:04 -06:00
bors-servo
a22bff8119 Auto merge of #19683 - servo:rustup, r=jdm
Upgrade to rustc 1.24.0-nightly (0a3761e63 2018-01-03)

Fixes #19635
Fixes #19637
Fixes #19735
Fixes #19519

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19683)
<!-- Reviewable:end -->
2018-01-10 14:00:32 -06:00
Simon Sapin
828780d17b Upgrade to rustc 1.24.0-nightly (0a3761e63 2018-01-03) 2018-01-10 20:54:35 +01:00
Simon Sapin
4d459bce32 Fix tyvar_behind_raw_pointer warnings
https://github.com/rust-lang/rust/issues/46906
2018-01-10 20:54:35 +01:00
Simon Sapin
cee2aadd82 Disable incremental compilation on CI
We don’t keep the `target` directory between builds,
and incremental cache takes a lot of space.
2018-01-10 20:54:35 +01:00
Simon Sapin
c8f542afac We use Nigthly Cargo with Stable Rust
Nightly now has incremental compilation as a stable feature,
but that’s not in the stable channel yet.
2018-01-10 20:54:35 +01:00
Simon Sapin
59bb421ea1 Don’t set codegen-units to 4.
The default is now 16:
b5361d0d41/src/librustc/session/mod.rs (L738-L788)
2018-01-10 20:54:35 +01:00
Bastien Orivel
54f67c3fbe Bump gl_generator to 0.8
Fixes #19735
2018-01-10 20:48:15 +01:00
bors-servo
e9f9fd1e4c Auto merge of #19739 - gootorov:master, r=jdm
Add note to Gentoo setup to set LIBCLANG_PATH envvar

<!-- Please describe your changes on the following line: -->
Without `LIBCLANG_PATH` environment variable set the build for `gecko-media` fails as in https://github.com/servo/servo/issues/19351 for Gentoo Linux. This patch adds a note to the README to set the environment variable.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because it is a documentation fix

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19739)
<!-- Reviewable:end -->
2018-01-10 13:05:17 -06:00
bors-servo
2be49ac806 Auto merge of #19395 - servo:rustup.rs, r=jdm
Use rustup.rs instead of custom bootstrap

Fixes #11361, closes #18874, fixes #19365.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19395)
<!-- Reviewable:end -->
2018-01-10 12:00:59 -06:00
Simon Sapin
0681e682e9 rustup.rs: Use MSVC rather than GNU toolchains on Windows 2018-01-10 18:05:46 +01:00
Simon Sapin
ded0bc9365 Revert "Use rustup "proxies" instead of rustup run"
This reverts commit ad22368646290510149d33a0a41fc436ac4a0e96.
2018-01-10 18:05:45 +01:00
Simon Sapin
2618e4ed9d Use rustup "proxies" instead of rustup run
To make sure we’re indeed running rustup’s proxy
rather than some other `cargo` for example,
run the `rustup` executable with a different `argv[0]`.
2018-01-10 18:05:45 +01:00
Simon Sapin
e0f8f09c05 Fix "rustup is not installed" message 2018-01-10 18:05:45 +01:00
Simon Sapin
d0b3525474 Cache rustup toolchains on AppVeyor and Travis-CI 2018-01-10 18:05:45 +01:00
Simon Sapin
a3339f97c3 Print a better error message when rustup is too old 2018-01-10 18:05:44 +01:00
Simon Sapin
2f941d8450 Print a link to instructions if rustup is not found. 2018-01-10 18:05:44 +01:00
Simon Sapin
f2c398fd5c Add rustup.rs instructions in README 2018-01-10 18:05:44 +01:00
Simon Sapin
365a139716 Use rustup.rs instead of custom bootstrap
Fixes #11361, closes #18874
2018-01-10 18:05:44 +01:00
Simon Sapin
6dff251e35 Revert "Use rustdoc --document-private-item instead of deprecated flags"
This reverts commit d96f0ff6a7.
2018-01-10 18:05:28 +01:00
Josh Matthews
12ad5b6a3d
Allow warnings during mutation tests. 2018-01-10 12:04:45 -05:00
bors-servo
2065fa6da2 Auto merge of #19727 - nox:cr-placeholder, r=emilio
Properly handle CR in textarea placeholders (fixes #19717)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19727)
<!-- Reviewable:end -->
2018-01-10 10:37:47 -06:00
Igor Gutorov
8f68d2d1de Add note to Gentoo setup to set LIBCLANG_PATH envvar 2018-01-10 17:04:50 +02:00
Anthony Ramine
6f9003c052 Properly handle CR in textarea placeholders (fixes #19717) 2018-01-10 15:34:54 +01:00
bors-servo
ad622a46f0 Auto merge of #19737 - CYBAI:move-paint-order-out-of-mako, r=emilio
style: Move paint-order outside of mako

This is a sub-PR of #19015
r? emilio

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19736
- [x] These changes do not require tests

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19737)
<!-- Reviewable:end -->
2018-01-10 07:59:04 -06:00
CYBAI
2bc02bc78d style: Move paint-order outside of mako 2018-01-10 21:26:33 +08:00
Edgar Chen
4c778b34e6 style: Remove :unsolved pseudo-class
This is the servo part changes of https://bugzilla.mozilla.org/show_bug.cgi?id=1417829.
2018-01-10 17:20:06 +08:00
bors-servo
e2c89df8ee Auto merge of #19734 - emilio:less-indirection, r=mbrubeck
style: Remove some unneeded indirection.

All TElement's implement Copy, and are just pointers, so the double indirection
is stupid.

I'm going to try to see if removing this double-indirection fixes some
selector-matching performance, and this is a trivial pre-requisite while I wait
for Talos results.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19734)
<!-- Reviewable:end -->
2018-01-09 23:34:15 -06:00
bors-servo
afe298b53d Auto merge of #19730 - NLincoln:19172-number-input-type-validations, r=KiChjang
number input type validations

I used rust's builtin float parser to implement this. Rust's parser is more permissive than what browsers support (in this case), so I added some code to handle those edge cases.

This passes all the prewritten test cases locally, but I fell asleep last night before updating the manifests 😅

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes are part of #19172

<!-- Either: -->
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19730)
<!-- Reviewable:end -->
2018-01-09 22:15:12 -06:00
Emilio Cobos Álvarez
8f6455b9df
style: Remove some unneeded indirection.
All TElement's implement Copy, and are just pointers, so the double indirection
is stupid.

I'm going to try to see if removing this double-indirection fixes some
selector-matching performance, and this is a trivial pre-requisite while I wait
for Talos results.
2018-01-10 03:56:34 +01:00
bors-servo
e5a0bb9b4d Auto merge of #19733 - emilio:less-unwrap, r=glennw
style: Use Option::get_or_insert_with.

Less unwraps is better.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19733)
<!-- Reviewable:end -->
2018-01-09 20:50:12 -06:00
Emilio Cobos Álvarez
3595c98411
style: Use Option::get_or_insert_with.
Less unwraps is better.
2018-01-10 03:39:29 +01:00
Nathan
5b6e821559 input type=number validations 2018-01-09 20:08:09 -06:00
bors-servo
d0300ffd67 Auto merge of #19732 - gootorov:master, r=jdm
Update Gentoo Linux setup to include clang

<!-- Please describe your changes on the following line: -->While other Linux distributions include clang package as required in the setup section of README, Gentoo does not. This patch fixes it.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because it is a documentation fix

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19732)
<!-- Reviewable:end -->
2018-01-09 17:27:47 -06:00
Igor Gutorov
457c3de065 Update Gentoo Linux setup to include clang 2018-01-09 23:45:43 +02:00
bors-servo
94b188d6c1 Auto merge of #19728 - servo:wptup, r=jdm
Update web-platform-tests

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19728)
<!-- Reviewable:end -->
2018-01-09 12:38:08 -06:00
Josh Matthews
de1c2394a5 Avoid for(const ... of ...) usage in webidl parser.
Servo's JS engine doesn't support this construct yet.
2018-01-09 12:52:28 -05:00
Josh Matthews
2b6f573eb5 Update web-platform-tests to revision be5419e845d39089ba6dc338c1bd0fa279108317 2018-01-09 12:52:27 -05:00
bors-servo
6a6dda5269 Auto merge of #19720 - aneeshusa:support-env-vars-in-buildbot-steps, r=jdm
Update buildbot_steps lint to handle env variables

https://github.com/servo/saltfs/pull/687 added support
for specifying environment variables in `buildbot_steps.yml`.
Update the servo-tidy buildbot_steps.yml linter to reflect this.

Use the voluptuous Python library (BSD 3-clause license) for validation
in lieu of a much larger hand-written implementation.

Extracted out of #17171. Helps with servo/saltfs#770.

<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because they change the tests

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19720)
<!-- Reviewable:end -->
2018-01-09 11:40:27 -06:00
Aneesh Agrawal
e9eaadc913 Deny warnings in rust code globally in CI
Use the new environment variable support for `buildbot_steps.yml`
to do this globally instead of having to patch every call,
which is error prone.

Set this variable globally in .travis.yml and appveyor.yml as well.
2018-01-09 17:13:48 +01:00
bors-servo
d9800191e7 Auto merge of #19725 - glennw:update-wr-bs-line, r=mbrubeck
Update WR (inset box shadow fix, line decoration optimizations)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19725)
<!-- Reviewable:end -->
2018-01-09 08:22:13 -06:00
bors-servo
bb34b7f54a Auto merge of #19721 - emilio:slotted, r=heycam
style: Support ::slotted better.

This allows to selector-match ::slotted, though we still don't parse it.

Bug: 1425834, 1424607, 1425755
Reviewed-by: heycam
MozReview-Commit-ID: ItELHkf2PMl

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19721)
<!-- Reviewable:end -->
2018-01-09 07:26:28 -06:00
Emilio Cobos Álvarez
bfc91c5e12
style: Update bindings. 2018-01-09 14:26:06 +01:00