Bruno de Oliveira Abinader
bbab8831e0
Usage of JSRef<Attr> in before_remove_attr & after_set_attr
...
JSRef<Attr> does not require allocating a DOMString for value, which are
unused in most cases. It also provides more access to Attr data.
2014-10-22 11:13:58 -04:00
Manish Goregaokar
3f2cbb275b
Use #[dom_struct] everywhere
2014-10-16 10:20:18 +05:30
Tetsuharu OHZEKI
2d5d1e36ad
Use DOMRefCell<T> in Attr.
2014-10-15 13:41:03 +09:00
Patrick Walton
ee2ccc4f87
script: Use atom comparison in more places, especially for attributes.
...
75% improvement in style recalc for Guardians of the Galaxy.
2014-10-14 10:32:40 -07:00
Tim Taubert
78fef7eec5
Privatize Attr
2014-10-13 13:18:57 +02:00
Tim Taubert
35f8270c64
Remove unnecessary deref()s ( fixes #3586 )
2014-10-09 15:01:54 +02:00
Manish Goregaokar
b908d5accb
Remove Traceable from attr.rs
2014-10-05 21:12:26 +05:30
Keegan McAllister
d50114c41d
Use string-cache's Namespace type
2014-09-29 21:40:54 -07:00
Keegan McAllister
6429750b33
Eliminate servo_util::atom
...
We only needed this for Encodable, and now we use JSTraceable instead.
2014-09-29 18:39:36 -07:00
Simon Sapin
b3245fa407
Upgrade to rustc d2b30f7d3 2014-09-23
2014-09-29 17:41:45 +01:00
Cameron Zwarich
2789750f66
Make the AttrHelpers trait use extended_deref
2014-09-26 18:38:36 -07:00
Manish Goregaokar
cc44a3b064
Use JSTraceable everywhere
2014-09-24 05:44:49 +05:30
Cameron Zwarich
d768ee77ad
Convert various helper traits from &JSRef to JSRef
...
I converted them all with a few exceptions:
- Methods that were used by trait objects, since trait objects don't
work with `self` methods.
- Methods that take an &'b JSRef<'a, T> and return an &'b. In reality,
many (all?) could return an &'a instead, but this isn't allowed by the
Deref trait.
- Methods that internally rely on the same issue with Deref.
- I left out the traits involved in layout entirely, even though not all
of their methods suffer from one of the above problems.
There will probably be solutions to all of these problems in the future.
2014-09-20 11:54:11 -07:00
Cameron Zwarich
2c8d51a37c
More progress in the &JSRef -> JSRef conversion
...
Change all of the <Class>Methods traits to take `self` instead of
`&self`.
2014-09-20 11:54:10 -07:00
Cameron Zwarich
4fa8725111
First steps of &JSRef -> JSRef conversion
...
Replace &JSRef with JSRef in the bulk of the generated code. This will
remove a level of indirection throughout all DOM code.
This patch doesn't change methods implemented on JSRef<T> to take `self`
rather than `&self`, and it leaves a few other uses of &JSRef, but those
changes can be made incrementally.
2014-09-19 13:39:17 -07:00
Josh Matthews
fae7ce3c1d
Retrieve some basic layout properties for nodes to make the box model somewhat useful.
2014-09-18 15:07:11 -04:00
Josh Matthews
fa57fe890b
Enable real DOM inspector support.
2014-09-18 15:06:40 -04:00
Josh Matthews
9607b468bc
Revert "script: Use atom comparison in more places, especially for attributes." for persistent test failures.
...
This reverts commit 874db26104
2014-09-18 09:20:19 -04:00
Patrick Walton
874db26104
script: Use atom comparison in more places, especially for attributes.
...
75% improvement in style recalc for Guardians of the Galaxy.
2014-09-17 13:17:12 -07:00
Manish Goregaokar
bded5c3703
Add unrooted_must_root lint for usages of JS<T> in let/for bindings
2014-09-16 22:54:24 +05:30
Manish Goregaokar
12dc54d238
Add unrooted_must_root lint for enums and structs containing JS<T>, as well as functions with JS<T> in their parameter list
...
For safe wrappers over JS<T> (eg Temporary<T>) use #[allow(unrooted_must_root)].
For all other types containing a #[must_root] value, annotate the type with #[must_root] to ensure that it is never used unrooted
2014-09-16 22:11:27 +05:30
Gilles Leblanc
81a0d065f1
Make use of the list of Atoms in ClassSelector
...
Make use of the list of Atoms in the class attribute selector
(ClassSelector) in selector_matching.
Fixes #3111
2014-09-11 23:19:26 -04:00
Tetsuharu OHZEKI
a4ec892dbc
Move Attr::local_name() to AttrHelpers/AttrHelpersForLayout.
2014-09-11 04:54:38 +09:00
Tetsuharu OHZEKI
b73b06b9a8
Move Attr helper methods to AttrHelpers trait to avoid to touch them from layout task.
2014-09-11 04:54:38 +09:00
Jack Moffitt
c6ab60dbfc
Cargoify servo
2014-09-08 20:21:42 -06:00
