Commit graph

379 commits

Author SHA1 Message Date
PythonNut
fcd33e2b70 Call WPT lint directly in tidy, fixes #9189 2016-01-12 21:13:54 +00:00
PythonNut
3dfa89540a Fix literal braces in string formatting in tidy.py, fixes #9151 2016-01-11 01:32:24 +00:00
bors-servo
aa713c9fbb Auto merge of #9209 - bholley:geckolib, r=SimonSapin
Implement a geckolib target

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9209)
<!-- Reviewable:end -->
2016-01-10 07:14:17 +05:30
Bobby Holley
840df61ba3 Implement a geckolib target. 2016-01-09 12:37:56 -08:00
bors-servo
74226836ba Auto merge of #9118 - dsprenkels:test-tidy-faster, r=Wafflespeanut
Add 'test-tidy-faster' command to ./mach

For issue #9088, this adds a `--changes` option to `./mach test-tidy`. If this option is set, `tidy.py` will only check files that have been modified since `FETCH_HEAD`.

Mention: @Wafflespeanut

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9118)
<!-- Reviewable:end -->
2016-01-08 23:13:00 +05:30
Daan Sprenkels
a9b8d47d5d add a --faster option to ./mach test-tidy
which will
- only check files changed since the last merge by bors
- and skip the wpt-lint
2016-01-07 16:28:13 +01:00
bors-servo
ea4206e362 Auto merge of #9150 - mbrubeck:run-android, r=larsbergstrom
Make "mach run" use --android by default when enabled in .servobuild

When `.servobuild` has `android = true`, the `mach run` command should default to running on Android.

r? @larsbergstrom

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9150)
<!-- Reviewable:end -->
2016-01-05 01:22:53 +05:30
Matt Brubeck
b9fc84ddcc Use build.android config in mach run 2016-01-04 10:52:06 -08:00
bors-servo
9fa56ccfdf Auto merge of #9073 - dsprenkels:issue-8733, r=Wafflespeanut
tidy.py: remove duplicate code patterns in `check_rust(file_name, lines)`

This is an attempt at a reasonable fix for #8733.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9073)
<!-- Reviewable:end -->
2015-12-31 20:20:27 +05:30
Daan Sprenkels
c9f188d163 tidy.py: made check_rust(file_name, lines) more readable
also added a rule that requires a space before '-' (except in cases of scientific notation)
fixes #8733
2015-12-31 12:00:26 +01:00
Simon Sapin
b2af8567fa Rename rust-snapshot-hash to rust-nightly-date
… and remove mentions of "snapshots".

We now use rust-lang.org nightly builds rather than our own snapshots.
2015-12-30 13:36:47 +00:00
Simon Sapin
856eea3a0e Remove "Servo does not bootstrap 32bit snapshots of Rust" message
We now use rust-lang.org nightly builds rather than our own snapshots.
2015-12-30 12:06:54 +00:00
bors-servo
4e3a435450 Auto merge of #9062 - antrik:rust-gdb, r=SimonSapin
mach run --debug: Try using rust-gdb/rust-lldb if available

If the selected debugger (requested explicitly or detected by mozdebug)
is gdb or lldb, use rust-gdb or rust-lldb instead, if it's available in
the path and appears to be working.

(This should usually be the case when using the default debugger on
GNU/Linux or MacOS, as rust-gdb or rust-lldb is provided by the Rust
snapshot in use.)

Note: I cobbled this together without *any* previous Python experience -- so if it violates three dozen rules, and only works by luck on my own system during a favourable moon phase, don't hesitate to suggest improvements :-)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9062)
<!-- Reviewable:end -->
2015-12-30 04:34:42 +05:30
Daan Sprenkels
a01400734d tidy.py: split checking functions into {normal,line}-checking categories
This is done, because the majority of the functions splits the lines, and
it would be better to do this just once.
This commit also optimised the licence checking function slightly by only
checking the fist lines of the file (where the amount of lines is the
line span of the longest license)
2015-12-26 13:47:54 +01:00
Olaf Buddenhagen
f3cd5d2961 mach run --debug: Try using rust-gdb/rust-lldb if available
If the selected debugger (requested explicitly or detected by mozdebug)
is gdb or lldb, use rust-gdb or rust-lldb instead, if it's available in
the path and appears to be working.

(This should usually be the case when using the default debugger on
GNU/Linux or MacOS, as rust-gdb or rust-lldb is provided by the Rust
snapshot in use.)
2015-12-24 14:26:31 +01:00
Simon Martin
cec661fa86 Issue #9042: Report incorrect number of spaces around => in the style checker. 2015-12-23 20:54:26 +01:00
Matt Brubeck
d7ba536ad6 Update mach run to use android_params file 2015-12-18 10:09:48 -08:00
Corey Farwell
75d64d3b3f Print tidy errors as they happen instead of all-at-once 2015-12-14 18:07:11 -05:00
bors-servo
a1fb12616a Auto merge of #8891 - mbrubeck:mach-install, r=larsbergstrom
Android build system improvements

This PR adds a `mach install` command (a convenient way to run `adb install`), and does some minor code cleanup.

It also fixes parallelism in the OpenSSL build.  For [complicated reasons][1], a sub-Make will not inherit `-j` options from its parent process unless it is invoked directly from another Makefile.  This means we should run make from openssl.makefile rather than openssl.sh.

r? @larsbergstrom

[1]: http://make.mad-scientist.net/papers/jobserver-implementation/

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8891)
<!-- Reviewable:end -->
2015-12-12 18:31:53 +05:30
Matt Brubeck
53871321a3 Add mach install command (Android-only for now) 2015-12-12 04:58:33 -08:00
Matt Brubeck
2a00eb6c08 Remove unused params from mach package command 2015-12-12 04:58:32 -08:00
Ms2ger
07d837bd03 Update bincode. 2015-12-08 14:49:38 -05:00
bors-servo
cad77d5f1c Auto merge of #8824 - Ms2ger:tidy-lock, r=Wafflespeanut
Rewrite the Cargo.lock tidy check.

Fixes #8691.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8824)
<!-- Reviewable:end -->
2015-12-08 10:21:55 +05:30
bors-servo
7d9a6a8397 Auto merge of #8750 - GuillaumeGomez:master, r=Wafflespeanut
Ensure that tidy follows the same procedure for sorting

Fixes #8734

cc @Wafflespeanut

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8750)
<!-- Reviewable:end -->
2015-12-06 17:23:43 +05:30
Guillaume Gomez
db3457e498 Improve checking algorithms 2015-12-06 03:34:59 +01:00
bors-servo
e774a69440 Auto merge of #8626 - mskrzypkows:build_commands_android, r=larsbergstrom
Draft,  Move OpenSSL Android build to the target directory #8568

I've created a draft, please give me feedback. Is it good direction?

Fixes #8568

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8626)
<!-- Reviewable:end -->
2015-12-05 18:44:32 +05:30
Ms2ger
b72c8e5e18 Rewrite the Cargo.lock tidy check. 2015-12-04 17:55:48 +01:00
bors-servo
3c0cd5eb06 Auto merge of #7734 - nerith:headless, r=metajack
Allow `./mach build` to enable Servo's headless mode

As mentioned in #7512 and #7637, the environment variable SERVO_HEADLESS
enables building the OSMesa version of Servo when it is set to 1.

Instead, this should be a command line option to mach's build command.

Fixes #7637.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7734)
<!-- Reviewable:end -->
2015-12-04 09:49:05 +05:30
bors-servo
8b95d7b8d8 Auto merge of #8757 - servo:skia, r=mbrubeck
Use skia and deps from crates.io.

This makes the initial download for skia go from a 300 MB git repository to a 5 MB tarball. This should help with issues like #6132 and #7687.

Fix https://github.com/servo/skia/issues/70

This builds, but the at the moment causes a number of tidy errors for duplicated crates.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8757)
<!-- Reviewable:end -->
2015-12-03 12:58:29 +05:30
Brandon Fairchild
2342b1bc6f Allow ./mach build-tests to enable Servo's headless mode
This allows mach's build-tests command to use the option --headless
instead of checking for the value of SERVO_HEADLESS.
2015-12-03 00:39:33 -05:00
Brandon Fairchild
ff853e0d4a Allow ./mach build to enable Servo's headless mode
As mentioned in #7512 and #7637, the environment variable SERVO_HEADLESS
enables building the OSMesa version of Servo when it is set to 1.

Instead, this should be a command line option to mach's build command.

Fixes #7637.
2015-12-02 23:40:31 -05:00
Simon Sapin
b8a3a64691 Tidy ports/cef/Cargo.lock
Despite the rest of ports/cef/ being ignored.
2015-12-02 19:11:08 +01:00
Simon Sapin
aa1eba4f5a Use skia and deps from crates.io.
Fix https://github.com/servo/skia/issues/70
2015-12-02 19:07:59 +01:00
Maciej Skrzypkowski
62af4d36dd Move OpenSSL Android build to the target directory #8568 2015-12-02 09:34:58 +01:00
Sam Gibson
732ae5714f Fix the parsing of the chromium HSTS preload list
Urg! The Chromium HSTS preload JSON file contains single line comments. Previously these were filtered out with a very simple regex that just looked for '//' and removed the line. Now the file has added a couple fields that have URLs in them that were erroneously removed and caused the JSON parsing to fail. This commit slightly complicates the regex to fix this specific problem.

If this happens again, it's likely worth it to figure out how to use a real parser to remove the comments.

servo/servo#8760
2015-12-02 15:36:38 +11:00
jmr0
e301ff46b2 adding wpt lint script to tidy checks 2015-11-30 10:08:10 -05:00
bors-servo
dbff1ab336 Auto merge of #8692 - GuillaumeGomez:patch-1, r=Wafflespeanut
Ensure crate are alphabetically sorted

cc @nox

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8692)
<!-- Reviewable:end -->
2015-11-28 19:34:11 +05:30
Guillaume Gomez
6e7de62b38 Add check up on extern crate order and sort extern crates alphabetically 2015-11-28 03:11:08 +01:00
Ms2ger
21f532758b Ensure the bootstrap-rust-docs and doc mach commands agree on the location of the Rust documentation. 2015-11-27 09:47:38 +01:00
Manish Goregaokar
dc0e467945 Upgrade to rustc 1.6.0-nightly (d5fde83ae 2015-11-12)
… and libc 0.2 and many other dependencies
2015-11-27 00:15:29 -05:00
bors-servo
bc618b0d53 Auto merge of #8689 - jdm:deps, r=frewsxcv
Remove remaining version-conflict exceptions in tidy.py.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8689)
<!-- Reviewable:end -->
2015-11-27 09:17:54 +05:30
Josh Matthews
c36cbf58e8 Remove remaining version-conflict exceptions in tidy.py. 2015-11-26 11:26:28 -05:00
jmr0
df49cf2b13 adding tidy rule to warn against use of &String and refactoring instances of &String in codebase 2015-11-25 21:49:12 -05:00
Yanir Seroussi
4b71bc5c42 Reduce duplication in binary path determinition for Android target (fixes issue #8349) 2015-11-19 14:35:10 +11:00
nxnfufunezn
c7fab07d03 Make test-wpt run with RUST_BACKTRACE=1 by default #8194 2015-11-19 01:32:12 +05:30
Simon Sapin
8051f2ff8c Very hackish support for ./mach run --android 2015-11-13 21:35:50 +01:00
Ms2ger
026994e4be Ignore sync directories in test-tidy. 2015-11-10 10:29:26 +01:00
bors-servo
5fda719fa8 Auto merge of #8415 - mrobinson:create-wpt-relative, r=frewsxcv
Form relative reference URLs during create-wpt

Instead of always using the absolute path to the reference file when
creating new reference tests, create-wpt now creates relative URLs if
the files are in the same directory. This is the most common case for
new Servo tests. Also fix some missing quotation marks in the
create-wpt template.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8415)
<!-- Reviewable:end -->
2015-11-09 22:43:25 +05:30
Martin Robinson
bebbc80129 Form relative reference URLs during create-wpt
Instead of always using the absolute path to the reference file when
creating new reference tests, create-wpt now creates relative URLs if
the files are in the same directory. This is the most common case for
new Servo tests. Also fix some missing quotation marks in the
create-wpt template.
2015-11-08 10:32:35 -08:00
Simon Martin
3b087d406a Avoid UnboundLocalError upon "bogus" usage of ./mach create-wpt 2015-11-08 14:48:02 +01:00