Eli Friedman
94dec69247
Fix up some unnecessary uses of unsafe
.
2015-09-02 15:50:17 -07:00
bors-servo
3424e234c8
Auto merge of #7499 - nerith:style, r=metajack
...
Improve style nit check for space after a comma
Fixes #7345 .
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7499 )
<!-- Reviewable:end -->
2015-09-02 12:05:58 -06:00
bors-servo
a547ae6826
Auto merge of #7496 - servo:calc_, r=SimonSapin
...
Implement CSS3 Calc
This is #7185 with one commit added to make it build merged with master, which got support for the `ch` unit in the meantime.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7496 )
<!-- Reviewable:end -->
2015-09-02 02:33:18 -06:00
Simon Sapin
40b4348824
Upgrade to rustc 1.4.0-dev (cb9323ec0 2015-09-01)
2015-09-02 09:22:17 +02:00
bors-servo
e46499a5df
Auto merge of #7498 - pcwalton:inline-absolute-containing-blocks, r=mbrubeck
...
layout: Implement partial support for inline absolute containing blocks.
Improves the position of the down arrows on google.com SERPs.
r? @mbrubeck
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7498 )
<!-- Reviewable:end -->
2015-09-01 16:36:58 -06:00
Brandon Fairchild
d61a6e2161
Fix reported test-tidy errors
...
This fixes lines that were reported to have missing
space after a comma.
2015-09-01 16:30:42 -04:00
Patrick Walton
676f7014e8
layout: Implement partial support for inline absolute containing blocks.
...
Improves the position of the down arrows on google.com SERPs.
2015-09-01 12:18:19 -07:00
bors-servo
dcaf66397a
Auto merge of #7313 - pcwalton:position-relative-percentage-overflow, r=mbrubeck
...
layout: Make overflow calculation take relative percentages into account.
This necessitated changing overflow to be calculated by the parent flow
if relatively positioned children are present. That is because the
overflow regions cannot be calculated without knowing relative offsets,
which themselves cannot be calculated without knowing the parent size
(because of percentages). To accomplish this without sacrificing
parallelism in the non-relative case, this patch splits overflow into
"early" and "late" computation. Late overflow computation cannot be
parallelized across children, while early overflow computation can.
Makes the "Apple Music" text show up over the full-bleed promotional
background on apple.com.
r? @SimonSapin -- would appreciate a look over the iframe test case that was changed.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7313 )
<!-- Reviewable:end -->
2015-09-01 12:33:07 -06:00
Simon Sapin
80d471d5cf
Merge branch 'master' into calc
2015-09-01 18:39:16 +02:00
Patrick Walton
475d358b21
layout: Fix tidy failures.
2015-09-01 08:37:41 -07:00
bors-servo
15de679f11
Auto merge of #7468 - JoshTheGoldfish:Issue7460, r=jdm
...
Making test-tidy check that = have space after them
For issue #7460 . Need to ensure compatibility with #7390 .
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7468 )
<!-- Reviewable:end -->
2015-09-01 08:33:02 -06:00
erneyja
17663315dd
make test-tidy check that = have space after them
2015-09-01 07:18:19 -04:00
bors-servo
dee6283483
Auto merge of #7474 - notriddle:master, r=pcwalton
...
Inline constraint resolver for absolutely positioned tables.
Fixes #7425 .
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7474 )
<!-- Reviewable:end -->
2015-08-31 20:35:06 -06:00
Patrick Walton
b66f17a445
layout: Make overflow calculation take relative percentages into
...
account.
This necessitated changing overflow to be calculated by the parent flow
if relatively positioned children are present. That is because the
overflow regions cannot be calculated without knowing relative offsets,
which themselves cannot be calculated without knowing the parent size
(because of percentages). To accomplish this without sacrificing
parallelism in the non-relative case, this patch splits overflow into
"early" and "late" computation. Late overflow computation cannot be
parallelized across children, while early overflow computation can.
Makes the "Apple Music" text show up over the full-bleed promotional
background on apple.com.
2015-08-31 16:50:56 -07:00
Michael Howell
36759338c7
Inline constraint resolver for absolutely positioned tables.
...
Fixes #7425 .
2015-08-31 16:45:17 -07:00
Prabhjyot Singh Sodhi
976c7e0411
implemented a pass-through mark_as_root for FlexFlow
2015-08-31 12:56:29 +05:30
David Zbarsky
cdae523cd4
Address review comments
2015-08-26 14:43:10 -07:00
David Zbarsky
67db4fbc2e
Remove stray changes
2015-08-26 14:15:01 -07:00
David Zbarsky
cb4d878169
Implement Calc for LengthOrPercentageOrAuto
2015-08-26 14:14:45 -07:00
David Zbarsky
9556141e57
Implement Calc for LengthOrPercentage
2015-08-26 14:14:43 -07:00
Patrick Walton
5c51a6214e
layout: Fix calculation of overflow for stacking contexts that contain
...
`position: relative` fragments.
Fixes placement of the header on espn.go.com.
2015-08-25 15:08:28 -07:00
Patrick Walton
35c67b22e5
layout: Don't crash if quotes: none
is specified and generated content
...
uses quotes.
Avoids a crash on The Verge.
2015-08-24 17:00:23 -07:00
bors-servo
524b02dbf7
Auto merge of #7331 - paulrouget:issue-7316, r=SimonSapin
...
prevent division by 0
Fix #7316
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7331 )
<!-- Reviewable:end -->
2015-08-24 05:08:41 -06:00
bors-servo
fa06a96f8a
Auto merge of #7334 - servo:active, r=SimonSapin
...
Parse :active pseudo-class selector.
This is #7258 with a spec link added in doc-comment.
The pseudo-class is never matched, but this can still help with stylesheets like `a:hover, a:active { color: something }` where failing to parse one pseudo-class makes the entire selector list invalid.
I filed #7333 about actually making it match.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7334 )
<!-- Reviewable:end -->
2015-08-24 04:23:13 -06:00
Paul Rouget
4987e320d4
prevent division by 0
...
Fix 7316
2015-08-24 08:53:37 +02:00
bors-servo
7945c174a6
Auto merge of #7291 - pcwalton:has-layer-flag, r=mbrubeck
...
layout: Centralize the logic that determines whether fragments get layers in the fragment.
…so that it can be activated when we're forcing
the creation of extra layers due to positioned descendants that
themselves have layers.
The newly failing tests were tests that accidentally passed due to
incorrect stacking order.
Closes #7281 .
r? @mbrubeck
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7291 )
<!-- Reviewable:end -->
2015-08-22 15:56:05 -06:00
Patrick Walton
ec1c90df41
layout: Centralize the logic that determines whether fragments get
...
layers in the fragment, so that it can be activated when we're forcing
the creation of extra layers due to positioned descendants that
themselves have layers.
The newly failing tests were tests that accidentally passed due to
incorrect stacking order.
Closes #7281 .
2015-08-22 12:41:33 -07:00
Patrick Walton
fed904fff5
layout: Make position: relative
with non-auto z-index
create a
...
stacking context.
Improves imgur.com and Fast Company articles.
2015-08-22 12:22:33 -07:00
Patrick Walton
930dfbb7ad
layout: Fix merge fallout.
2015-08-21 16:08:13 -07:00
Simon Sapin
2fa2a3b5a9
Sort imports.
2015-08-21 15:59:20 -07:00
Kyle Zentner
0e18f645f4
Implement FlexFlow::assign_block_size().
2015-08-21 15:59:19 -07:00
Kyle Zentner
e95c15816d
Implement FlexFlow::assign_inline_sizes().
2015-08-21 15:59:18 -07:00
Kyle Zentner
0488a36862
Create FlexFlow's for 'display: flex' nodes.
...
This commit doesn't implement any flexbox behavior at all.
It just constructs FlexFlow's, which act just like the BlockFlow from
which they "inherit."
2015-08-21 15:59:18 -07:00
Simon Sapin
21d69314d4
Don’t mark flow_ref::deref_mut as unsafe.
...
See discussion in https://github.com/servo/servo/pull/7237
2015-08-21 21:16:25 +02:00
Simon Sapin
649250130b
Replace FlowRef with Arc<Flow>, now that Arc supports DST.
...
… and WeakFlowRef with Weak<Flow>.
2015-08-20 16:49:48 +02:00
Simon Sapin
2d22aa8e7e
Replace the unsound impl DerefMut for FlowRef
with an unsafe function.
...
See #6503 .
2015-08-20 16:24:26 +02:00
bors-servo
a5fbb2f2a6
Auto merge of #7265 - tafia:tidy-use, r=Ms2ger
...
Add alphabetical order check for use statements
close #7112
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7265 )
<!-- Reviewable:end -->
2015-08-20 07:43:56 -06:00
Johann Tuffe
ec07178b6f
sort all uses
2015-08-20 20:47:12 +08:00
bors-servo
39b7508aa2
Auto merge of #7251 - nox:text-transform-length-change, r=SimonSapin
...
Correctly handle length-changing mappings in text-transform
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7251 )
<!-- Reviewable:end -->
2015-08-20 06:40:33 -06:00
Patrick Walton
a516042edb
layout: Don't panic if requestAnimationFrame()
is called before first layout.
...
Closes #7115 .
2015-08-20 13:17:07 +02:00
Patrick Walton
4df4d1a1a9
layout: Put iframes that form stacking contexts in the right place.
...
Improves eBay.
Closes #7282 .
2015-08-19 12:08:36 -07:00
bors-servo
5c284a546a
Auto merge of #7280 - pcwalton:style-specified-img-intrinsic-width, r=mbrubeck
...
layout: Take the style-specified width into account when computing the intrinsic inline sizes of images.
Improves Facebook Timeline.
r? @mbrubeck
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7280 )
<!-- Reviewable:end -->
2015-08-19 11:39:33 -06:00
bors-servo
0234bbe444
Auto merge of #7279 - pcwalton:tile-image-divide-by-zero, r=mbrubeck
...
layout: Avoid a division by zero in `tile_image()`.
Fixes a crash on Facebook Timeline.
r? @mbrubeck
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7279 )
<!-- Reviewable:end -->
2015-08-19 04:41:54 -06:00
Anthony Ramine
bb3d3db333
Correctly handle length-changing mappings in text-transform
2015-08-19 12:05:31 +02:00
bors-servo
195d267e23
Auto merge of #7276 - pcwalton:inline-absolute-hypothetical-clip, r=mbrubeck
...
layout: Make inline absolute hypothetical boxes not clip their contents.
Improves the logo on ebay.com.
r? @mbrubeck
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7276 )
<!-- Reviewable:end -->
2015-08-19 03:54:10 -06:00
bors-servo
30a1339ed1
Auto merge of #7274 - pcwalton:table-minimum-width, r=mbrubeck
...
layout: Make table cells' minimum inline sizes override explicitly specified widths if the latter are too small.
Improves ebay.com.
r? @mbrubeck
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7274 )
<!-- Reviewable:end -->
2015-08-19 03:20:37 -06:00
Patrick Walton
66473625db
layout: Take the style-specified width into account when computing the
...
intrinsic inline sizes of images.
Improves Facebook Timeline.
2015-08-18 18:46:07 -07:00
Patrick Walton
02b15e016d
layout: Avoid a division by zero in tile_image()
.
...
Fixes a crash on Facebook Timeline.
2015-08-18 18:44:50 -07:00
Patrick Walton
c328c38804
layout: Make inline absolute hypothetical boxes not clip their contents.
...
Improves the logo on ebay.com.
2015-08-18 16:58:18 -07:00
Patrick Walton
9d41841964
layout: Make table cells' minimum inline sizes override explicitly
...
specified widths if the latter are too small.
Improves ebay.com.
2015-08-18 14:38:49 -07:00