Commit graph

26698 commits

Author SHA1 Message Date
bors-servo
028908ee26 Auto merge of #17122 - servo:derive-all-the-things, r=emilio
Continue to slim down the code for CSS properties

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17122)
<!-- Reviewable:end -->
2017-06-02 01:53:55 -07:00
Anthony Ramine
e58f541951 Rename BorderImageWidthSide to BorderImageSideWidth 2017-06-02 10:53:28 +02:00
Anthony Ramine
7da94d0880 Use BorderSideWidth for outline-width 2017-06-02 10:53:27 +02:00
Anthony Ramine
2c7fbb4b4c Use generics for text spacing properties 2017-06-02 10:21:22 +02:00
Anthony Ramine
5c6987a50d Use generics for the line-height property 2017-06-02 10:21:21 +02:00
bors-servo
cf71a0cd96 Auto merge of #17137 - hiikezoe:get-parent-style-in-servo-side, r=birtles
Get parent style in servo side

<!-- Please describe your changes on the following line: -->
This is a PR for https://bugzilla.mozilla.org/show_bug.cgi?id=1367293

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because it's for stylo

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17137)
<!-- Reviewable:end -->
2017-06-01 20:56:48 -07:00
Hiroyuki Ikezoe
ac86d2d648 Update bindings. 2017-06-02 12:18:08 +09:00
Hiroyuki Ikezoe
4af88b137b Get parent style from the target element.
We can get the parent style from element tree in servo side.
The parent style has been already restyled.
E.g.;
 When we get target element style with nsComputedDOMStyle::GetStyleContext,
 the function flushes styles so that the parent style has also
 restyled.

 When we call Servo_GetComputedKeyframeValues, it's called from a
 SequentialTask, that means all elements have been already restyled.

Unfortunately we can't assert that the parent style is not stale
to check the parent element has no dirty descendant bit since
Servo_GetComputedKeyframeValues is called in a SequantialTask
that is processed before post traversal, that means elements
still have the dirty bit to update nsStyleContext in the
post traversal.
2017-06-02 12:18:04 +09:00
Hiroyuki Ikezoe
e0ec2dcd54 Factor out creating context. 2017-06-02 09:33:53 +09:00
bors-servo
373d3b91dd Auto merge of #17130 - Manishearth:stylo-attr, r=heycam,emilio
stylo: Handle attr() in `content`

r=heycam https://bugzilla.mozilla.org/show_bug.cgi?id=1346693

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17130)
<!-- Reviewable:end -->
2017-06-01 15:34:55 -07:00
Manish Goregaokar
5de2f29080 stylo: Create separate Attr type 2017-06-01 14:20:56 -07:00
Manish Goregaokar
25d193ba34 stylo: Use namespace ids for content: attr(..)
MozReview-Commit-ID: FZ9YEpHQCBh
2017-06-01 14:11:31 -07:00
Manish Goregaokar
7deeccf4cb stylo: Move reference of namespace map to parser context
MozReview-Commit-ID: 74Kaj2Rqkdb
2017-06-01 14:10:40 -07:00
bors-servo
cfdb6af53b Auto merge of #17121 - Manishearth:stylo-system-font-ser, r=upsuper
stylo: Fix serialization of system fonts

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17121)
<!-- Reviewable:end -->
2017-06-01 14:04:41 -07:00
Jeff Hajewski
878b9a4db3 Use enum class for white-space 2017-06-01 13:55:54 -07:00
Manish Goregaokar
7123e5333f stylo: Fix serialization of system fonts 2017-06-01 13:55:52 -07:00
bors-servo
17e69af0c9 Auto merge of #17128 - emilio:first-line-letter, r=bholley
stylo: Basic support for first-line/letter dynamic changes.
2017-06-01 12:13:43 -07:00
Emilio Cobos Álvarez
93c39b0730
Bug 1369187: style: Assert that if we find an eager, element-backed pseudo, it's ::before or ::after. r=bholley
This holds because ::first-line and ::first-letter are not element-backed.

MozReview-Commit-ID: 67FU15pCLqW
2017-06-01 21:10:45 +02:00
Emilio Cobos Álvarez
a529c13904
Bug 1369187: style: Use ArrayVec for the pseudo-elements we need to restyle. r=bholley
Just a drive-by, easy optimization.

MozReview-Commit-ID: AVaeWvBHLzc
2017-06-01 21:10:37 +02:00
Emilio Cobos Álvarez
509a450cff
Bug 1369187: style: Add first-line and first-letter to the set of eager pseudo styles. r=bholley
MozReview-Commit-ID: DmpX0nA2DOw
2017-06-01 21:09:34 +02:00
Emilio Cobos Álvarez
fe74e70a2d
Bug 1369187: style: Add an API to fast-reject eager pseudos. r=bholley
Also, do nothing for now (we'll hook the Gecko pieces here when the time comes).

Let me know if you want to hold-off landing this.

MozReview-Commit-ID: 6PIhfp6sxk4
2017-06-01 21:09:26 +02:00
bors-servo
12de616532 Auto merge of #17067 - est31:master, r=jdm
Bring back clipboard support

Brings back clipboard support.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #17065
- [x] These changes fix #12805

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____
- [x] Testing these chances would require a full integration-style test suite, which servo currently lacks.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17067)
<!-- Reviewable:end -->
2017-06-01 10:07:16 -07:00
est31
28b854d724 Bring back clipboard support 2017-06-01 16:37:29 +02:00
bors-servo
6a638876fd Auto merge of #17120 - gterzian:fix_double_borrowing_of_image_request, r=jdm
fix double borrowing of image request

<!-- Please describe your changes on the following line: -->

@jdm I couldn't reproduce the crashes, but looking at the code, I can tell that if we hit the cache inside `fetch_image`, we go straight to `process_image_response`, so we're still in the same scope as that where the borrowing occurs in `prepare_image_request`. When there is no cache hit, `process_image_response` is executed as part of a task...

This should fix the issue, while retaining the original logic.

All tests in `the-img-element` are passing...

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #17109 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17120)
<!-- Reviewable:end -->
2017-05-31 21:47:33 -07:00
bors-servo
af6a140707 Auto merge of #17118 - upsuper:unicode-bidi-serde, r=heycam
Remove unicode-bidi/with_serde feature from style deps

It seems removing this feature from here would unbust stylo build on Gecko side, and style crate doesn't need it anyway, and for Servo, other crates would bring this feature back, so it shouldn't break Servo either.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17118)
<!-- Reviewable:end -->
2017-05-31 19:28:12 -07:00
Gregory Terzian
5bf1105f02 fix double borrowing of image request 2017-06-01 10:25:34 +08:00
bors-servo
04d84a2624 Auto merge of #17111 - servo:jdm-patch-1, r=mbrubeck
Remove cssparser dependency from msg.

This removes a bunch of unnecessary rebuilds when modifying rust-cssparser.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17111)
<!-- Reviewable:end -->
2017-05-31 18:06:28 -07:00
Xidorn Quan
764ed57c33 Remove unicode-bidi/with_serde feature from style deps 2017-06-01 10:53:35 +10:00
bors-servo
1aa3eec66b Auto merge of #17115 - aneeshusa:temporarily-disable-macbrew-updater, r=emilio
Disable macbrew updater

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17115)
<!-- Reviewable:end -->
2017-05-31 17:00:15 -07:00
Aneesh Agrawal
32c973d118 Temporarily disable macbrew updater 2017-05-31 17:54:35 -04:00
bors-servo
a694f70acf Auto merge of #17008 - MortimerGoro:android_default_armv7, r=larsberg
Make armv7-linux-androideabi default target on Android

<!-- Please describe your changes on the following line: -->

See https://github.com/servo/servo/issues/11921

After fixing problematic dependencies this is the last step to support armv7-linux-androideabi target on Android:

- Updates skia dependency to fix a linker error. See https://github.com/servo/skia/pull/136
- Fixes specifying android targets on `./mach package` and `./mach install` steps:
  -`./mach package --release --target=arm-linux-androideabi`
  -`./mach package --release --target=armv7-linux-androideabi`
  -`./mach package --release --target=aarch64-linux-android`
- Make `armv7-linux-androideabi`default when `--android` param is used in build, package or install commands

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #11921 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17008)
<!-- Reviewable:end -->
2017-05-31 16:29:19 -05:00
Imanol Fernandez
04fb628d20 Make armv7-linux-androideabi default target on Android 2017-05-31 22:31:26 +02:00
bors-servo
3337fccd99 Auto merge of #17105 - heycam:rayonup, r=nox
Update rayon to 0.7.1.

To take advantage of nikomatsakis/rayon#348.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17105)
<!-- Reviewable:end -->
2017-05-31 15:20:22 -05:00
bors-servo
71eb672923 Auto merge of #17093 - ferjm:bug1365674.simulate.compute.value.failure, r=hiikezoe
Stylo - Bug 1365674: Simulate compute value failure for tests

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

https://bugzilla.mozilla.org/show_bug.cgi?id=1365674

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17093)
<!-- Reviewable:end -->
2017-05-31 12:03:50 -05:00
bors-servo
cd22fc6b90 Auto merge of #17095 - servo:derive-all-the-things, r=emilio
Refactor a few CSS properties

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17095)
<!-- Reviewable:end -->
2017-05-31 11:08:56 -05:00
Josh Matthews
d4d486197d Remove cssparser dependency from msg. 2017-05-31 11:35:18 -04:00
bors-servo
1b9cc2de34 Auto merge of #17110 - bholley:better_style_sharing, r=emilio
Improve Style Sharing

Reviewed in:
https://bugzilla.mozilla.org/show_bug.cgi?id=1368665
https://bugzilla.mozilla.org/show_bug.cgi?id=1368399

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17110)
<!-- Reviewable:end -->
2017-05-31 10:07:53 -05:00
Bobby Holley
47404cfc4e Compare style attributes rather than rejecting them from the cache.
MozReview-Commit-ID: Jmu7Pie2mBP
2017-05-31 06:48:40 -07:00
Bobby Holley
f40c45fe1a Reduce the number of places where we need to enumerate ValidationData members.
MozReview-Commit-ID: 9m2ebknBFSE
2017-05-31 06:48:33 -07:00
Bobby Holley
6d8455a916 Sort the cached class list in ValidationInfo.
MozReview-Commit-ID: 3vsfP5ECzds
2017-05-31 06:48:27 -07:00
bors-servo
bdf4135b6a Auto merge of #17101 - cbrewster:custom_element_tests, r=jdm
Run custom element tests

I would like to have these enabled so its easier to see newly passing tests in subsequent PRs.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17101)
<!-- Reviewable:end -->
2017-05-31 08:37:05 -05:00
bors-servo
c018340a13 Auto merge of #17107 - servo:android, r=larsbergstrom
Revert "Auto merge of #16566"
2017-05-31 07:14:39 -05:00
Anthony Ramine
8790166c5f Revert "Auto merge of #16566 - aneeshusa:remove-android-sdk-override, r=larsbergstrom"
This reverts commit 779edd7c4a, reversing
changes made to 31c7198f71.
2017-05-31 14:13:34 +02:00
Nikhil Shagrithaya
541baafe1c Redirect document loads manually 2017-05-31 17:28:53 +05:30
Fernando Jiménez Moreno
ebfb18c1b5 Update gecko bindings 2017-05-31 11:07:06 +02:00
Fernando Jiménez Moreno
7f5d62c24d Stylo - Bug 1365674: Simulate compute value failure for tests 2017-05-31 10:30:58 +02:00
Anthony Ramine
851b5e2600 Silence a warning in style unit tests 2017-05-31 09:58:09 +02:00
Anthony Ramine
5d70580813 Make use of generics for transform-origin
This allows us to preserve keywords during serialisation.
2017-05-31 09:58:07 +02:00
Cameron McCormack
f62a236d8c Update rayon to 0.7.1.
To take advantage of nikomatsakis/rayon#348.
2017-05-31 17:55:26 +10:00
bors-servo
779edd7c4a Auto merge of #16566 - aneeshusa:remove-android-sdk-override, r=larsbergstrom
Remove redundant ANDROID_SDK variables

The r25.2.3 Android SDK has been made the current version in saltfs,
so we no longer need to override it via environment variable.

Follow up to servo/servo#15773.
Requires servo/saltfs#644.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16566)
<!-- Reviewable:end -->
2017-05-30 21:09:40 -05:00