Commit graph

5579 commits

Author SHA1 Message Date
bors-servo
ff4171170d Auto merge of #8606 - rilut:refactor-layout-task, r=Ms2ger
refactor(layout_task.rs): move some functions to query.rs

Should fixes #8470

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8606)
<!-- Reviewable:end -->
2015-11-19 23:48:17 +05:30
bors-servo
7f95693288 Auto merge of #8564 - jgraham:webdriver_attr, r=Ms2ger
Implement Get Element Attribute WebDriver command

This intentionally doesn't implement the special handling for boolean
attributes yet, since that requires some kind of exhaustive list of all
such attributes

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8564)
<!-- Reviewable:end -->
2015-11-19 23:16:25 +05:30
bors-servo
ced8763b25 Auto merge of #8604 - Ms2ger:unused-import, r=jdm
Remove unused import.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8604)
<!-- Reviewable:end -->
2015-11-19 22:12:19 +05:30
Rizky Luthfianto
2c7117d73b refactor(layout_task.rs): move some functions to query.rs 2015-11-19 23:30:39 +07:00
Ms2ger
b7117893af Rename a confusing argument. 2015-11-19 16:18:28 +01:00
Ms2ger
bf7053bc17 Remove unused import. 2015-11-19 16:14:47 +01:00
Bobby Holley
2f6e94943a Rename Layout*Trait to Layout*.
The next step will be to remote the Servo-specificity of the layout code we want
to share by making it operate generically on Layout*.
2015-11-18 17:24:36 -08:00
Bobby Holley
9dd45b9f2a Prefix concrete types with 'Servo'. 2015-11-18 17:23:46 -08:00
Bobby Holley
54f2700ba6 Hoist exported wrapper functionality into a family of traits.
All the existing code still uses the concrete implementations, so this
shouldn't impact the generated code at all.
2015-11-18 17:23:29 -08:00
bors-servo
acbe413052 Auto merge of #8530 - KiChjang:split-constellation-msg, r=jdm
Split ConstellationMsg into ScriptMsg and CompositorMsg

Fixes #8356.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8530)
<!-- Reviewable:end -->
2015-11-19 04:39:20 +05:30
benshu
54e41fb22d Correct undisciplined rebase. (Closes #8583.) 2015-11-18 21:10:20 +01:00
Ms2ger
8b786cca9a Make layout's modules private. 2015-11-18 15:00:59 +01:00
Ms2ger
5ec1cdea9b Remove dead code from layout. 2015-11-18 15:00:58 +01:00
Ms2ger
de23fef9ca Update bitflags. 2015-11-18 15:00:56 +01:00
James Graham
6446cc3db8 Implement Get Element Attribute WebDriver command 2015-11-18 11:52:05 +00:00
bors-servo
7a87312121 Auto merge of #8569 - Ms2ger:fmt-script, r=metajack
Rustfmt some of script.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8569)
<!-- Reviewable:end -->
2015-11-18 15:44:30 +05:30
Ms2ger
0c61be7a57 Rustfmt some of script. 2015-11-18 11:14:05 +01:00
bors-servo
247f586284 Auto merge of #8572 - nerith:idiomatic, r=frewsxcv
Make Node::is_parent_of and Stylesheet::is_effective_for_device more idiomatic

Fixes #8555.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8572)
<!-- Reviewable:end -->
2015-11-18 04:53:17 +05:30
Brandon Fairchild
7f75a881a4 Make Stylesheet::is_effective_for_device more idiomatic 2015-11-17 17:02:01 -05:00
Brandon Fairchild
6a28d62b15 Make Node::is_parent_of more idiomatic 2015-11-17 16:58:37 -05:00
Corey Farwell
6e3878d254 Add tracking issue for HTMLFormControlsCollection 2015-11-17 10:06:17 -05:00
bors-servo
cedaac8dbe Auto merge of #8549 - Ms2ger:privatize, r=pcwalton
Privatize from_layout_js functions.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8549)
<!-- Reviewable:end -->
2015-11-17 14:11:22 +05:30
Ms2ger
3fb16cc017 Privatize from_layout_js functions. 2015-11-17 09:40:51 +01:00
bors-servo
8950345e0e Auto merge of #8552 - michaelwu:avoid_overflow, r=glennw
Avoid overflow in freetype/font_context.rs

When new_actual_size < old_actual_size, there is an overflow panic since we're using usize. This breaks Reddit for me.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8552)
<!-- Reviewable:end -->
2015-11-17 13:04:47 +05:30
Keith Yeung
19294db6e5 Split ConstellationMsg into ScriptMsg and CompositorMsg 2015-11-16 23:10:53 -08:00
bors-servo
afe03870ce Auto merge of #8151 - jgraham:webdriver_sendkeys, r=jgraham
Implement support for WebDriver send keys command.

Supports sending keys to an element. The specification here is still
rather unfinished so the error handling and so on in this code will
need iteration as it becomes clearer what the expected behaviour is.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8151)
<!-- Reviewable:end -->
2015-11-17 11:02:50 +05:30
bors-servo
f17f89059a Auto merge of #8503 - craftytrickster:8406/limit-suppported-format, r=mbrubeck
Adding method to detect if image formats should be supported by servo

https://github.com/servo/servo/issues/8406

Please let me know if I need to make any changes.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8503)
<!-- Reviewable:end -->
2015-11-17 07:14:25 +05:30
James Graham
09b9293b09 Implement support for WebDriver send keys command.
Supports sending keys to an element. The specification here is still
rather unfinished so the error handling and so on in this code will
need iteration as it becomes clearer what the expected behaviour is.
2015-11-16 22:48:26 +00:00
bors-servo
20d26853e1 Auto merge of #8548 - Ms2ger:unused-tna, r=pcwalton
Remove the unused arguments to hit_test and mouse_over.

I don't think this code is called when there is no document element, but I
added assertions to make sure we notice in case I was wrong.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8548)
<!-- Reviewable:end -->
2015-11-17 02:05:52 +05:30
bors-servo
db94fda10e Auto merge of #8545 - Ms2ger:AutoJoinScriptTask, r=pcwalton
Remove AutoJoinScriptTask.

I don't believe there is a case where it would make sense to drop the
ScriptReflow struct without joining the script thread. This approach should
be somewhat more robust, and avoids the code smell of a RAII guard in an
otherwise unused variable.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8545)
<!-- Reviewable:end -->
2015-11-17 01:18:45 +05:30
bors-servo
c1e6bc0714 Auto merge of #8538 - notriddle:github_resize, r=mbrubeck
Ignore `<meta name=viewport>` if `@viewport` is ignored

Fixes #8373

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8538)
<!-- Reviewable:end -->
2015-11-17 00:31:49 +05:30
Michael Wu
7cbef87b00 Avoid overflow in freetype/font_context.rs 2015-11-16 13:07:56 -05:00
Toothbrush
3cfd65f5e1 Changed to create immutable Vec 2015-11-16 17:33:39 +00:00
Toothbrush
081b1e93a1 Fixes #8546
Fixes issue #8546
2015-11-16 17:09:34 +00:00
Ms2ger
4e60412c6d Remove the unused arguments to hit_test and mouse_over.
I don't think this code is called when there is no document element, but I
added assertions to make sure we notice in case I was wrong.
2015-11-16 15:53:49 +01:00
Ms2ger
a2c08413dd Remove AutoJoinScriptTask.
I don't believe there is a case where it would make sense to drop the
ScriptReflow struct without joining the script thread. This approach should
be somewhat more robust, and avoids the code smell of a RAII guard in an
otherwise unused variable.
2015-11-16 12:41:25 +01:00
Michael Howell
987c9e63aa Ignore <meta name=viewport> if @viewport is.
Fixes #8373
2015-11-15 20:35:13 -07:00
bors-servo
b6f519cd0a Auto merge of #8533 - Ms2ger:legacy, r=nox
Remove the `legacy` module.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8533)
<!-- Reviewable:end -->
2015-11-15 19:13:13 +05:30
Ms2ger
f2be9eb735 Move the from_declaration to its only caller and remove the empty legacy module. 2015-11-15 13:57:22 +01:00
bors-servo
c722e0e6f4 Auto merge of #8527 - romankl:atom-slices, r=Ms2ger
Replace Atom::from_slice("sizes") with atom!("sizes")

This PR replaces all occurrences of Atom::from_slice("sizes") with atom!("sizes"). It also updates string_cache to v0.1.17 from 0.1.16.

Right now I've split the crate update and the replace in different commits - should I squash them?

Fixes #8488.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8527)
<!-- Reviewable:end -->
2015-11-15 18:26:33 +05:30
Ms2ger
1154cf51c8 Inline PresentationalHintSynthesis::synthesize_presentational_hints_for_legacy_attributes. 2015-11-15 13:46:55 +01:00
Ms2ger
9c1d678b1b Remove get_unsigned_integer_attribute. 2015-11-15 11:24:03 +01:00
Ms2ger
5417df6397 Introduce a get_colspan method on LayoutJS<Element>. 2015-11-15 11:16:17 +01:00
bors-servo
3ef0a9a79d Auto merge of #8526 - frewsxcv:parse-length, r=eefriedman
Fix parse_length 0 values, implement <hr> 'width'

Follow-up to https://github.com/servo/servo/issues/8424

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8526)
<!-- Reviewable:end -->
2015-11-15 03:30:46 +05:30
Corey Farwell
30ea772939 Make util::str::parse_length work with floats 2015-11-14 16:47:10 -05:00
Corey Farwell
02a8e8dd16 Implement <hr> element 'width' attribute 2015-11-14 16:46:59 -05:00
bors-servo
33c97b2ebb Auto merge of #8529 - Ms2ger:unused-lifetime, r=eefriedman
Remove unused lifetime parameters from LayoutTask methods.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8529)
<!-- Reviewable:end -->
2015-11-15 01:32:35 +05:30
Roman Klauke
0813ee7257 replace Atom::from_slice("sizes") with atom!(sizes")
Closes: #8488
2015-11-14 20:58:57 +01:00
Roman Klauke
b6f336595f update string_cache from 0.1.16 to 0.1.17 2015-11-14 19:41:02 +01:00
bors-servo
8f2a3a64f1 Auto merge of #8524 - notriddle:paint_task_deep, r=jdm
Draw layers that are under sub-displaylists.

Fixes #8325

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8524)
<!-- Reviewable:end -->
2015-11-14 22:26:22 +05:30