mirror of
https://github.com/servo/servo.git
synced 2025-08-09 15:35:34 +01:00
fd20a5df42
### Changes made
This implements named grid lines (line names in `grid-template-*`),
named grid areas (`grid-template-areas`), and the ability to target
those using `grid-{row,column}-{start,end}`. It also includes a bunch of
miscelaneous fixes for `repeat(auto-fill | auto-fit, ...)` syntax as
that interacts with the specification of line names.
The actual layout implementation is in Taffy. The bulk of this PR is
updating Servo to translate (CSS Grid-related) Stylo types into Taffy
types using a new iterator-based API which uses iterators and lazy
translation for efficiency (which is more important now that we're
dealing with string data, even though they're `Atom`s).
### Testing
This functionality has lots of WPT tests. It fixes some seemingly random
CSS Grid tests that use named lines/areas even though that's not what
they're testing.
### Screenshots
wikipedia.org
<img width="1624" height="1056" alt="Screenshot 2025-07-27 at 20 03 16"
src="https://github.com/user-attachments/assets/2c50b96f-ae36-4405-ac48-b771bfdcb515"
/>
bbc.co.uk:
<img width="1624" height="1056" alt="Screenshot 2025-07-27 at 20 32 57"
src="https://github.com/user-attachments/assets/ba84e211-65d2-4411-95fb-7b9b91bea31c"
/>
theguardian.com:
<img width="1624" height="1056" alt="Screenshot 2025-07-27 at 20 33 29"
src="https://github.com/user-attachments/assets/e85daaa6-5fb0-45d4-b9ec-b22b38b087ec"
/>
---------
Signed-off-by: Nico Burns <nico@nicoburns.com>
48 lines
580 B
INI
Vendored
48 lines
580 B
INI
Vendored
[grid-content-alignment-and-self-alignment-002.html]
|
|
[.grid 17]
|
|
expected: FAIL
|
|
|
|
[.grid 18]
|
|
expected: FAIL
|
|
|
|
[.grid 19]
|
|
expected: FAIL
|
|
|
|
[.grid 20]
|
|
expected: FAIL
|
|
|
|
[.grid 21]
|
|
expected: FAIL
|
|
|
|
[.grid 22]
|
|
expected: FAIL
|
|
|
|
[.grid 23]
|
|
expected: FAIL
|
|
|
|
[.grid 24]
|
|
expected: FAIL
|
|
|
|
[.grid 25]
|
|
expected: FAIL
|
|
|
|
[.grid 26]
|
|
expected: FAIL
|
|
|
|
[.grid 27]
|
|
expected: FAIL
|
|
|
|
[.grid 28]
|
|
expected: FAIL
|
|
|
|
[.grid 29]
|
|
expected: FAIL
|
|
|
|
[.grid 30]
|
|
expected: FAIL
|
|
|
|
[.grid 31]
|
|
expected: FAIL
|
|
|
|
[.grid 32]
|
|
expected: FAIL
|