mirror of
https://github.com/servo/servo.git
synced 2025-08-10 07:55:33 +01:00
fd20a5df42
### Changes made
This implements named grid lines (line names in `grid-template-*`),
named grid areas (`grid-template-areas`), and the ability to target
those using `grid-{row,column}-{start,end}`. It also includes a bunch of
miscelaneous fixes for `repeat(auto-fill | auto-fit, ...)` syntax as
that interacts with the specification of line names.
The actual layout implementation is in Taffy. The bulk of this PR is
updating Servo to translate (CSS Grid-related) Stylo types into Taffy
types using a new iterator-based API which uses iterators and lazy
translation for efficiency (which is more important now that we're
dealing with string data, even though they're `Atom`s).
### Testing
This functionality has lots of WPT tests. It fixes some seemingly random
CSS Grid tests that use named lines/areas even though that's not what
they're testing.
### Screenshots
wikipedia.org
<img width="1624" height="1056" alt="Screenshot 2025-07-27 at 20 03 16"
src="https://github.com/user-attachments/assets/2c50b96f-ae36-4405-ac48-b771bfdcb515"
/>
bbc.co.uk:
<img width="1624" height="1056" alt="Screenshot 2025-07-27 at 20 32 57"
src="https://github.com/user-attachments/assets/ba84e211-65d2-4411-95fb-7b9b91bea31c"
/>
theguardian.com:
<img width="1624" height="1056" alt="Screenshot 2025-07-27 at 20 33 29"
src="https://github.com/user-attachments/assets/e85daaa6-5fb0-45d4-b9ec-b22b38b087ec"
/>
---------
Signed-off-by: Nico Burns <nico@nicoburns.com>
36 lines
1.5 KiB
INI
Vendored
36 lines
1.5 KiB
INI
Vendored
[grid-template-columns-computed-withcontent.html]
|
|
[Property grid-template-columns value 'calc(30% + 40px)']
|
|
expected: FAIL
|
|
|
|
[Property grid-template-columns value 'minmax(min-content, calc(-0.5em + 10px))']
|
|
expected: FAIL
|
|
|
|
[Property grid-template-columns value 'minmax(auto, 0)']
|
|
expected: FAIL
|
|
|
|
[Property grid-template-columns value 'repeat(1, [one two\] 20%)']
|
|
expected: FAIL
|
|
|
|
[Property grid-template-columns value 'repeat(2, fit-content(20%) [three four\] 30px 40px [five six\])']
|
|
expected: FAIL
|
|
|
|
[Property grid-template-columns value 'repeat(auto-fit, [one\] 20%)']
|
|
expected: FAIL
|
|
|
|
[Property grid-template-columns value 'repeat(auto-fill, minmax(100px, 5fr) [two\])']
|
|
expected: FAIL
|
|
|
|
[Property grid-template-columns value 'repeat(auto-fit, [three\] minmax(max-content, 6em) [four\])']
|
|
expected: FAIL
|
|
|
|
[Property grid-template-columns value '[a\] 21px [b\] repeat(auto-fill, [c\] 22px [d\] 23px [e\]) [f\] 24px [g\]']
|
|
expected: FAIL
|
|
|
|
[Property grid-template-columns value '[a\] 21px [b c\] repeat(auto-fill, [d e\] 22px [f g h\] 23px [i j k l\]) [m n\] 24px [o\]']
|
|
expected: FAIL
|
|
|
|
[Property grid-template-columns value '[a\] repeat(2, [b\] 20px [c d\] 21px [e f g\]) [h i\] repeat(auto-fit, [j\] 22px [k l m\] 23px [n o p q\]) [r s\]']
|
|
expected: FAIL
|
|
|
|
[Property grid-template-columns value '[one\] repeat(2, minmax(50px, auto)) [two\] 30px [three\] repeat(auto-fill, 10px) 40px [four five\] repeat(2, minmax(200px, auto)) [six\]']
|
|
expected: FAIL
|