mirror of
https://github.com/servo/servo.git
synced 2025-08-21 05:15:33 +01:00
f5b631e270
devtools clients query source actors to determine where the user can set breakpoints in a source. there are two relevant requests here: `getBreakableLines` controls which line numbers can be clicked in the margin, and once a line number is clicked, `getBreakpointPositionsCompressed` controls where to show breakpoint buttons within that line. this patch handles those requests by querying the [SpiderMonkey Debugger API](https://firefox-source-docs.mozilla.org/js/Debugger/) for that information: - devtools sends its script thread a GetPossibleBreakpoints message for the source’s [`spidermonkey_id`](https://firefox-source-docs.mozilla.org/js/Debugger/Debugger.Source.html#id) - the script thread fires a `getPossibleBreakpoints` event into its debugger global - the debugger script looks up the [root](https://firefox-source-docs.mozilla.org/js/Debugger/Debugger.html#onnewscript-script-global) [Debugger.Script](https://firefox-source-docs.mozilla.org/js/Debugger/Debugger.Script.html#getpossiblebreakpoints-query) for that source, calls [getPossibleBreakpoints()](https://firefox-source-docs.mozilla.org/js/Debugger/Debugger.Script.html#getpossiblebreakpoints-query), and returns the result via DebuggerGlobalScope#getPossibleBreakpointsResult() - that method takes the pending result sender, and sends the result back to devtools - devtools massages the result into the format required by the request, and replies to the client as a result, users of the Firefox devtools client can now set breakpoints, though they don’t have any effect. Testing: this patch adds new devtools tests Fixes: part of #36027 <img width="1433" height="1328" alt="image" src="https://github.com/user-attachments/assets/f0cd31e0-742f-44d3-8c5d-ceedd9a2706d" /> --------- Signed-off-by: Delan Azabani <dazabani@igalia.com> Co-authored-by: atbrakhi <atbrakhi@igalia.com> |
||
|---|---|---|
| .. | ||
| resource_protocol | ||
| user-agent-js | ||
| about-memory.html | ||
| android_params | ||
| badcert.html | ||
| cert-google-only | ||
| cert-wpt-only | ||
| crash.html | ||
| Credits.rtf.mako | ||
| debugger.js | ||
| directory-listing.html | ||
| gatt_blocklist.txt | ||
| hsts_preload.fstmap | ||
| iso-8859-8.css | ||
| neterror.html | ||
| org.servo.Servo.desktop | ||
| package-prefs.json | ||
| privatekey_for_testing.key | ||
| public_domains.txt | ||
| rippy.png | ||
| self_signed_certificate_for_testing.crt | ||
| servo.icns | ||
| servo.ico | ||
| servo.svg | ||
| servo_64.png | ||
| servo_1024.png | ||
| wpt-prefs.json | ||
