mirror of
https://github.com/servo/servo.git
synced 2025-09-27 15:20:09 +01:00
f5b631e270
devtools clients query source actors to determine where the user can set breakpoints in a source. there are two relevant requests here: `getBreakableLines` controls which line numbers can be clicked in the margin, and once a line number is clicked, `getBreakpointPositionsCompressed` controls where to show breakpoint buttons within that line. this patch handles those requests by querying the [SpiderMonkey Debugger API](https://firefox-source-docs.mozilla.org/js/Debugger/) for that information: - devtools sends its script thread a GetPossibleBreakpoints message for the source’s [`spidermonkey_id`](https://firefox-source-docs.mozilla.org/js/Debugger/Debugger.Source.html#id) - the script thread fires a `getPossibleBreakpoints` event into its debugger global - the debugger script looks up the [root](https://firefox-source-docs.mozilla.org/js/Debugger/Debugger.html#onnewscript-script-global) [Debugger.Script](https://firefox-source-docs.mozilla.org/js/Debugger/Debugger.Script.html#getpossiblebreakpoints-query) for that source, calls [getPossibleBreakpoints()](https://firefox-source-docs.mozilla.org/js/Debugger/Debugger.Script.html#getpossiblebreakpoints-query), and returns the result via DebuggerGlobalScope#getPossibleBreakpointsResult() - that method takes the pending result sender, and sends the result back to devtools - devtools massages the result into the format required by the request, and replies to the client as a result, users of the Firefox devtools client can now set breakpoints, though they don’t have any effect. Testing: this patch adds new devtools tests Fixes: part of #36027 <img width="1433" height="1328" alt="image" src="https://github.com/user-attachments/assets/f0cd31e0-742f-44d3-8c5d-ceedd9a2706d" /> --------- Signed-off-by: Delan Azabani <dazabani@igalia.com> Co-authored-by: atbrakhi <atbrakhi@igalia.com>
62 lines
1.9 KiB
Rust
62 lines
1.9 KiB
Rust
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */
|
|
|
|
use std::fmt::Debug;
|
|
|
|
use dom_struct::dom_struct;
|
|
|
|
use crate::dom::bindings::codegen::Bindings::DebuggerGetPossibleBreakpointsEventBinding::DebuggerGetPossibleBreakpointsEventMethods;
|
|
use crate::dom::bindings::codegen::Bindings::EventBinding::Event_Binding::EventMethods;
|
|
use crate::dom::bindings::reflector::reflect_dom_object;
|
|
use crate::dom::bindings::root::DomRoot;
|
|
use crate::dom::event::Event;
|
|
use crate::dom::types::GlobalScope;
|
|
use crate::script_runtime::CanGc;
|
|
|
|
#[dom_struct]
|
|
/// Event for Rust → JS calls in [`crate::dom::DebuggerGlobalScope`].
|
|
pub(crate) struct DebuggerGetPossibleBreakpointsEvent {
|
|
event: Event,
|
|
spidermonkey_id: u32,
|
|
}
|
|
|
|
impl DebuggerGetPossibleBreakpointsEvent {
|
|
pub(crate) fn new(
|
|
debugger_global: &GlobalScope,
|
|
spidermonkey_id: u32,
|
|
can_gc: CanGc,
|
|
) -> DomRoot<Self> {
|
|
let result = Box::new(Self {
|
|
event: Event::new_inherited(),
|
|
spidermonkey_id,
|
|
});
|
|
let result = reflect_dom_object(result, debugger_global, can_gc);
|
|
result
|
|
.event
|
|
.init_event("getPossibleBreakpoints".into(), false, false);
|
|
|
|
result
|
|
}
|
|
}
|
|
|
|
impl DebuggerGetPossibleBreakpointsEventMethods<crate::DomTypeHolder>
|
|
for DebuggerGetPossibleBreakpointsEvent
|
|
{
|
|
// check-tidy: no specs after this line
|
|
fn SpidermonkeyId(&self) -> u32 {
|
|
self.spidermonkey_id
|
|
}
|
|
|
|
fn IsTrusted(&self) -> bool {
|
|
self.event.IsTrusted()
|
|
}
|
|
}
|
|
|
|
impl Debug for DebuggerGetPossibleBreakpointsEvent {
|
|
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
|
|
f.debug_struct("DebuggerGetPossibleBreakpointsEvent")
|
|
.field("spidermonkey_id", &self.spidermonkey_id)
|
|
.finish()
|
|
}
|
|
}
|