mirror of
https://github.com/servo/servo.git
synced 2025-09-30 08:39:16 +01:00
91e4188a64
Script: added ```line_no``` as argument to both ```fetch_inline_module_script()``` & ```compile_module_script()``` to fix the inline script reporting wrong line issue ([#39415](https://github.com/servo/servo/issues/39415)). Originally, the function ```compile_module_script()``` hardwires the value 1 when invoking ```CompileOptionsWrapper::new()```. This is fine if the script is written in separate JS file, but for inline scripts, it will cause confusion if the ```<script>``` tag doesn't start from line #1. ```line_no``` is obtained from ```line_number```, a member variable from ```HTMLScriptElement```. Credits to @jdm for actually pointing out which functions to fix. Testing: Created a WPT test for this change, specifically: ```tests/wpt/tests/html/semantics/scripting-1/the-script-element/module/evaluation-error-5.html```. Fixes: issue [#39415](https://github.com/servo/servo/issues/39415) --------- Signed-off-by: RichardTjokroutomo <richard.tjokro2@gmail.com> Signed-off-by: Rocketjumper <112361665+RichardTjokroutomo@users.noreply.github.com> Co-authored-by: Josh Matthews <josh@joshmatthews.net> Co-authored-by: Euclid Ye <yezhizhenjiakang@gmail.com> |
||
|---|---|---|
| .. | ||
| blink_perf_tests | ||
| dromaeo | ||
| html | ||
| jquery | ||
| power | ||
| unit | ||
| wpt | ||