servo/components/layout_2020
eri 01820e2a8a
Improve how intrinsic sizes work for videos (#31746)
* feat: patch for video layout sizes

added rebase from main 2024/10/05

Co-authored-by: Josh Matthews <josh@joshmatthews.net>
Signed-off-by: eri <epazos@igalia.com>

* feat: take width and height parameters if provided

Signed-off-by: eri <epazos@igalia.com>

* chore: tidy the code and update test expectations

Signed-off-by: eri <epazos@igalia.com>

* feat: handle removing poster

Signed-off-by: eri <epazos@igalia.com>

* chore: update test expectations and remove debug code

Signed-off-by: eri <epazos@igalia.com>

* fix: issues after rebasing to main

Signed-off-by: eri <epazos@igalia.com>

* feat: pass src remove test and tidy

Signed-off-by: eri <epazos@igalia.com>

* chore: clippy fixes

Signed-off-by: eri <epazos@igalia.com>

* chore: update passing test expectations

Signed-off-by: eri <epazos@igalia.com>

* fix object-position-svg test

Signed-off-by: eri <epazos@igalia.com>

* fix unintentional override of video size and resize events

Signed-off-by: eri <epazos@igalia.com>

* change how resize events are sent to better match the spec

Signed-off-by: eri <epazos@igalia.com>

* simplify poster mutation handling

Co-authored-by: Oriol Brufau <obrufau@igalia.com>
Signed-off-by: eri <eri@inventati.org>

* improved handling of intrinsic sizes

- differentiate between natural size and css size
- presentational attributes
- fallback ratio for video element
- handle more cases where the src/poster are added/removed
- aspect ratio hints

Signed-off-by: eri <epazos@igalia.com>

* update test expectations

Signed-off-by: eri <epazos@igalia.com>

* fix cleaning current frame

Signed-off-by: eri <epazos@igalia.com>

* update test expectations

Signed-off-by: eri <epazos@igalia.com>

* Apply suggestions from code review

Co-authored-by: Oriol Brufau <obrufau@igalia.com>
Signed-off-by: eri <eri@inventati.org>

* More code review suggestions

Signed-off-by: eri <epazos@igalia.com>

* Prevent aspect-ratio:auto from pulling the ratio from the default object size

As resolved in https://github.com/w3c/csswg-drafts/issues/7524#issuecomment-1204462924

Signed-off-by: Oriol Brufau <obrufau@igalia.com>

---------

Signed-off-by: eri <epazos@igalia.com>
Signed-off-by: eri <eri@inventati.org>
Signed-off-by: Oriol Brufau <obrufau@igalia.com>
Co-authored-by: Josh Matthews <josh@joshmatthews.net>
Co-authored-by: Oriol Brufau <obrufau@igalia.com>
2024-10-29 22:42:22 +00:00
..
display_list Improve how intrinsic sizes work for videos (#31746) 2024-10-29 22:42:22 +00:00
flexbox layout: Avoid layout sometimes when stretching (#33967) 2024-10-24 17:44:30 +00:00
flow layout: Avoid layout sometimes when stretching (#33967) 2024-10-24 17:44:30 +00:00
fragment_tree Improve how intrinsic sizes work for videos (#31746) 2024-10-29 22:42:22 +00:00
table layout: Avoid layout sometimes when stretching (#33967) 2024-10-24 17:44:30 +00:00
tests layout: Right-to-left support for other layout modes (#33375) 2024-09-11 13:40:11 +00:00
Cargo.toml Gate all use of tracing behind Cargo feature (#33845) 2024-10-16 10:24:24 +00:00
cell.rs Strict import formatting (grouping and granularity) (#30325) 2023-09-11 19:16:54 +00:00
context.rs fonts: Simplify FontContext in two ways that affect the unit test (#33541) 2024-09-25 20:15:47 +00:00
dom.rs Improve how intrinsic sizes work for videos (#31746) 2024-10-29 22:42:22 +00:00
dom_traversal.rs Replace .map_or(false with Option::is_some_and (#33468) 2024-09-16 10:03:52 +00:00
formatting_contexts.rs layout: Avoid layout sometimes when stretching (#33967) 2024-10-24 17:44:30 +00:00
geom.rs Consistent resolution of cyclic percentages in min sizing properties (#33988) 2024-10-24 12:03:32 +00:00
layout_debug.rs clippy: Fix warnings in shared and config, fonts, layout, and layout_2020 components (#32674) 2024-07-04 14:18:58 +00:00
lib.rs Refactor positioned layout (#33922) 2024-10-21 10:41:42 +00:00
lists.rs layout: Add a basic support for list-style-position: outside (#32114) 2024-04-22 14:23:35 +00:00
positioned.rs layout: Avoid layout sometimes when stretching (#33967) 2024-10-24 17:44:30 +00:00
query.rs layout: Switch .len() comparison to is_empty() in components/layout_2020/query.rs. (#33544) 2024-09-25 20:29:30 +00:00
replaced.rs Improve how intrinsic sizes work for videos (#31746) 2024-10-29 22:42:22 +00:00
sizing.rs Implement keyword sizes for intrinsic contributions (#33854) 2024-10-26 09:15:19 +00:00
style_ext.rs Improve how intrinsic sizes work for videos (#31746) 2024-10-29 22:42:22 +00:00
traversal.rs script: Split style and layout data in DOM nodes (#31985) 2024-04-04 07:56:51 +00:00