servo/components/shared
eri 01820e2a8a
Improve how intrinsic sizes work for videos (#31746)
* feat: patch for video layout sizes

added rebase from main 2024/10/05

Co-authored-by: Josh Matthews <josh@joshmatthews.net>
Signed-off-by: eri <epazos@igalia.com>

* feat: take width and height parameters if provided

Signed-off-by: eri <epazos@igalia.com>

* chore: tidy the code and update test expectations

Signed-off-by: eri <epazos@igalia.com>

* feat: handle removing poster

Signed-off-by: eri <epazos@igalia.com>

* chore: update test expectations and remove debug code

Signed-off-by: eri <epazos@igalia.com>

* fix: issues after rebasing to main

Signed-off-by: eri <epazos@igalia.com>

* feat: pass src remove test and tidy

Signed-off-by: eri <epazos@igalia.com>

* chore: clippy fixes

Signed-off-by: eri <epazos@igalia.com>

* chore: update passing test expectations

Signed-off-by: eri <epazos@igalia.com>

* fix object-position-svg test

Signed-off-by: eri <epazos@igalia.com>

* fix unintentional override of video size and resize events

Signed-off-by: eri <epazos@igalia.com>

* change how resize events are sent to better match the spec

Signed-off-by: eri <epazos@igalia.com>

* simplify poster mutation handling

Co-authored-by: Oriol Brufau <obrufau@igalia.com>
Signed-off-by: eri <eri@inventati.org>

* improved handling of intrinsic sizes

- differentiate between natural size and css size
- presentational attributes
- fallback ratio for video element
- handle more cases where the src/poster are added/removed
- aspect ratio hints

Signed-off-by: eri <epazos@igalia.com>

* update test expectations

Signed-off-by: eri <epazos@igalia.com>

* fix cleaning current frame

Signed-off-by: eri <epazos@igalia.com>

* update test expectations

Signed-off-by: eri <epazos@igalia.com>

* Apply suggestions from code review

Co-authored-by: Oriol Brufau <obrufau@igalia.com>
Signed-off-by: eri <eri@inventati.org>

* More code review suggestions

Signed-off-by: eri <epazos@igalia.com>

* Prevent aspect-ratio:auto from pulling the ratio from the default object size

As resolved in https://github.com/w3c/csswg-drafts/issues/7524#issuecomment-1204462924

Signed-off-by: Oriol Brufau <obrufau@igalia.com>

---------

Signed-off-by: eri <epazos@igalia.com>
Signed-off-by: eri <eri@inventati.org>
Signed-off-by: Oriol Brufau <obrufau@igalia.com>
Co-authored-by: Josh Matthews <josh@joshmatthews.net>
Co-authored-by: Oriol Brufau <obrufau@igalia.com>
2024-10-29 22:42:22 +00:00
..
background_hang_monitor Remove size_of_test macro from legacy layout and inline it (#34055) 2024-10-29 14:46:10 +00:00
base Remove size_of_test macro from legacy layout and inline it (#34055) 2024-10-29 14:46:10 +00:00
bluetooth doc(resources): Add documentation to undocumented embedder_traits::resources::Resource variants (#33885) 2024-10-18 03:44:14 +00:00
canvas Use ROUTER::add_typed_route instead of ROUTER::add_route everywhere (#33866) 2024-10-18 10:47:52 +00:00
compositing compositor: Create a single cross-process compositor API (#33619) (#33660) 2024-10-09 17:30:24 +00:00
devtools Create HttpStatus to safely deal with HTTP responses status. (#33581) 2024-09-29 18:23:48 +00:00
embedder Use ROUTER::add_typed_route instead of ROUTER::add_route everywhere (#33866) 2024-10-18 10:47:52 +00:00
fonts Add rust-version to all Cargo.toml files (#33483) 2024-09-17 16:39:07 +00:00
net Use ROUTER::add_typed_route instead of ROUTER::add_route everywhere (#33866) 2024-10-18 10:47:52 +00:00
profile Use ROUTER::add_typed_route instead of ROUTER::add_route everywhere (#33866) 2024-10-18 10:47:52 +00:00
script Use ROUTER::add_typed_route instead of ROUTER::add_route everywhere (#33866) 2024-10-18 10:47:52 +00:00
script_layout Improve how intrinsic sizes work for videos (#31746) 2024-10-29 22:42:22 +00:00
webrender compositor: Create a single cross-process compositor API (#33619) (#33660) 2024-10-09 17:30:24 +00:00