The Servo Browser Engine
Find a file
Martin Robinson 027fc53e2f
layout: Right-to-left support for other layout modes (#33375)
This change removes the `effective_writing_mode` concept and tries to
properly implement right-to-left layout support for all non-inline
writing modes. In general, what needs to happen is that rectangles
need to be converted to physical rectangles using the containing block.
A right-to-left rectangle's inline start is on the right physical side
of the containing block. Likewise a positive inline offset in
right-to-left text is a negative physical one.

The implementation here is pretty good for most layout modes, but floats
are still a bit in process. Currently, floats are processed in the
logical layout of the block container, but there still might be issues
with float interaction with mixed RTL and LTR.

While this does move us closer to supporting vertical writing modes,
this is still unsupported.

New failures:
 - Vertical writing mode not supported:
   - `/css/CSS2/floats/floats-placement-vertical-001b.xht`
   - `/css/CSS2/floats/floats-placement-vertical-001c.xht`
 - Absolutes inlines should avoid floats (#33323)
   - `/css/css-position/position-absolute-dynamic-static-position-floats-004.html`
 - No support for grid
   - `/css/css-align/self-alignment/self-align-safe-unsafe-grid-003.html`
   - `/css/css-position/static-position/inline-level-absolute-in-block-level-context-009.html`
   - `/css/css-position/static-position/inline-level-absolute-in-block-level-context-010.html`
 - Cannot reproduce these locally on any platform. Very mysterious:
   - `/css/css-tables/row-group-margin-border-padding.html`
   - `/css/css-tables/row-margin-border-padding.html`
 - Exposes bugs we have related to hanging whitespace in preserved
   whitespace inlines:
   - `/css/css-text/white-space/trailing-space-and-text-alignment-rtl-003.html`
   - `/css/css-text/white-space/white-space-pre-wrap-trailing-spaces-023.html`

Signed-off-by: Martin Robinson <mrobinson@igalia.com>
Co-authored-by: Rakhi Sharma <atbrakhi@igalia.com>
2024-09-11 13:40:11 +00:00
.cargo Make crown optional (#32494) 2024-06-24 11:46:43 +00:00
.github CI: fix self-hosted runners in Linux builds (#33389) 2024-09-10 07:30:38 +00:00
.vscode
components layout: Right-to-left support for other layout modes (#33375) 2024-09-11 13:40:11 +00:00
docs Update in-tree docs to point to the new book (#32743) 2024-07-09 15:42:00 +00:00
etc Update Rust to 1.80.1 (#33008) 2024-08-12 11:40:46 +00:00
ports/servoshell Plumb selected tracing spans into hitrace (#33324) 2024-09-10 09:03:55 +00:00
python android: make aarch64 the default target (#33379) 2024-09-09 14:38:01 +00:00
resources servoshell: Enable OpenXR by default and remove old WebVR prefs, adjust XrDiscovery initialization (#33245) 2024-08-29 05:06:57 +00:00
support Update layout of servoshell android app (#33294) 2024-09-04 11:30:52 +00:00
tests layout: Right-to-left support for other layout modes (#33375) 2024-09-11 13:40:11 +00:00
third_party Update WebIDL.py (#32495) 2024-06-15 04:22:42 +00:00
.clang-format
.flake8
.gitattributes mark test/wpt as vendored in .gitattributes (#32663) 2024-07-02 11:23:18 +00:00
.gitignore Add initial support for tracing and tracing-perfetto (#33188) 2024-09-04 08:24:29 +00:00
.mailmap
Cargo.lock Stop using time@0.1 in Servo (#33394) 2024-09-11 07:09:56 +00:00
Cargo.toml Stop using time@0.1 in Servo (#33394) 2024-09-11 07:09:56 +00:00
CLOBBER
CODE_OF_CONDUCT.md Clarify the Code of Conduct (closes servo/servo.org#164) (#32835) 2024-07-23 09:12:03 +00:00
CONTRIBUTING.md Update in-tree docs to point to the new book (#32743) 2024-07-09 15:42:00 +00:00
deny.toml Add cargo-deny to mach-tidy to check license compliance. (#32465) 2024-06-12 09:54:45 +00:00
Info.plist
LICENSE
mach
mach.bat
PULL_REQUEST_TEMPLATE.md
README.md Update mozjs (SpiderMonkey) to 128.0 (#32769) 2024-07-29 07:20:15 +00:00
rust-toolchain.toml CI: Add separate Lint&Tidy check and remove test-tidy from linux (#33150) 2024-08-23 08:58:12 +00:00
rustfmt.toml
SECURITY.md Update new issue URL in SECURITY.md (#31698) 2024-03-15 15:03:49 +00:00
servo-tidy.toml Make tracing available on all platforms, with or without perfetto (#33301) 2024-09-04 12:56:29 +00:00
servobuild.example Add OpenHarmony support to mach and CI (#32507) 2024-06-17 11:27:23 +00:00
shell.nix Nix: allow nix-shell without explicit path to shell.nix (#32035) 2024-04-17 07:02:31 +00:00
taplo.toml

The Servo Parallel Browser Engine Project

Servo is a prototype web browser engine written in the Rust language. It is currently developed on 64-bit macOS, 64-bit Linux, 64-bit Windows, and Android.

Servo welcomes contribution from everyone. Check out The Servo Book to get started, or go to servo.org for news and guides.

Getting started

For more detailed build instructions, see the Servo book under Setting up your environment, Building Servo, and Building for Android.

macOS

  • Download and install python, Xcode, and brew
  • Install rustup: curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh
  • Restart your shell to make sure cargo is available
  • Install the other dependencies: ./mach bootstrap
  • Build servoshell: ./mach build

Linux

  • Install curl and python:
    • Arch: sudo pacman -S --needed curl python python-pip
    • Debian, Ubuntu: sudo apt install curl python3-pip python3-venv
    • Fedora: sudo dnf install curl python3 python3-pip python3-devel
    • Gentoo: sudo emerge net-misc/curl dev-python/pip
  • Install rustup: curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh
  • Restart your shell to make sure cargo is available
  • Install the other dependencies: ./mach bootstrap
  • Build servoshell: ./mach build

Windows

  • Download and install python, choco, and rustup
    • Be sure to select Quick install via the Visual Studio Community installer
  • In the Visual Studio Installer, ensure the following components are installed:
    • Windows 10 SDK (10.0.19041.0) (Microsoft.VisualStudio.Component.Windows10SDK.19041)
    • MSVC v143 - VS 2022 C++ x64/x86 build tools (Latest) (Microsoft.VisualStudio.Component.VC.Tools.x86.x64)
    • C++ ATL for latest v143 build tools (x86 & x64) (Microsoft.VisualStudio.Component.VC.ATL)
    • C++ MFC for latest v143 build tools (x86 & x64) (Microsoft.VisualStudio.Component.VC.ATLMFC)
  • Restart your shell to make sure cargo is available
  • Install the other dependencies: .\mach bootstrap
  • Build servoshell: .\mach build

Android

  • Ensure that the following environment variables are set:
    • ANDROID_SDK_ROOT
    • ANDROID_NDK_ROOT: $ANDROID_SDK_ROOT/ndk/26.2.11394342/ ANDROID_SDK_ROOT can be any directory (such as ~/android-sdk). All of the Android build dependencies will be installed there.
  • Install the latest version of the Android command-line tools to $ANDROID_SDK_ROOT/cmdline-tools/latest.
  • Run the following command to install the necessary components:
    sudo $ANDROID_SDK_ROOT/cmdline-tools/latest/bin/sdkmanager --install
     "build-tools;33.0.2" \
     "emulator" \
     "ndk;26.2.11394342" \
     "platform-tools" \
     "platforms;android-33" \
     "system-images;android-33;google_apis;x86_64"
    
  • Follow the instructions above for the platform you are building on