mirror of
https://github.com/servo/servo.git
synced 2025-08-06 06:00:15 +01:00
5b4cc9568d
Update to string-cache 0.3
Previously, `string-cache` defined:
* An string-like `Atom` type,
* An `atom!("foo")` macro that expands to a value of that type, for a set of strings known at compile-time,
* A `struct Namespace(Atom);` type
* A `ns!(html)` macro that maps known prefixed to `Namespace` values with the corresponding namespace URL.
Adding a string to the static set required making a change to the `string-cache` crate.
With 0.3, the `Atom` type is now generic, with a type parameter that provides a set of static strings. We can have multiple such sets, defined in different crates. The `string_cache_codegen` crate, to be used in build scripts, generates code that defines such a set, a new atom type (a type alias for `Atom<_>` with the type parameter set), and an `atom!`-like macro.
The html5ever repository has a new `html5ever_atoms` crate that defines three such types: `Prefix`, `Namespace`, and `LocalName` (with respective `namespace_prefix!`, `namespace_url!`, and `local_name!` macros). It also defines the `ns!` macro like before.
This repository has a new `servo_atoms` crate in `components/atoms` that, for now, defines a single `Atom` type (and `atom!`) macro. (`servo_atoms::Atom` is defined as something like `type Atom = string_cache::Atom<ServoStaticStringSet>;`, so overall there’s now two types named `Atom`.)
In this PR, `servo_atoms::Atom` is used for everything else that was `string_cache::Atom` before. But more atom types can be defined as needed. Two reasons to do this are to auto-generate the set of static strings (I’m planning to do this for CSS property names, which is the motivation for this change), or to have the type system help us avoid mix up unrelated things (this is why we had a `Namespace` type ever before this change).
Introducing new types helped me find a bug: when creating a new attribute `dom::Element::set_style_attr`, would pass `Some(atom!("style"))` instead of `None` (now `Option<html5ever_atoms::Prefix>` instead of `Option<string_cache::Atom>`) to the `prefix` argument of `Attr::new`. I suppose the author of that code confused it with the `local_name` argument.
---
Note that Stylo is not affected by any of this. The `gecko_string_cache` module is unchanged, with a single `Atom` type. The `style` crate conditionally compiles `Prefix` and `LocalName` re-exports for that are both `gecko_string_cache::Atom` on stylo.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14043)
<!-- Reviewable:end -->
|
||
|---|---|---|
| .. | ||
| binding_tools | ||
| gecko | ||
| gecko_bindings | ||
| gecko_string_cache | ||
| properties | ||
| values | ||
| animation.rs | ||
| atomic_refcell.rs | ||
| attr.rs | ||
| bezier.rs | ||
| build.rs | ||
| cache.rs | ||
| Cargo.toml | ||
| cascade_info.rs | ||
| context.rs | ||
| custom_properties.rs | ||
| data.rs | ||
| dom.rs | ||
| element_state.rs | ||
| error_reporting.rs | ||
| font_face.rs | ||
| keyframes.rs | ||
| lib.rs | ||
| logical_geometry.rs | ||
| matching.rs | ||
| media_queries.rs | ||
| owning_handle.rs | ||
| parallel.rs | ||
| parser.rs | ||
| README.md | ||
| refcell.rs | ||
| restyle_hints.rs | ||
| selector_impl.rs | ||
| selector_matching.rs | ||
| sequential.rs | ||
| servo_selector_impl.rs | ||
| sink.rs | ||
| str.rs | ||
| stylesheets.rs | ||
| thread_state.rs | ||
| tid.rs | ||
| timer.rs | ||
| traversal.rs | ||
| viewport.rs | ||
| workqueue.rs | ||
