mirror of
https://github.com/servo/servo.git
synced 2025-07-25 08:10:21 +01:00
./mach has a formatting error <!-- Please describe your changes on the following line: --> Fix for #12766. Couldn't reproduce the exact error. I explicitly raised urllib2.URLError to get to the print and then tried using many different variable types for e.reason and src but it still didn't throw a coercion error. So, as @Wafflespeanut said, > Instead of appending, we can format the values, which (I'm pretty sure) will fix this error. which is what i've done. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12766, hopefully. <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests they execute before the test runner is installed. Can't test the bootstraping code. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12870) <!-- Reviewable:end --> |
||
---|---|---|
.. | ||
__init__.py | ||
bootstrap_commands.py | ||
build_commands.py | ||
command_base.py | ||
devenv_commands.py | ||
package_commands.py | ||
post_build_commands.py | ||
testing_commands.py |