mirror of
https://github.com/servo/servo.git
synced 2025-10-17 08:49:21 +01:00
160c7c0b0f
* clippy: Squish warnings and errors in gfx warning: redundant closure (gfx/font.rs:415:18) warning: useless conversion to the same type (gfx/font.rs:534:9) warning: the following explicit lifetimes could be elided: 'a (gfx/font.rs:619:16) error: this loop never actually loops (gfx/font_cache_thread.rs:112:9) warning: this expression creates a reference which is immediately dereferenced by the compiler (gfx/font_cache_thread.rs:229:51) warning: redundant closure (gfx/font_cache_thread.rs:551:18) 3 instances of: warning: casting integer literal to `f64` is unnecessary (gfx/platform/freetype/font_list.rs:271-273) * clippy: methods called `from_*` usually take no `self` It reports that by standard convention, from_* methods should not take any `&self` parameter * clippy: you should consider adding a `Default` implementation It reports that public types with a pub fn new() -> Self should have a Default implementation since they can be constructed without arguments * clippy: casting to the same type is unnecessary (`f32` -> `f32`) * clippy: use of `unwrap_or_else` to construct default value * clippy: methods called `is_*` usually take `self` by mutable reference or `self` by reference or no `self` * clippy: manual `!RangeInclusive::contains` implementation contains expresses the intent better and has less failure modes (such as fencepost errors or using || instead of &&) * clippy: this function has an empty `#[must_use]` attribute, but returns a type already marked as `#[must_use]` * clippy: Fix some new warnings warning: this `if` statement can be collapsed (gfx/font.rs:468:130) warning: this lifetime isn't used in the impl (gfx/platform/freetype/font.rs:341:6) warning: field assignment outside of initializer for an instance created with Default::default() (compositor.rs:881:17) |
||
|---|---|---|
| .. | ||
| codegen | ||
| buffer_source.rs | ||
| callback.rs | ||
| cell.rs | ||
| constant.rs | ||
| conversions.rs | ||
| error.rs | ||
| finalize.rs | ||
| guard.rs | ||
| htmlconstructor.rs | ||
| import.rs | ||
| inheritance.rs | ||
| interface.rs | ||
| iterable.rs | ||
| like.rs | ||
| mod.rs | ||
| namespace.rs | ||
| num.rs | ||
| principals.rs | ||
| proxyhandler.rs | ||
| record.rs | ||
| refcounted.rs | ||
| reflector.rs | ||
| root.rs | ||
| serializable.rs | ||
| settings_stack.rs | ||
| str.rs | ||
| structuredclone.rs | ||
| trace.rs | ||
| transferable.rs | ||
| utils.rs | ||
| weakref.rs | ||
| xmlname.rs | ||