servo/components/script
bors-servo 18ab860f4c
Auto merge of #24669 - glowe:issue-24628/set-mime-type, r=jdm
Set response mime_type based on Content-Type

<!-- Please describe your changes on the following line: -->
Set the response's `mime_type` based on its `Content-Type` header whenever `Response::set_headers` is called. This ensures that `mime_type` is always consistent with `Content-Type`. The other reason for going with this approach is it relies on `extract_mime_type`: afbcbf75ea/components/script/dom/headers.rs (L260-L261)

Besides the consistency argument, I also expect that we'll update the `extract_mime_type` method to conform with its specification.

Another option I explored was adding a `set_mime_type` member to `Response` and calling that with the mime type from `Metadata::content_type` in `FetchResponseListener::process_response`. I decided against this since it expanded the interface of `Response` and didn't have the same benefits of the first option.

Fixes #24628.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24628.

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-11-18 17:31:47 -05:00
..
docs
dom Auto merge of #24669 - glowe:issue-24628/set-mime-type, r=jdm 2019-11-18 17:31:47 -05:00
task_source continue messageport, transferable, postmessage options 2019-10-19 14:28:18 +08:00
body.rs Modify *::get_cx methods to return a safe JSContext instead of a raw one 2019-07-24 09:53:10 +01:00
build.rs Update rand to 0.7 (fixes #24448) 2019-10-23 15:34:48 +02:00
canvas_state.rs Use #![register_tool] instead of #![register_attr] 2019-11-15 17:24:42 +01:00
Cargo.toml Update rand to 0.7 (fixes #24448) 2019-10-23 15:34:48 +02:00
clipboard_provider.rs Remove not needed DummyClipboardContext 2019-06-13 20:20:25 +02:00
compartments.rs Use safe JSContext in compartments 2019-08-09 00:02:10 +01:00
devtools.rs Modify *::get_cx methods to return a safe JSContext instead of a raw one 2019-07-24 09:53:10 +01:00
document_loader.rs Use #![register_tool] instead of #![register_attr] 2019-11-15 17:24:42 +01:00
euclidext.rs Addresses issues raised in #24465; removes redundancy in set_bitmap_dimensions 2019-11-10 18:37:14 -05:00
fetch.rs Add simple implementation of content-security-policy on scripts / styles 2019-10-16 19:46:45 +00:00
image_listener.rs
init.rs Move items at the root of the script crate to a module 2019-10-26 12:59:17 +02:00
layout_image.rs
lib.rs Use #![register_tool] instead of #![register_attr] 2019-11-15 17:24:42 +01:00
mem.rs
microtask.rs Use safe JSContext in MicrotaskQueue 2019-08-09 00:02:10 +01:00
network_listener.rs Let resources timing entries be added to performance entry buffer. 2019-06-11 09:40:31 -07:00
script_runtime.rs Add consume stream callback 2019-11-11 16:48:52 -05:00
script_thread.rs Auto merge of #24742 - servo:jdm-patch-34, r=asajeffrey 2019-11-16 18:32:27 -05:00
serviceworker_manager.rs continue messageport, transferable, postmessage options 2019-10-19 14:28:18 +08:00
serviceworkerjob.rs Use #![register_tool] instead of #![register_attr] 2019-11-15 17:24:42 +01:00
stylesheet_loader.rs Support CORS attributes for image elements. 2019-10-04 15:08:40 -04:00
stylesheet_set.rs Move StylesheetSetRef to script 2019-04-26 12:00:26 +02:00
task.rs Upgrade to rustc 1.38.0-nightly (dddb7fca0 2019-07-30) 2019-07-31 13:34:01 +02:00
task_manager.rs begin messageport, transferable objects, impl 2019-10-19 14:12:22 +08:00
task_queue.rs
test.rs
textinput.rs Upgrade to rustc 1.38.0-nightly (dddb7fca0 2019-07-30) 2019-07-31 13:34:01 +02:00
timers.rs update timer scheduler to use crossbeam 2019-10-20 23:42:34 +08:00
unpremultiplytable.rs
webdriver_handlers.rs Implement ElementClick wd command 2019-08-31 10:14:40 +03:00