mirror of
https://github.com/servo/servo.git
synced 2025-07-23 07:13:52 +01:00
18de59dd63
Previously, the devtools code was structured like this (in pseudocode):
```rust
fn run() {
let member_1;
let member_2;
fn foo(&member_1) {
// ...
}
fn bar(&member_1, &member_2) {
// ...
}
loop {
match get_message() {
Message1 => foo(&member_1),
Message2 => bar(&member_1, &member_2),
}
}
}
```
This is not very idiomatic rust. And, more importantly, it makes it hard
to edit this code with an IDE, because "find all references" and similar
actions don't properly work. (member_1 inside "foo" is a different
variable than member_1 inside "bar" or "run").
Instead, the code is now structured (roughly) like this:
```rust
struct DevtoolsInstance {
member_1,
member_2,
}
impl DevtoolsInstance {
fn foo(&self) {
// ...
}
fn bar(&self) {
// ...
}
fn run(&self) {
loop {
match get_message() {
Message1 => self.foo(),
Message2 => self.bar(),
}
}
}
}
```
In my opinion, this is an improvement and should make future additions
to the devtools server easier. No behaviour change is intended.
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
|
||
|---|---|---|
| .. | ||
| allocator | ||
| background_hang_monitor | ||
| bluetooth | ||
| canvas | ||
| compositing | ||
| config | ||
| constellation | ||
| deny_public_fields | ||
| devtools | ||
| dom_struct | ||
| domobject_derive | ||
| fonts | ||
| geometry | ||
| hyper_serde | ||
| jstraceable_derive | ||
| layout | ||
| layout_2020 | ||
| layout_thread | ||
| layout_thread_2020 | ||
| malloc_size_of | ||
| media | ||
| metrics | ||
| net | ||
| pixels | ||
| profile | ||
| rand | ||
| range | ||
| script | ||
| script_bindings | ||
| servo | ||
| shared | ||
| timers | ||
| url | ||
| webdriver_server | ||
| webgpu | ||
| webxr | ||