mirror of
https://github.com/servo/servo.git
synced 2025-06-06 16:45:39 +00:00
1f558a0d49
This PR fixes an issue where radio inputs in the same group failed to correctly update their `validity.valueMissing` state when: - A **checked radio button was removed** from the DOM. - A **different radio button was selected** by user interaction. This behavior caused mismatches with how browsers like Firefox handle radio group validation. --- ### Changes in This PR #### Radio group revalidation on DOM removal - Updated `unbind_from_tree()` to revalidate other radio buttons in the same group when a checked input is removed. - Uses `UnbindContext::parent` as the DOM root to ensure the correct context is used during traversal. #### New helper: `find_related_radios()` - Encapsulates logic for finding other inputs in the same group. - Used during both removal and attribute changes for consistency. #### Validation on `checked`/`value` updates - Introduced `update_related_validity_states()` to revalidate all group members when a radio's `checked` or `value` is changed. #### Web Platform Test (WPT) coverage - Created a new WPT file: `radio-group-valueMissing.html`. - Tests follow recommended `test()` pattern: - **Precondition**: Assert initial `valueMissing`. - **Action**: Remove or select a radio. - **Postcondition**: Assert expected `valueMissing`. #### Manifest updated - The WPT manifest now includes the new test. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #36110 <!-- Either: --> - [X] There are tests for these changes Signed-off-by: Emmanuel Elom <elomemmanuel007@gmail.com>
44 lines
1.6 KiB
Rust
44 lines
1.6 KiB
Rust
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */
|
|
|
|
use crate::dom::element::Element;
|
|
use crate::dom::event::Event;
|
|
use crate::dom::eventtarget::EventTarget;
|
|
use crate::dom::htmlinputelement::InputActivationState;
|
|
use crate::script_runtime::CanGc;
|
|
|
|
/// Trait for elements with defined activation behavior
|
|
pub(crate) trait Activatable {
|
|
fn as_element(&self) -> ∈
|
|
|
|
// Is this particular instance of the element activatable?
|
|
fn is_instance_activatable(&self) -> bool;
|
|
|
|
// https://dom.spec.whatwg.org/#eventtarget-legacy-pre-activation-behavior
|
|
fn legacy_pre_activation_behavior(&self, _can_gc: CanGc) -> Option<InputActivationState> {
|
|
None
|
|
}
|
|
|
|
// https://dom.spec.whatwg.org/#eventtarget-legacy-canceled-activation-behavior
|
|
fn legacy_canceled_activation_behavior(
|
|
&self,
|
|
_state_before: Option<InputActivationState>,
|
|
_can_gc: CanGc,
|
|
) {
|
|
}
|
|
|
|
// https://dom.spec.whatwg.org/#eventtarget-activation-behavior
|
|
// event and target are used only by HTMLAnchorElement, in the case
|
|
// where the target is an <img ismap> so the href gets coordinates appended
|
|
fn activation_behavior(&self, event: &Event, target: &EventTarget, can_gc: CanGc);
|
|
|
|
// https://html.spec.whatwg.org/multipage/#concept-selector-active
|
|
fn enter_formal_activation_state(&self) {
|
|
self.as_element().set_active_state(true);
|
|
}
|
|
|
|
fn exit_formal_activation_state(&self) {
|
|
self.as_element().set_active_state(false);
|
|
}
|
|
}
|