mirror of
https://github.com/servo/servo.git
synced 2025-07-30 02:30:21 +01:00
1f558a0d49
This PR fixes an issue where radio inputs in the same group failed to correctly update their `validity.valueMissing` state when: - A **checked radio button was removed** from the DOM. - A **different radio button was selected** by user interaction. This behavior caused mismatches with how browsers like Firefox handle radio group validation. --- ### Changes in This PR #### Radio group revalidation on DOM removal - Updated `unbind_from_tree()` to revalidate other radio buttons in the same group when a checked input is removed. - Uses `UnbindContext::parent` as the DOM root to ensure the correct context is used during traversal. #### New helper: `find_related_radios()` - Encapsulates logic for finding other inputs in the same group. - Used during both removal and attribute changes for consistency. #### Validation on `checked`/`value` updates - Introduced `update_related_validity_states()` to revalidate all group members when a radio's `checked` or `value` is changed. #### Web Platform Test (WPT) coverage - Created a new WPT file: `radio-group-valueMissing.html`. - Tests follow recommended `test()` pattern: - **Precondition**: Assert initial `valueMissing`. - **Action**: Remove or select a radio. - **Postcondition**: Assert expected `valueMissing`. #### Manifest updated - The WPT manifest now includes the new test. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #36110 <!-- Either: --> - [X] There are tests for these changes Signed-off-by: Emmanuel Elom <elomemmanuel007@gmail.com> |
||
|---|---|---|
| .. | ||
| docs | ||
| dom | ||
| layout_dom | ||
| svgpath | ||
| xpath | ||
| animation_timeline.rs | ||
| animations.rs | ||
| body.rs | ||
| build.rs | ||
| canvas_context.rs | ||
| canvas_state.rs | ||
| Cargo.toml | ||
| clipboard_provider.rs | ||
| conversions.rs | ||
| devtools.rs | ||
| document_collection.rs | ||
| document_loader.rs | ||
| drag_data_store.rs | ||
| fetch.rs | ||
| iframe_collection.rs | ||
| image_animation.rs | ||
| init.rs | ||
| layout_image.rs | ||
| lib.rs | ||
| links.rs | ||
| messaging.rs | ||
| microtask.rs | ||
| navigation.rs | ||
| network_listener.rs | ||
| realms.rs | ||
| routed_promise.rs | ||
| script_module.rs | ||
| script_runtime.rs | ||
| script_thread.rs | ||
| security_manager.rs | ||
| serviceworker_manager.rs | ||
| stylesheet_loader.rs | ||
| stylesheet_set.rs | ||
| task.rs | ||
| task_manager.rs | ||
| task_queue.rs | ||
| task_source.rs | ||
| test.rs | ||
| textinput.rs | ||
| timers.rs | ||
| unminify.rs | ||
| webdriver_handlers.rs | ||
| window_named_properties.rs | ||