7a556a7f03
It's unfortunate, but it's a correctness issue. I was looking at the expectations update here: * https://hg.mozilla.org/integration/autoland/rev/659cddddd434 And investigating it I realised that it's wrong to coalesce selectors like that, because we keep the bloom filter flags. So in the test cases disabled, we have a selector that looks like this: msub > :not(:first-child), msup > :not(:first-child), msubsup > :not(:first-child), mmultiscripts > :not(:first-child) { -moz-script-level: +1; -moz-math-display: inline; } And an element that looks like this: <msubsup><mi></mi><mi></mi></msubsup> We're only inserting the first selector msub > :not(:first-child) into the set, so when we're going to match the <mi> elements we fast-reject it in both cases due to the bloom filter, so they share style. I can't see an easy way to fix this keeping the deduplication. If we keep it, we need to remove the bloom filter optimization, which means that we'd trash the cache for every first-child in the document (the :not(:first-child) effectively becomes a global rule). MozReview-Commit-ID: 9VPkmdj9zDg Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io> |
||
|---|---|---|
| .. | ||
| arcslice.rs | ||
| bloom.rs | ||
| Cargo.toml | ||
| lib.rs | ||
| matching.rs | ||
| parser.rs | ||
| README.md | ||
| tree.rs | ||
| visitor.rs | ||
rust-selectors
CSS Selectors library for Rust. Includes parsing and serilization of selectors, as well as matching against a generic tree of elements. Pseudo-elements and most pseudo-classes are generic as well.
Warning: breaking changes are made to this library fairly frequently (13 times in 2016, for example). However you can use this crate without updating it that often, old versions stay available on crates.io and Cargo will only automatically update to versions that are numbered as compatible.
To see how to use this library with your own tree representation,
see Kuchiki’s src/select.rs.
(Note however that Kuchiki is not always up to date with the latest rust-selectors version,
so that code may need to be tweaked.)
If you don’t already have a tree data structure,
consider using Kuchiki itself.