mirror of
https://github.com/servo/servo.git
synced 2025-06-26 18:14:34 +01:00
2dfbbd0ca2
Clean-up navigation <!-- Please describe your changes on the following line: --> 1. Navigation as a result of following a hyperlink should be done in a task: https://html.spec.whatwg.org/multipage/links.html#following-hyperlinks:dom-manipulation-task-source 2. The javascript url navigation should also be done in a task: https://html.spec.whatwg.org/multipage/browsing-the-web.html#navigating-across-documents:dom-manipulation-task-source 3. In `window.load_url`, it seems there is no need to send a message to the script-thread(the entirety of `load_url` should instead be done in a task when appropriate), so we can just do that last part "sync" by calling a method on the script, which will send a message to the constellation(for the parallel navigation steps), or queue task(for the JS navigation), as appropriate. 4. Separate the "normal" navigation flow from the handling of "navigate an iframe" message from constellation, since doing everything in one method as was previously done with `handle_navigate`, is confusing. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23368) <!-- Reviewable:end --> |
||
|---|---|---|
| .. | ||
| execution-timing | ||
| fetch-src | ||
| json-module | ||
| module | ||
| resources | ||
| support | ||
| async_001.htm | ||
| async_002.htm | ||
| async_003.htm | ||
| async_004.htm | ||
| async_005.htm | ||
| async_006.htm | ||
| async_007.htm | ||
| async_008.htm | ||
| async_009.htm | ||
| async_010.htm | ||
| async_011.htm | ||
| cacheable-script-throw.py | ||
| data-url.html | ||
| defer.js | ||
| emptyish-script-elements.html | ||
| external-script-utf8.js | ||
| external-script-windows1250.js | ||
| historical.html | ||
| is-module-goal.mjs | ||
| is-script-goal.js | ||
| load-error-events-1.html | ||
| load-error-events-2.html | ||
| load-error-events-3.html | ||
| log.py | ||
| muted-errors-iframe.html | ||
| muted-errors.sub.html | ||
| nomodule-reflect.html | ||
| nomodule-set-on-async-classic-script.html | ||
| nomodule-set-on-external-module-script.html | ||
| nomodule-set-on-inline-classic-scripts.html | ||
| nomodule-set-on-inline-module-script.html | ||
| nomodule-set-on-synchronously-loaded-classic-scripts.html | ||
| script-charset-01.html | ||
| script-charset-02.html | ||
| script-charset-03.html | ||
| script-crossorigin-network.html | ||
| script-crossorigin.html | ||
| script-defer.html | ||
| script-for-event-xhtml.xhtml | ||
| script-for-event.html | ||
| script-noembed-noframes-iframe.xhtml | ||
| script-not-executed-after-shutdown-child.html | ||
| script-not-executed-after-shutdown.html | ||
| script-not-executed-after-shutdown.js | ||
| script-not-found-not-executed-2.py | ||
| script-not-found-not-executed.html | ||
| script-not-found-not-executed.py | ||
| script-onerror-insertion-point-1.html | ||
| script-onerror-insertion-point-2.html | ||
| script-onload-insertion-point.html | ||
| script-onload-string.html | ||
| script-text-modifications.html | ||
| script-text-xhtml.xhtml | ||
| script-text.html | ||
| script-type-and-language-empty.html | ||
| script-type-and-language-js.html | ||
| script-type-and-language-with-params.html | ||
| scripting-enabled.html | ||
| serve-with-content-type.py | ||
