mirror of
https://github.com/servo/servo.git
synced 2025-06-06 16:45:39 +00:00
312cf0df08
Up until now, Servo was using a very old version of time to get a cross-process monotonic timestamp (using `time::precise_time_ns()`). This change replaces the usage of old time with a new serializable monotonic time called `CrossProcessInstant` and uses it where `u64` timestamps were stored before. The standard library doesn't provide this functionality because it isn't something you can do reliably on all platforms. The idea is that we do our best and then fall back gracefully. This is a big change, because Servo was using `u64` timestamps all over the place some as raw values taken from `time::precise_time_ns()` and some as relative offsets from the "navigation start," which is a concept similar to DOM's `timeOrigin` (but not exactly the same). It's very difficult to fix this situation without fixing it everywhere as the `Instant` concept is supposed to be opaque. The good thing is that this change clears up all ambiguity when passing times as a `time::Duration` is unit agnostic and a `CrossProcessInstant` represents an absolute moment in time. The `time` version of `Duration` is used because it can both be negative and is also serializable. Good things: - No need too pass around `time` and `time_precise` any longer. `CrossProcessInstant` is also precise and monotonic. - The distinction between a time that is unset or at `0` (at some kind of timer epoch) is now gone. There still a lot of work to do to clean up timing, but this is the first step. In general, I've tried to preserve existing behavior, even when not spec compliant, as much as possible. I plan to submit followup PRs fixing some of the issues I've noticed. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
98 lines
3 KiB
Rust
98 lines
3 KiB
Rust
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */
|
|
|
|
use base::cross_process_instant::CrossProcessInstant;
|
|
use dom_struct::dom_struct;
|
|
use time_03::Duration;
|
|
|
|
use super::performance::ToDOMHighResTimeStamp;
|
|
use crate::dom::bindings::codegen::Bindings::PerformanceBinding::DOMHighResTimeStamp;
|
|
use crate::dom::bindings::codegen::Bindings::PerformanceEntryBinding::PerformanceEntryMethods;
|
|
use crate::dom::bindings::reflector::{reflect_dom_object, DomObject, Reflector};
|
|
use crate::dom::bindings::root::DomRoot;
|
|
use crate::dom::bindings::str::DOMString;
|
|
use crate::dom::globalscope::GlobalScope;
|
|
|
|
#[dom_struct]
|
|
pub struct PerformanceEntry {
|
|
reflector_: Reflector,
|
|
name: DOMString,
|
|
entry_type: DOMString,
|
|
#[no_trace]
|
|
start_time: Option<CrossProcessInstant>,
|
|
/// The duration of this [`PerformanceEntry`]. This is a [`time_03::Duration`],
|
|
/// because it can be negative and `std::time::Duration` cannot be.
|
|
#[no_trace]
|
|
#[ignore_malloc_size_of = "No MallocSizeOf support for `time` crate"]
|
|
duration: Duration,
|
|
}
|
|
|
|
impl PerformanceEntry {
|
|
pub fn new_inherited(
|
|
name: DOMString,
|
|
entry_type: DOMString,
|
|
start_time: Option<CrossProcessInstant>,
|
|
duration: Duration,
|
|
) -> PerformanceEntry {
|
|
PerformanceEntry {
|
|
reflector_: Reflector::new(),
|
|
name,
|
|
entry_type,
|
|
start_time,
|
|
duration,
|
|
}
|
|
}
|
|
|
|
#[allow(crown::unrooted_must_root)]
|
|
pub fn new(
|
|
global: &GlobalScope,
|
|
name: DOMString,
|
|
entry_type: DOMString,
|
|
start_time: CrossProcessInstant,
|
|
duration: Duration,
|
|
) -> DomRoot<PerformanceEntry> {
|
|
let entry = PerformanceEntry::new_inherited(name, entry_type, Some(start_time), duration);
|
|
reflect_dom_object(Box::new(entry), global)
|
|
}
|
|
|
|
pub fn entry_type(&self) -> &DOMString {
|
|
&self.entry_type
|
|
}
|
|
|
|
pub fn name(&self) -> &DOMString {
|
|
&self.name
|
|
}
|
|
|
|
pub fn start_time(&self) -> Option<CrossProcessInstant> {
|
|
self.start_time
|
|
}
|
|
|
|
pub fn duration(&self) -> Duration {
|
|
self.duration
|
|
}
|
|
}
|
|
|
|
impl PerformanceEntryMethods for PerformanceEntry {
|
|
// https://w3c.github.io/performance-timeline/#dom-performanceentry-name
|
|
fn Name(&self) -> DOMString {
|
|
self.name.clone()
|
|
}
|
|
|
|
// https://w3c.github.io/performance-timeline/#dom-performanceentry-entrytype
|
|
fn EntryType(&self) -> DOMString {
|
|
self.entry_type.clone()
|
|
}
|
|
|
|
// https://w3c.github.io/performance-timeline/#dom-performanceentry-starttime
|
|
fn StartTime(&self) -> DOMHighResTimeStamp {
|
|
self.global()
|
|
.performance()
|
|
.maybe_to_dom_high_res_time_stamp(self.start_time)
|
|
}
|
|
|
|
// https://w3c.github.io/performance-timeline/#dom-performanceentry-duration
|
|
fn Duration(&self) -> DOMHighResTimeStamp {
|
|
self.duration.to_dom_high_res_time_stamp()
|
|
}
|
|
}
|