mirror of
https://github.com/servo/servo.git
synced 2025-08-05 13:40:08 +01:00
32f781234a
The TextInput::assert_ok_selection() method is meant to ensure that we are not getting into a state where a selection refers to a location in the control's contents which doesn't exist. However, before this change we could have a situation where the internals of the TextInput are changed by another part of the code, without using its public API. This could lead to us having an invalid selection. I did manage to trigger such a situation (see the test added in this commit) although it is quite contrived. There may be others that I didn't think of, and it's also possible that future changes could introduce new cases. (Including ones which trigger panics, if indexing is used on the assumption that the selection indices are always valid.) The current HTML specification doesn't explicitly say that selectionStart/End must remain within the length of the content, but that does seems to be the consensus reached in a discussion of this: https://github.com/whatwg/html/issues/2424 The test case I've added here is currently undefined in the spec which is why I've added it in tests/wpt/mozilla. |
||
|---|---|---|
| .. | ||
| Cargo.toml | ||
| headers.rs | ||
| htmlareaelement.rs | ||
| htmlimageelement.rs | ||
| lib.rs | ||
| origin.rs | ||
| size_of.rs | ||
| textinput.rs | ||