mirror of
https://github.com/servo/servo.git
synced 2025-06-06 16:45:39 +00:00
3af774bd75
The style candidate cache had regressed a few times (see #12534), and my intuition is that being able to disable all style sharing with a single rule in the page is really unfortunate. This commit redesigns the style sharing cache in order to be a optimistic cache, but then reject candidates if they match different sibling-affecting selectors in the page, for example. So far the numbers have improved, but not so much as I'd wanted (~10%/20% of non-incremental restyling time in general). The current implementation is really dumb though (we recompute and re-match a lot of stuff), so we should be able to optimise it quite a bit. I have different ideas for improving it (that may or may not work), apart of the low-hanging fruit like don't re-matching candidates all the time but I have to measure the real impact. Also, I need to verify it against try.
98 lines
3.3 KiB
Rust
98 lines
3.3 KiB
Rust
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
//! The context within which style is calculated.
|
|
|
|
use animation::Animation;
|
|
use app_units::Au;
|
|
use dom::OpaqueNode;
|
|
use dom::TElement;
|
|
use error_reporting::ParseErrorReporter;
|
|
use euclid::Size2D;
|
|
use matching::{ApplicableDeclarationsCache, StyleSharingCandidateCache};
|
|
use selector_matching::Stylist;
|
|
use std::cell::RefCell;
|
|
use std::collections::HashMap;
|
|
use std::sync::mpsc::Sender;
|
|
use std::sync::{Arc, Mutex, RwLock};
|
|
use timer::Timer;
|
|
|
|
/// This structure is used to create a local style context from a shared one.
|
|
pub struct LocalStyleContextCreationInfo {
|
|
new_animations_sender: Sender<Animation>,
|
|
}
|
|
|
|
impl LocalStyleContextCreationInfo {
|
|
pub fn new(animations_sender: Sender<Animation>) -> Self {
|
|
LocalStyleContextCreationInfo {
|
|
new_animations_sender: animations_sender,
|
|
}
|
|
}
|
|
}
|
|
|
|
pub struct SharedStyleContext {
|
|
/// The current viewport size.
|
|
pub viewport_size: Size2D<Au>,
|
|
|
|
/// Screen sized changed?
|
|
pub screen_size_changed: bool,
|
|
|
|
/// The CSS selector stylist.
|
|
pub stylist: Arc<Stylist>,
|
|
|
|
/// Starts at zero, and increased by one every time a layout completes.
|
|
/// This can be used to easily check for invalid stale data.
|
|
pub generation: u32,
|
|
|
|
/// Why is this reflow occurring
|
|
pub goal: ReflowGoal,
|
|
|
|
/// The animations that are currently running.
|
|
pub running_animations: Arc<RwLock<HashMap<OpaqueNode, Vec<Animation>>>>,
|
|
|
|
/// The list of animations that have expired since the last style recalculation.
|
|
pub expired_animations: Arc<RwLock<HashMap<OpaqueNode, Vec<Animation>>>>,
|
|
|
|
///The CSS error reporter for all CSS loaded in this layout thread
|
|
pub error_reporter: Box<ParseErrorReporter + Sync>,
|
|
|
|
/// Data needed to create the local style context from the shared one.
|
|
pub local_context_creation_data: Mutex<LocalStyleContextCreationInfo>,
|
|
|
|
/// The current timer for transitions and animations. This is needed to test
|
|
/// them.
|
|
pub timer: Timer,
|
|
}
|
|
|
|
pub struct LocalStyleContext {
|
|
pub applicable_declarations_cache: RefCell<ApplicableDeclarationsCache>,
|
|
pub style_sharing_candidate_cache: RefCell<StyleSharingCandidateCache>,
|
|
/// A channel on which new animations that have been triggered by style
|
|
/// recalculation can be sent.
|
|
pub new_animations_sender: Sender<Animation>,
|
|
}
|
|
|
|
impl LocalStyleContext {
|
|
pub fn new(local_context_creation_data: &LocalStyleContextCreationInfo) -> Self {
|
|
LocalStyleContext {
|
|
applicable_declarations_cache: RefCell::new(ApplicableDeclarationsCache::new()),
|
|
style_sharing_candidate_cache: RefCell::new(StyleSharingCandidateCache::new()),
|
|
new_animations_sender: local_context_creation_data.new_animations_sender.clone(),
|
|
}
|
|
}
|
|
}
|
|
|
|
pub trait StyleContext<'a> {
|
|
fn shared_context(&self) -> &'a SharedStyleContext;
|
|
fn local_context(&self) -> &LocalStyleContext;
|
|
}
|
|
|
|
/// Why we're doing reflow.
|
|
#[derive(PartialEq, Copy, Clone, Debug)]
|
|
pub enum ReflowGoal {
|
|
/// We're reflowing in order to send a display list to the screen.
|
|
ForDisplay,
|
|
/// We're reflowing in order to satisfy a script query. No display list will be created.
|
|
ForScriptQuery,
|
|
}
|