mirror of
https://github.com/servo/servo.git
synced 2025-06-06 16:45:39 +00:00
The style candidate cache had regressed a few times (see #12534), and my intuition is that being able to disable all style sharing with a single rule in the page is really unfortunate. This commit redesigns the style sharing cache in order to be a optimistic cache, but then reject candidates if they match different sibling-affecting selectors in the page, for example. So far the numbers have improved, but not so much as I'd wanted (~10%/20% of non-incremental restyling time in general). The current implementation is really dumb though (we recompute and re-match a lot of stuff), so we should be able to optimise it quite a bit. I have different ideas for improving it (that may or may not work), apart of the low-hanging fruit like don't re-matching candidates all the time but I have to measure the real impact. Also, I need to verify it against try.
179 lines
6.2 KiB
Rust
179 lines
6.2 KiB
Rust
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
//! Implements parallel traversal over the DOM tree.
|
|
//!
|
|
//! This code is highly unsafe. Keep this file small and easy to audit.
|
|
|
|
#![allow(unsafe_code)]
|
|
|
|
use dom::{OpaqueNode, TNode, UnsafeNode};
|
|
use std::mem;
|
|
use std::sync::atomic::Ordering;
|
|
use traversal::{RestyleResult, DomTraversalContext};
|
|
use traversal::{STYLE_SHARING_CACHE_HITS, STYLE_SHARING_CACHE_MISSES};
|
|
use util::opts;
|
|
use workqueue::{WorkQueue, WorkUnit, WorkerProxy};
|
|
|
|
#[allow(dead_code)]
|
|
fn static_assertion(node: UnsafeNode) {
|
|
unsafe {
|
|
let _: UnsafeNodeList = mem::transmute(node);
|
|
}
|
|
}
|
|
|
|
pub type UnsafeNodeList = (Box<Vec<UnsafeNode>>, OpaqueNode);
|
|
|
|
pub const CHUNK_SIZE: usize = 64;
|
|
|
|
pub struct WorkQueueData(usize, usize);
|
|
|
|
pub fn run_queue_with_custom_work_data_type<To, F, SharedContext: Sync>(
|
|
queue: &mut WorkQueue<SharedContext, WorkQueueData>,
|
|
callback: F,
|
|
shared: &SharedContext)
|
|
where To: 'static + Send, F: FnOnce(&mut WorkQueue<SharedContext, To>) {
|
|
let queue: &mut WorkQueue<SharedContext, To> = unsafe {
|
|
mem::transmute(queue)
|
|
};
|
|
callback(queue);
|
|
queue.run(shared);
|
|
}
|
|
|
|
pub fn traverse_dom<N, C>(root: N,
|
|
queue_data: &C::SharedContext,
|
|
queue: &mut WorkQueue<C::SharedContext, WorkQueueData>)
|
|
where N: TNode,
|
|
C: DomTraversalContext<N>
|
|
{
|
|
if opts::get().style_sharing_stats {
|
|
STYLE_SHARING_CACHE_HITS.store(0, Ordering::SeqCst);
|
|
STYLE_SHARING_CACHE_MISSES.store(0, Ordering::SeqCst);
|
|
}
|
|
run_queue_with_custom_work_data_type(queue, |queue| {
|
|
queue.push(WorkUnit {
|
|
fun: top_down_dom::<N, C>,
|
|
data: (Box::new(vec![root.to_unsafe()]), root.opaque()),
|
|
});
|
|
}, queue_data);
|
|
|
|
if opts::get().style_sharing_stats {
|
|
let hits = STYLE_SHARING_CACHE_HITS.load(Ordering::SeqCst);
|
|
let misses = STYLE_SHARING_CACHE_MISSES.load(Ordering::SeqCst);
|
|
|
|
println!("Style sharing stats:");
|
|
println!(" * Hits: {}", hits);
|
|
println!(" * Misses: {}", misses);
|
|
}
|
|
}
|
|
|
|
/// A parallel top-down DOM traversal.
|
|
#[inline(always)]
|
|
fn top_down_dom<N, C>(unsafe_nodes: UnsafeNodeList,
|
|
proxy: &mut WorkerProxy<C::SharedContext, UnsafeNodeList>)
|
|
where N: TNode, C: DomTraversalContext<N> {
|
|
let context = C::new(proxy.user_data(), unsafe_nodes.1);
|
|
|
|
let mut discovered_child_nodes = vec![];
|
|
for unsafe_node in *unsafe_nodes.0 {
|
|
// Get a real layout node.
|
|
let node = unsafe { N::from_unsafe(&unsafe_node) };
|
|
|
|
if !context.should_process(node) {
|
|
continue;
|
|
}
|
|
|
|
// Possibly enqueue the children.
|
|
let mut children_to_process = 0isize;
|
|
// Perform the appropriate traversal.
|
|
if let RestyleResult::Continue = context.process_preorder(node) {
|
|
for kid in node.children() {
|
|
// Trigger the hook pre-adding the kid to the list. This can
|
|
// (and in fact uses to) change the result of the should_process
|
|
// operation.
|
|
//
|
|
// As of right now, this hook takes care of propagating the
|
|
// restyle flag down the tree. In the future, more accurate
|
|
// behavior is probably going to be needed.
|
|
context.pre_process_child_hook(node, kid);
|
|
if context.should_process(kid) {
|
|
children_to_process += 1;
|
|
discovered_child_nodes.push(kid.to_unsafe())
|
|
}
|
|
}
|
|
}
|
|
|
|
// Reset the count of children if we need to do a bottom-up traversal
|
|
// after the top up.
|
|
if context.needs_postorder_traversal() {
|
|
node.mutate_data().unwrap()
|
|
.parallel.children_to_process
|
|
.store(children_to_process,
|
|
Ordering::Relaxed);
|
|
|
|
// If there were no more children, start walking back up.
|
|
if children_to_process == 0 {
|
|
bottom_up_dom::<N, C>(unsafe_nodes.1, unsafe_node, proxy)
|
|
}
|
|
}
|
|
}
|
|
|
|
// NB: In parallel traversal mode we have to purge the LRU cache in order to
|
|
// be able to access it without races.
|
|
context.local_context().style_sharing_candidate_cache.borrow_mut().clear();
|
|
|
|
for chunk in discovered_child_nodes.chunks(CHUNK_SIZE) {
|
|
proxy.push(WorkUnit {
|
|
fun: top_down_dom::<N, C>,
|
|
data: (Box::new(chunk.iter().cloned().collect()), unsafe_nodes.1),
|
|
});
|
|
}
|
|
}
|
|
|
|
/// Process current node and potentially traverse its ancestors.
|
|
///
|
|
/// If we are the last child that finished processing, recursively process
|
|
/// our parent. Else, stop. Also, stop at the root.
|
|
///
|
|
/// Thus, if we start with all the leaves of a tree, we end up traversing
|
|
/// the whole tree bottom-up because each parent will be processed exactly
|
|
/// once (by the last child that finishes processing).
|
|
///
|
|
/// The only communication between siblings is that they both
|
|
/// fetch-and-subtract the parent's children count.
|
|
fn bottom_up_dom<N, C>(root: OpaqueNode,
|
|
unsafe_node: UnsafeNode,
|
|
proxy: &mut WorkerProxy<C::SharedContext, UnsafeNodeList>)
|
|
where N: TNode,
|
|
C: DomTraversalContext<N>
|
|
{
|
|
let context = C::new(proxy.user_data(), root);
|
|
|
|
// Get a real layout node.
|
|
let mut node = unsafe { N::from_unsafe(&unsafe_node) };
|
|
loop {
|
|
// Perform the appropriate operation.
|
|
context.process_postorder(node);
|
|
|
|
let parent = match node.layout_parent_node(root) {
|
|
None => break,
|
|
Some(parent) => parent,
|
|
};
|
|
|
|
let parent_data = unsafe {
|
|
&*parent.borrow_data_unchecked().unwrap()
|
|
};
|
|
|
|
if parent_data
|
|
.parallel
|
|
.children_to_process
|
|
.fetch_sub(1, Ordering::Relaxed) != 1 {
|
|
// Get out of here and find another node to work on.
|
|
break
|
|
}
|
|
|
|
// We were the last child of our parent. Construct flows for our parent.
|
|
node = parent;
|
|
}
|
|
}
|