Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-14 11:24:33 +00:00
Code Issues Projects Releases Packages Wiki Activity
servo/python
History
bors-servo 3e77a0ae09
Auto merge of #25354 - lberrymage:dom-domroot-lint-check, r=jdm 
Add &DomRoot<T> lint check

So far, the lint check code appears to work as intended. However, some trait implementations require modification to pass the lint check and I'm not sure how to fix these. Commit 92cf5d5 attempts to correct one of the implementations, but fails to compile with error:
```
  --> components/script/dom/servoparser/xml.rs:76:36
   |
76 |         tree_builder.trace_handles(&tracer);
   |                                    ^^^^^^^ expected struct `dom::bindings::root::Dom`, found struct `dom::node::Node`
   |
   = note: expected struct `dom::bindings::root::Dom<dom::node::Node>`
              found struct `dom::node::Node`
   = note: required for the cast to the object type `dyn html5ever::tree_builder::Tracer<Handle = dom::bindings::root::Dom<dom::node::Node>>`
```
I've tried to debug further but to no avail. I also don't want to mangle too much existing code unnecessarily. Any help is appreciated.

<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
`./mach test-tidy --all` does, and some are directly related to this PR
- [ ] These changes fix #25342
The fix is a WIP

<!-- Either: -->
- [X] There are tests for these changes

Note that I will clean up the commit history before the final PR.
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-12-21 18:23:26 -05:00
..
servo Print OSMesa environment variables when starting debugger under WPT. 2019-12-20 11:25:19 -05:00
tidy Add lint check for &DomRoot<T> 2019-12-21 12:44:35 -09:00
mach_bootstrap.py Write subprocess stdout/stderr logs to raw stdout buffer when using Python3 2019-12-10 16:11:02 +00:00
README.md Fix styling for Markdown headers. 2016-05-02 22:20:49 -04:00
requirements-salt.txt Add a Salt bootstrapper 2017-01-17 11:01:09 -05:00
requirements.txt Update mach to version 1.0.0 2019-12-09 19:31:46 +00:00
tox.ini Added tox.ini 2016-05-08 12:10:48 +02:00

README.md

This directory contains various Python modules used to support servo development.

servo

servo-specific python code e.g. implementations of mach commands. This is the canonical repository for this code.

tidy

servo-tidy is used to check licenses, line lengths, whitespace, flake8 on Python files, lock file versions, and more.