mirror of
https://github.com/servo/servo.git
synced 2025-10-04 10:39:16 +01:00
4625160f0a
Update document.open to latest spec <!-- Please describe your changes on the following line: --> This is one of my first contributions, so I might need some direction cleaning it up -- I ran web-platform-tests locally, but the suite has several intermittent passes/failures for me. Thanks! Few notes: * I may have been wrong to eliminate all of the resets listed in what was formerly Step 18 (starts with `self.implementation.set(None);`). It's not clear to me that they're still needed or if so, what step they would fall under, but I didn't notice any web platform tests break as a result. * <s>If I'm reading the spec right, there's a discrepancy in the error returned by the three-parameter overload of Document.open between the spec and web-platform-tests/implementations in other browsers. As written, I favored the spec, but it causes one web-platform-test to fail.</s> This has been resolved in https://github.com/whatwg/html/pull/4066 * I'm not 100% certain that tests pass as expected, I had several intermittent failures that disappeared when re-run. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #21445 <!-- Either: --> - [x] There are tests for these changes (existing web-platform-tests) <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21882) <!-- Reviewable:end --> |
||
|---|---|---|
| .. | ||
| dromaeo | ||
| heartbeats | ||
| html | ||
| jquery | ||
| power | ||
| unit | ||
| wpt | ||
