mirror of
https://github.com/servo/servo.git
synced 2025-06-08 08:33:26 +00:00
47c269360c
At first I was considering moving it to a procedural macro
(source-level information should be sufficient),
and started by trying to reproduce the error case
by changing `htmldivelement.rs` to use `Element` instead of `HTMLElement`
as the first field.
The output was:
```rust
error[E0308]: mismatched types
--> /home/simon/servo2/target/debug/build/script-4caa244faca7d10f/out/Bindings/HTMLDivElementBinding.rs:665:31
|
665 | let _: &HTMLElement = self.as_parent();
| ^^^^^^^^^^^^^^^^ expected struct `dom::htmlelement::HTMLElement`, found struct `dom::element::Element`
|
= note: expected type `&dom::htmlelement::HTMLElement`
found type `&dom::element::Element`
```
This line number is inside a generated method called `__assert_parent_type`.
As far as I can tell, any case where this lint would error is already caught
by such methods. The lint is therefore redundant and can safely be removed.
90 lines
2.4 KiB
Rust
90 lines
2.4 KiB
Rust
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */
|
|
|
|
//! Servo's compiler plugin/macro crate
|
|
//!
|
|
//! Attributes this crate provides:
|
|
//!
|
|
//! - `#[derive(DenyPublicFields)]` : Forces all fields in a struct/enum to be private
|
|
//! - `#[derive(JSTraceable)]` : Auto-derives an implementation of `JSTraceable` for a struct in the script crate
|
|
//! - `#[must_root]` : Prevents data of the marked type from being used on the stack.
|
|
//! See the lints module for more details
|
|
//! - `#[dom_struct]` : Implies #[derive(JSTraceable, DenyPublicFields)]`, and `#[must_root]`.
|
|
//! Use this for structs that correspond to a DOM type
|
|
|
|
#![deny(unsafe_code)]
|
|
#![feature(plugin)]
|
|
#![feature(plugin_registrar)]
|
|
#![feature(rustc_private)]
|
|
|
|
#[cfg(feature = "unrooted_must_root_lint")]
|
|
#[macro_use]
|
|
extern crate rustc;
|
|
extern crate rustc_driver;
|
|
extern crate syntax;
|
|
|
|
use rustc_driver::plugin::Registry;
|
|
use syntax::feature_gate::AttributeType::Whitelisted;
|
|
use syntax::symbol::Symbol;
|
|
|
|
#[cfg(feature = "unrooted_must_root_lint")]
|
|
mod unrooted_must_root;
|
|
|
|
/// Utilities for writing plugins
|
|
#[cfg(feature = "unrooted_must_root_lint")]
|
|
mod utils;
|
|
|
|
#[plugin_registrar]
|
|
pub fn plugin_registrar(reg: &mut Registry) {
|
|
let symbols = crate::Symbols::new();
|
|
|
|
#[cfg(feature = "unrooted_must_root_lint")]
|
|
reg.register_late_lint_pass(Box::new(unrooted_must_root::UnrootedPass::new(
|
|
symbols.clone(),
|
|
)));
|
|
|
|
reg.register_attribute(symbols.allow_unrooted_interior, Whitelisted);
|
|
reg.register_attribute(symbols.allow_unrooted_in_rc, Whitelisted);
|
|
reg.register_attribute(symbols.must_root, Whitelisted);
|
|
}
|
|
|
|
macro_rules! symbols {
|
|
($($s: ident)+) => {
|
|
#[derive(Clone)]
|
|
#[allow(non_snake_case)]
|
|
struct Symbols {
|
|
$( $s: Symbol, )+
|
|
}
|
|
|
|
impl Symbols {
|
|
fn new() -> Self {
|
|
Symbols {
|
|
$( $s: Symbol::intern(stringify!($s)), )+
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
symbols! {
|
|
allow_unrooted_interior
|
|
allow_unrooted_in_rc
|
|
must_root
|
|
alloc
|
|
rc
|
|
Rc
|
|
cell
|
|
Ref
|
|
RefMut
|
|
slice
|
|
Iter
|
|
IterMut
|
|
collections
|
|
hash
|
|
map
|
|
set
|
|
Entry
|
|
OccupiedEntry
|
|
VacantEntry
|
|
}
|