servo/components/constellation
Martin Robinson c0970ea655
compositor: Wait for both Script and the Constellation when shutting down Pipelines (#37505)
Previously, the Constellation would immediately ask the Compositor to
shut down a pipeline, even before the ScriptThread finished shutting it
down. This meant that the Compositor might remove a Pipeline and then
re-add it if the ScriptThread sent a Pipeline-related message (such as a
new display list) in the meantime.

This change makes it so that the Compositor waits for both the
Constellation and the ScriptThread to finish shutting down a Pipeline
before removing its data. In addition, the Constellation no longer
synchronously waits on the Compositor when shutting down Pipelines. This
was important when the Compositor would talk to the ScriptThread
directly, but isn't necessary any longer.

Testing: This is very hard to test, because it depends on the creation
and destruction of many iframes and the particular timing of of all
the messaging between Servo bits. That said, this was tested manually
by observing the completion of Speedometer 2.1.
Fixes: #37458.

Signed-off-by: Martin Robinson <mrobinson@igalia.com>
Co-authored-by: Oriol Brufau <obrufau@igalia.com>
2025-06-17 09:56:31 +00:00
..
browsingcontext.rs constellation: Stop assuming that the viewport is shared by all WebViews (#36312) 2025-04-04 17:06:34 +00:00
Cargo.toml libservo: Remove the unused multiview feature (#36485) 2025-04-14 07:46:07 +00:00
constellation.rs compositor: Wait for both Script and the Constellation when shutting down Pipelines (#37505) 2025-06-17 09:56:31 +00:00
constellation_webview.rs constellation: Pass system theme to new Pipelines (#37132) 2025-05-26 12:05:38 +00:00
event_loop.rs compositor: Tick animations for an entire WebView at once (#36662) 2025-04-24 19:03:14 +00:00
lib.rs constellation: Pass system theme to new Pipelines (#37132) 2025-05-26 12:05:38 +00:00
logging.rs Move ScriptToConstellationMsg to constellation_traits (#36364) 2025-04-05 22:13:29 +00:00
pipeline.rs compositor: Wait for both Script and the Constellation when shutting down Pipelines (#37505) 2025-06-17 09:56:31 +00:00
process_manager.rs Make the memory reporting multi-process aware (#35863) 2025-04-05 05:42:12 +00:00
sandboxing.rs constellation: Ignore zombie_process warning (#36904) 2025-05-07 19:37:27 +00:00
serviceworker.rs Move ScriptToConstellationMsg to constellation_traits (#36364) 2025-04-05 22:13:29 +00:00
session_history.rs Move ScriptToConstellationMsg to constellation_traits (#36364) 2025-04-05 22:13:29 +00:00
tracing.rs Constellation can now optionally report memory usage when the page is loaded. (#37151) 2025-05-30 17:15:06 +00:00
webview_manager.rs Reduce indexing boilerplate for serializable/transferrable objects. (#36624) 2025-04-22 02:02:02 +00:00