servo/components/script/dom
bors-servo 6111cf9ffc Auto merge of #7943 - pierrechevalier83:fix_issue_7941, r=Ms2ger
Clarify some code in do_create_interface_objects

rval.get() is believed to be always null upon entering this function.
This assumption is verified by the added assertion.
It makes more sense to move the block of code that was moved inside
the if statement which is the only place where it can be initialized.

Fixes #7941.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7943)
<!-- Reviewable:end -->
2015-10-19 09:37:03 -06:00
..
bindings Auto merge of #7943 - pierrechevalier83:fix_issue_7941, r=Ms2ger 2015-10-19 09:37:03 -06:00
webidls Implementing getAttributeNode() and similar methods. 2015-10-19 16:14:43 +05:30
activation.rs Fix reported test-tidy errors for unmerged import blocks 2015-09-19 12:50:14 -04:00
attr.rs Fix remaining MutHeap methods not to expose JS<T>. 2015-10-15 14:03:57 -07:00
blob.rs Generate all Derived implementations in codegen 2015-10-14 22:04:20 +02:00
browsercontext.rs Return a reference in BrowserContext::active_window() 2015-10-19 09:36:53 +02:00
canvasgradient.rs Refactor Error enum usage to consistently be qualified 2015-10-06 05:43:52 -04:00
canvaspattern.rs sorted the extern crate, mod & use declarations 2015-09-24 02:12:45 +05:30
canvasrenderingcontext2d.rs Stop implementing Copy for JS<T>. 2015-10-15 14:02:45 -07:00
characterdata.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
closeevent.rs Generate the TypeId enums in codegen 2015-10-14 18:45:35 +02:00
comment.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
console.rs sorted the extern crate, mod & use declarations 2015-09-24 02:12:45 +05:30
create.rs Add 'listing' alias for <pre> elements 2015-10-10 08:58:38 -04:00
crypto.rs sorted the extern crate, mod & use declarations 2015-09-24 02:12:45 +05:30
css.rs Fix reported test-tidy errors for unmerged import blocks 2015-09-19 12:50:14 -04:00
cssstyledeclaration.rs Use util::str::str_join in more places 2015-09-28 19:57:06 -04:00
customevent.rs Auto merge of #8020 - nox:codegen-derived, r=Ms2ger 2015-10-15 12:53:08 -06:00
dedicatedworkerglobalscope.rs Generate all Derived implementations in codegen 2015-10-14 22:04:20 +02:00
document.rs Auto merge of #8060 - nox:deref-js, r=Ms2ger 2015-10-19 06:32:05 -06:00
documentfragment.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
documenttype.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
domexception.rs Add better stringifier for DOMException 2015-09-24 11:58:28 +05:30
domimplementation.rs Do not root DOMImplementation::document 2015-10-19 09:36:54 +02:00
domparser.rs Do not root DOMParser::window 2015-10-19 09:36:55 +02:00
dompoint.rs Make the traits for the IDL interfaces take &self 2015-08-27 22:27:43 +02:00
dompointreadonly.rs Make the traits for the IDL interfaces take &self 2015-08-27 22:27:43 +02:00
domrect.rs Improve implementation of DOMRect and implement DOMRectReadOnly 2015-10-17 22:47:01 +02:00
domrectlist.rs Make the traits for the IDL interfaces take &self 2015-08-27 22:27:43 +02:00
domrectreadonly.rs Improve implementation of DOMRect and implement DOMRectReadOnly 2015-10-17 22:47:01 +02:00
domstringmap.rs Do not root DOMStringMap::element 2015-10-19 09:36:56 +02:00
domtokenlist.rs Do not root DOMTokenList::element 2015-10-19 09:36:57 +02:00
element.rs Auto merge of #8068 - martiansideofthemoon:my-code-fix, r=Manishearth 2015-10-19 07:58:41 -06:00
errorevent.rs Auto merge of #8020 - nox:codegen-derived, r=Ms2ger 2015-10-15 12:53:08 -06:00
event.rs Make get() and set() on MutNullableHeap use the correct types. 2015-10-15 14:03:56 -07:00
eventdispatcher.rs sorted the extern crate, mod & use declarations 2015-09-24 02:12:45 +05:30
eventtarget.rs Support the updated spidermonkey bindings 2015-10-14 15:30:52 -04:00
file.rs Generate the TypeId enums in codegen 2015-10-14 18:45:35 +02:00
filelist.rs Make the traits for the IDL interfaces take &self 2015-08-27 22:27:43 +02:00
filereader.rs Make get() and set() on MutNullableHeap use the correct types. 2015-10-15 14:03:56 -07:00
formdata.rs sorted the extern crate, mod & use declarations 2015-09-24 02:12:45 +05:30
htmlanchorelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmlappletelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmlareaelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmlaudioelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmlbaseelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmlbodyelement.rs Adding window.onstorage EventHandler 2015-10-16 02:37:27 +05:30
htmlbrelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmlbuttonelement.rs Move Event States to |Element|. 2015-10-16 17:56:31 -07:00
htmlcanvaselement.rs Don't use MutNullableHeap in HTMLCanvasElement. 2015-10-15 14:03:55 -07:00
htmlcollection.rs Implement deleteRow and insertRow for <table> element 2015-10-11 09:47:46 -04:00
htmldataelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmldatalistelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmldialogelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmldirectoryelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmldivelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmldlistelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmlelement.rs Move Event States to |Element|. 2015-10-16 17:56:31 -07:00
htmlembedelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmlfieldsetelement.rs Move Event States to |Element|. 2015-10-16 17:56:31 -07:00
htmlfontelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmlformelement.rs Move Event States to |Element|. 2015-10-16 17:56:31 -07:00
htmlframeelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmlframesetelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmlheadelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmlheadingelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmlhrelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmlhtmlelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmliframeelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmlimageelement.rs Return a reference in Document::window() 2015-10-19 09:36:52 +02:00
htmlinputelement.rs Auto merge of #8060 - nox:deref-js, r=Ms2ger 2015-10-19 06:32:05 -06:00
htmllabelelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmllegendelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmllielement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmllinkelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmlmapelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmlmediaelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmlmetaelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmlmeterelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmlmodelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmlobjectelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmlolistelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmloptgroupelement.rs Move Event States to |Element|. 2015-10-16 17:56:31 -07:00
htmloptionelement.rs Move Event States to |Element|. 2015-10-16 17:56:31 -07:00
htmloutputelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmlparagraphelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmlparamelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmlpreelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmlprogresselement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmlquoteelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmlscriptelement.rs Do not root HTMLScriptElement::parser_document 2015-10-19 09:37:00 +02:00
htmlselectelement.rs Move Event States to |Element|. 2015-10-16 17:56:31 -07:00
htmlsourceelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmlspanelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmlstyleelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmltablecaptionelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmltablecellelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmltablecolelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmltabledatacellelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmltableelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmltableheadercellelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmltablerowelement.rs Implement HTMLTableRowElement insertCell and deleteCell 2015-10-17 00:07:22 -04:00
htmltablesectionelement.rs Implement HTMLTableRowElement insertCell and deleteCell 2015-10-17 00:07:22 -04:00
htmltemplateelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmltextareaelement.rs Auto merge of #8060 - nox:deref-js, r=Ms2ger 2015-10-19 06:32:05 -06:00
htmltimeelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmltitleelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmltrackelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmlulistelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmlunknownelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
htmlvideoelement.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
imagedata.rs sorted the extern crate, mod & use declarations 2015-09-24 02:12:45 +05:30
keyboardevent.rs Generate all Derived implementations in codegen 2015-10-14 22:04:20 +02:00
location.rs Do not root Location::window 2015-10-19 09:37:01 +02:00
macros.rs Consolidate magic number representing max unsigned long 2015-10-10 13:46:11 -04:00
messageevent.rs Auto merge of #8020 - nox:codegen-derived, r=Ms2ger 2015-10-15 12:53:08 -06:00
mod.rs Improve implementation of DOMRect and implement DOMRectReadOnly 2015-10-17 22:47:01 +02:00
mouseevent.rs Make get() and set() on MutNullableHeap use the correct types. 2015-10-15 14:03:56 -07:00
namednodemap.rs Do not root NamedNodeMap::owner 2015-10-19 09:37:02 +02:00
navigator.rs Make the traits for the IDL interfaces take &self 2015-08-27 22:27:43 +02:00
navigatorinfo.rs implement navigator.platform 2015-09-29 08:14:30 +02:00
node.rs Auto merge of #8060 - nox:deref-js, r=Ms2ger 2015-10-19 06:32:05 -06:00
nodeiterator.rs Do not root NodeIterator::root_node 2015-10-19 09:37:03 +02:00
nodelist.rs Do not root ChildrenList::node 2015-10-19 09:37:04 +02:00
performance.rs Do not root Performance::timing 2015-10-19 09:37:05 +02:00
performancetiming.rs Make the traits for the IDL interfaces take &self 2015-08-27 22:27:43 +02:00
processinginstruction.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
progressevent.rs Generate all Derived implementations in codegen 2015-10-14 22:04:20 +02:00
range.rs Return a reference in Document::window() 2015-10-19 09:36:52 +02:00
screen.rs Make the traits for the IDL interfaces take &self 2015-08-27 22:27:43 +02:00
servohtmlparser.rs Return a reference in ServoHTMLParser::window() 2015-10-19 09:37:08 +02:00
storage.rs Implement a quota of 5MB per origin for localstorage and sessionstorage 2015-10-09 03:55:27 +08:00
storageevent.rs Fix remaining MutHeap methods not to expose JS<T>. 2015-10-15 14:03:57 -07:00
testbinding.rs sorted the extern crate, mod & use declarations 2015-09-24 02:12:45 +05:30
testbindingproxy.rs Remove deprecated 'creator' WebIDL attribute 2015-09-21 07:12:17 -04:00
text.rs Explicitly customise flags of new nodes where needed 2015-10-15 17:30:41 +02:00
textdecoder.rs sorted the extern crate, mod & use declarations 2015-09-24 02:12:45 +05:30
textencoder.rs Refactor Error enum usage to consistently be qualified 2015-10-06 05:43:52 -04:00
treewalker.rs Return a reference in Document::window() 2015-10-19 09:36:52 +02:00
uievent.rs Make get() and set() on MutNullableHeap use the correct types. 2015-10-15 14:03:56 -07:00
url.rs Fix reported test-tidy errors for unmerged import blocks 2015-09-19 12:50:14 -04:00
urlhelper.rs sorted the extern crate, mod & use declarations 2015-09-24 02:12:45 +05:30
urlsearchparams.rs sorted the extern crate, mod & use declarations 2015-09-24 02:12:45 +05:30
userscripts.rs Remove AttributeHandlers 2015-08-27 16:59:04 +02:00
validitystate.rs Link to the HTML multipage spec, not the single-page one. 2015-10-13 11:48:51 -07:00
values.rs Consolidate magic number representing max unsigned long 2015-10-10 13:46:11 -04:00
virtualmethods.rs Generate the TypeId enums in codegen 2015-10-14 18:45:35 +02:00
webglactiveinfo.rs Make the traits for the IDL interfaces take &self 2015-08-27 22:27:43 +02:00
webglbuffer.rs Fix reported test-tidy errors for unmerged import blocks 2015-09-19 12:50:14 -04:00
webglcontextevent.rs Generate all Derived implementations in codegen 2015-10-14 22:04:20 +02:00
webglframebuffer.rs Fix reported test-tidy errors for unmerged import blocks 2015-09-19 12:50:14 -04:00
webglobject.rs make dom_struct derive HeapSizeOf, 2015-08-27 01:17:48 +01:00
webglprogram.rs Make get() and set() on MutNullableHeap use the correct types. 2015-10-15 14:03:56 -07:00
webglrenderbuffer.rs Fix reported test-tidy errors for unmerged import blocks 2015-09-19 12:50:14 -04:00
webglrenderingcontext.rs Make get() and set() on MutNullableHeap use the correct types. 2015-10-15 14:03:56 -07:00
webglshader.rs sorted the extern crate, mod & use declarations 2015-09-24 02:12:45 +05:30
webglshaderprecisionformat.rs Make the traits for the IDL interfaces take &self 2015-08-27 22:27:43 +02:00
webgltexture.rs Fix reported test-tidy errors for unmerged import blocks 2015-09-19 12:50:14 -04:00
webgluniformlocation.rs Remove helper traits 2015-08-27 16:59:02 +02:00
websocket.rs Adds bufferedAmount to Websocket (fixes #7856). 2015-10-15 17:06:24 -05:00
window.rs Auto merge of #8060 - nox:deref-js, r=Ms2ger 2015-10-19 06:32:05 -06:00
worker.rs Explicitly place '/' before fragment for multipage spec links 2015-10-10 12:07:10 -04:00
workerglobalscope.rs Refactor Error enum usage to consistently be qualified 2015-10-06 05:43:52 -04:00
workerlocation.rs Fix reported test-tidy errors for unmerged import blocks 2015-09-19 12:50:14 -04:00
workernavigator.rs Make the traits for the IDL interfaces take &self 2015-08-27 22:27:43 +02:00
xmlhttprequest.rs Do not root XMLHttpRequest::upload 2015-10-19 09:37:09 +02:00
xmlhttprequesteventtarget.rs Generate all Derived implementations in codegen 2015-10-14 22:04:20 +02:00
xmlhttprequestupload.rs Generate all Derived implementations in codegen 2015-10-14 22:04:20 +02:00