mirror of
https://github.com/servo/servo.git
synced 2025-07-26 00:30:22 +01:00
Per the spec, selectionStart and selectionEnd should return the same values regardless of the selectionDirection. (That is, selectionStart is always less than or equal to selectionEnd; the direction then implies which of selectionStart or selectionEnd is the cursor position.) There was no explicit WPT test for this, so I added one. This bug was initially quite hard to wrap my head around, and I think part of the problem is the code in TextInput. Therefore, in the process of fixing it I have refactored the implementation of TextInput: * Rename selection_begin to selection_origin. This value doesn't necessarily correspond directly to the selectionStart DOM value - in the case of a backward selection, it corresponds to selectionEnd. I feel that "origin" doesn't imply a specific ordering as strongly as "begin" (or "start" for that matter) does. * In various other cases where "begin" is used as a synonym for "start", just use "start" for consistency. * Implement selection_start() and selection_end() methods (and their _offset() variants) which directly correspond to their DOM equivalents. * Rename other related methods to make them less wordy and more consistent / intention-revealing. * Add assertions to assert_ok_selection() to ensure that our assumptions about the ordering of selection_origin and edit_point are met. This then revealed a bug in adjust_selection_for_horizontal_change() where the value of selection_direction was not maintained correctly (causing a unit test failure when the new assertion failed).
159 lines
5 KiB
Rust
159 lines
5 KiB
Rust
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
use dom::bindings::cell::DomRefCell;
|
|
use dom::bindings::conversions::DerivedFrom;
|
|
use dom::bindings::error::{Error, ErrorResult};
|
|
use dom::bindings::str::DOMString;
|
|
use dom::event::{EventBubbles, EventCancelable};
|
|
use dom::eventtarget::EventTarget;
|
|
use dom::node::{Node, NodeDamage, window_from_node};
|
|
use script_traits::ScriptToConstellationChan;
|
|
use textinput::{SelectionDirection, TextInput};
|
|
|
|
pub trait TextControl: DerivedFrom<EventTarget> + DerivedFrom<Node> {
|
|
fn textinput(&self) -> &DomRefCell<TextInput<ScriptToConstellationChan>>;
|
|
fn selection_api_applies(&self) -> bool;
|
|
fn has_selectable_text(&self) -> bool;
|
|
|
|
// https://html.spec.whatwg.org/multipage/#dom-textarea/input-select
|
|
fn dom_select(&self) {
|
|
// Step 1
|
|
if !self.has_selectable_text() {
|
|
return;
|
|
}
|
|
|
|
// Step 2
|
|
self.set_selection_range(Some(0), Some(u32::max_value()), None);
|
|
}
|
|
|
|
// https://html.spec.whatwg.org/multipage/#dom-textarea/input-selectionstart
|
|
fn get_dom_selection_start(&self) -> Option<u32> {
|
|
// Step 1
|
|
if !self.selection_api_applies() {
|
|
return None;
|
|
}
|
|
|
|
// Steps 2-3
|
|
Some(self.selection_start())
|
|
}
|
|
|
|
// https://html.spec.whatwg.org/multipage/#dom-textarea/input-selectionstart
|
|
fn set_dom_selection_start(&self, start: Option<u32>) -> ErrorResult {
|
|
// Step 1
|
|
if !self.selection_api_applies() {
|
|
return Err(Error::InvalidState);
|
|
}
|
|
|
|
// Step 2
|
|
let mut end = self.selection_end();
|
|
|
|
// Step 3
|
|
if let Some(s) = start {
|
|
if end < s {
|
|
end = s;
|
|
}
|
|
}
|
|
|
|
// Step 4
|
|
self.set_selection_range(start, Some(end), Some(self.selection_direction()));
|
|
Ok(())
|
|
}
|
|
|
|
// https://html.spec.whatwg.org/multipage/#dom-textarea/input-selectionend
|
|
fn get_dom_selection_end(&self) -> Option<u32> {
|
|
// Step 1
|
|
if !self.selection_api_applies() {
|
|
return None;
|
|
}
|
|
|
|
// Steps 2-3
|
|
Some(self.selection_end())
|
|
}
|
|
|
|
// https://html.spec.whatwg.org/multipage/#dom-textarea/input-selectionend
|
|
fn set_dom_selection_end(&self, end: Option<u32>) -> ErrorResult {
|
|
// Step 1
|
|
if !self.selection_api_applies() {
|
|
return Err(Error::InvalidState);
|
|
}
|
|
|
|
// Step 2
|
|
self.set_selection_range(Some(self.selection_start()), end, Some(self.selection_direction()));
|
|
Ok(())
|
|
}
|
|
|
|
// https://html.spec.whatwg.org/multipage/#dom-textarea/input-selectiondirection
|
|
fn get_dom_selection_direction(&self) -> Option<DOMString> {
|
|
// Step 1
|
|
if !self.selection_api_applies() {
|
|
return None;
|
|
}
|
|
|
|
Some(DOMString::from(self.selection_direction()))
|
|
}
|
|
|
|
// https://html.spec.whatwg.org/multipage/#dom-textarea/input-selectiondirection
|
|
fn set_dom_selection_direction(&self, direction: Option<DOMString>) -> ErrorResult {
|
|
// Step 1
|
|
if !self.selection_api_applies() {
|
|
return Err(Error::InvalidState);
|
|
}
|
|
|
|
// Step 2
|
|
self.set_selection_range(
|
|
Some(self.selection_start()),
|
|
Some(self.selection_end()),
|
|
direction.map(|d| SelectionDirection::from(d))
|
|
);
|
|
Ok(())
|
|
}
|
|
|
|
// https://html.spec.whatwg.org/multipage/#dom-textarea/input-setselectionrange
|
|
fn set_dom_selection_range(&self, start: u32, end: u32, direction: Option<DOMString>) -> ErrorResult {
|
|
// Step 1
|
|
if !self.selection_api_applies() {
|
|
return Err(Error::InvalidState);
|
|
}
|
|
|
|
// Step 2
|
|
self.set_selection_range(Some(start), Some(end), direction.map(|d| SelectionDirection::from(d)));
|
|
Ok(())
|
|
}
|
|
|
|
fn selection_start(&self) -> u32 {
|
|
self.textinput().borrow().selection_start_offset() as u32
|
|
}
|
|
|
|
fn selection_end(&self) -> u32 {
|
|
self.textinput().borrow().selection_end_offset() as u32
|
|
}
|
|
|
|
fn selection_direction(&self) -> SelectionDirection {
|
|
self.textinput().borrow().selection_direction
|
|
}
|
|
|
|
// https://html.spec.whatwg.org/multipage/#set-the-selection-range
|
|
fn set_selection_range(&self, start: Option<u32>, end: Option<u32>, direction: Option<SelectionDirection>) {
|
|
// Step 1
|
|
let start = start.unwrap_or(0);
|
|
|
|
// Step 2
|
|
let end = end.unwrap_or(0);
|
|
|
|
// Steps 3-5
|
|
self.textinput().borrow_mut().set_selection_range(start, end, direction.unwrap_or(SelectionDirection::None));
|
|
|
|
// Step 6
|
|
let window = window_from_node(self);
|
|
let _ = window.user_interaction_task_source().queue_event(
|
|
&self.upcast::<EventTarget>(),
|
|
atom!("select"),
|
|
EventBubbles::Bubbles,
|
|
EventCancelable::NotCancelable,
|
|
&window);
|
|
|
|
self.upcast::<Node>().dirty(NodeDamage::OtherNodeDamage);
|
|
}
|
|
}
|