Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-10-09 21:10:19 +01:00
Code Issues Projects Releases Packages Wiki Activity
servo/components
History
bors-servo 0b79fe377d
Auto merge of #25552 - CYBAI:fix-25436, r=jdm 
Return the highest priority error from the descendant instead of return the very first one

The test failed because we didn't return the highest priority error (which is network error in this case).

As Manish mentioned in https://github.com/servo/servo/issues/25436#issuecomment-571065323, that's because we're using the Promise.all trick to signal loads.

If we can avoid relying on Promise.all, maybe we don't need to do a complex logic like this; instead, ideally, we should always finish the module load immediately when we hit network failure so that we don't even need to do the `max()` comparison.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #25436
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2020-01-20 08:09:20 -05:00
..
allocator Update jemalloc-sys to 0.3.2 2019-11-20 00:00:00 +00:00
atoms Handle AddInput/RemoveInput events 2020-01-09 08:16:25 +05:30
background_hang_monitor Use surfman for managing GL surfaces 2019-11-01 08:47:11 -05:00
bluetooth Fix some warnings in future Rust nightlies 2020-01-02 19:22:03 +01:00
bluetooth_traits Update ipc-channel and related dependencies 2019-08-27 23:44:04 +02:00
canvas Auto merge of #25551 - pylbrecht:raqote, r=jdm 2020-01-19 18:51:20 -05:00
canvas_traits Add support for WebGL2 uniform matrix operations 2020-01-17 11:42:45 +01:00
compositing Do not wake up embedder on each animation tick 2019-12-16 16:50:36 +01:00
config Fix HSTS 2020-01-07 16:07:12 +01:00
config_plugins Upgrade to rustc 1.42.0-nightly (3291ae339 2020-01-15) 2020-01-16 08:46:41 +01:00
constellation Only start WebGPU thread if an adapter is requested 2020-01-13 10:39:23 +01:00
debugger
deny_public_fields Upgrade to rustc 1.42.0-nightly (3291ae339 2020-01-15) 2020-01-16 08:46:41 +01:00
derive_common derive_common: Fix example in documentation 2019-11-07 18:52:30 -06:00
devtools Fix some warnings in future Rust nightlies 2020-01-02 19:22:03 +01:00
devtools_traits WorkerId changed to type UUID. 2019-12-10 13:12:54 +05:30
dom_struct Use #![register_tool] instead of #![register_attr] 2019-11-15 17:24:42 +01:00
domobject_derive Upgrade to rustc 1.42.0-nightly (3291ae339 2020-01-15) 2020-01-16 08:46:41 +01:00
embedder_traits Auto merge of #24885 - shnmorimoto:implement_mediasession_set_positon_state, r=ferjm 2019-12-03 12:13:06 -05:00
fallible style: Update smallvec to 1.0. 2019-12-16 14:23:56 +01:00
geometry Fix some warnings new in Rust Nightly 2019-11-08 11:45:16 +01:00
gfx Servo build fixes. 2019-12-16 14:23:56 +01:00
gfx_traits Replace DisplayList::is_contentful with tracking during conversion to WR display lists 2019-09-06 17:15:53 +02:00
hashglobe Fix some warnings new in Rust Nightly 2019-11-08 11:45:16 +01:00
jstraceable_derive Bump all in-tree components to syn 1 2019-09-27 13:29:55 +02:00
layout Upgrade to rustc 1.42.0-nightly (3291ae339 2020-01-15) 2020-01-16 08:46:41 +01:00
layout_2020 Auto merge of #25512 - servo:background-image, r=nox 2020-01-17 10:52:38 -05:00
layout_thread style: Fix servo build. 2019-11-30 20:45:08 +01:00
layout_thread_2020 Initial rendering of background-image 2020-01-13 21:59:46 +01:00
layout_traits Use non-IPC webrender API over explicit IPC channels. 2019-11-27 20:47:53 -05:00
malloc_size_of Add accountable-refcell as optional build time feature 2020-01-08 09:44:41 +05:30
media Use non-IPC webrender API over explicit IPC channels. 2019-11-27 20:47:53 -05:00
metrics Replace DisplayList::is_contentful with tracking during conversion to WR display lists 2019-09-06 17:15:53 +02:00
msg re-structure blob, structured serialization 2019-12-11 22:46:50 +08:00
net Auto merge of #25404 - Darkspirit:hsts, r=asajeffrey 2020-01-08 13:20:09 -05:00
net_traits Fix some warnings in future Rust nightlies 2020-01-02 19:22:03 +01:00
pixels Addresses issues raised in #24465; removes redundancy in set_bitmap_dimensions 2019-11-10 18:37:14 -05:00
profile Fix some warnings in future Rust nightlies 2020-01-02 19:22:03 +01:00
profile_traits begin messageport, transferable objects, impl 2019-10-19 14:12:22 +08:00
rand Update rand to 0.7 (fixes #24448) 2019-10-23 15:34:48 +02:00
range
remutex
script Auto merge of #25552 - CYBAI:fix-25436, r=jdm 2020-01-20 08:09:20 -05:00
script_layout_interface Use non-IPC webrender API over explicit IPC channels. 2019-11-27 20:47:53 -05:00
script_plugins Upgrade to rustc 1.42.0-nightly (3291ae339 2020-01-15) 2020-01-16 08:46:41 +01:00
script_traits Move OpaqueNode to style_traits 2020-01-13 21:59:45 +01:00
selectors Bump selectors. 2019-12-18 14:36:47 +01:00
servo Only start WebGPU thread if an adapter is requested 2020-01-13 10:39:23 +01:00
servo_arc style: Simplify code for keeping alive shared memory until all sheets go away. 2019-11-30 20:44:56 +01:00
size_of_test
std_test_override
style Add the full background shorthand 2020-01-13 21:59:46 +01:00
style_derive Bump all in-tree components to syn 1 2019-09-27 13:29:55 +02:00
style_traits Move OpaqueNode to style_traits 2020-01-13 21:59:45 +01:00
to_shmem style: Update smallvec to 1.0. 2019-12-16 14:23:56 +01:00
to_shmem_derive Bump all in-tree components to syn 1 2019-09-27 13:29:55 +02:00
url Update rand to 0.7 (fixes #24448) 2019-10-23 15:34:48 +02:00
webdriver_server Update rand to 0.7 (fixes #24448) 2019-10-23 15:34:48 +02:00
webgpu Initial implementation of GPUBindGroupLayout for WebGPU 2020-01-16 10:53:51 +01:00
webrender_traits Use non-IPC webrender API over explicit IPC channels. 2019-11-27 20:47:53 -05:00
webvr Remove unused dependencies 2019-10-01 21:15:53 +09:00
webvr_traits Replace use of gleam in webgl with sparkle. 2019-09-11 11:40:04 -04:00