servo/components/devtools/actors
Delan Azabani 30b712aaf9
devtools: Fix id collisions by using incrementing counters (#35971)
Devtools clients need a `browserId`, `browsingContextID`, and
`outerWindowID`, which correspond to WebViewId, BrowsingContextId, and
PipelineId in Servo. These u32 values were previously derived from our
sharded (u32,u32) id values by taking only the `index` (second u32) and
ignoring the `namespace_id` (first u32), leading to collisions.

This patch fixes that by mapping those Servo ids to sequential u32
values.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by
`[X]` when the step is complete, and replace `___` with appropriate
data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #35954

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox
is checked, so that we can help you if you get stuck somewhere along the
way.-->

<!-- Pull requests that do not address these steps are welcome, but they
will require additional verification as part of the review process. -->

---------

Signed-off-by: Delan Azabani <dazabani@igalia.com>
2025-04-01 09:00:40 +00:00
..
inspector Show correctly computed element display type in devtools (#35870) 2025-03-10 12:32:30 +00:00
watcher DevTools: Show HTML tree (#32655) 2024-07-26 15:17:54 +00:00
browsing_context.rs devtools: Fix id collisions by using incrementing counters (#35971) 2025-04-01 09:00:40 +00:00
console.rs devtools: Fix id collisions by using incrementing counters (#35971) 2025-04-01 09:00:40 +00:00
device.rs devtools: update targeted firefox version. (#35792) 2025-03-05 06:08:40 +00:00
framerate.rs devtools: improve ID Naming for better readability and context (#35942) 2025-03-13 07:36:54 +00:00
inspector.rs devtools: Fix id collisions by using incrementing counters (#35971) 2025-04-01 09:00:40 +00:00
memory.rs Update rustfmt to the 2024 style edition (#35764) 2025-03-03 11:26:53 +00:00
network_event.rs Update rustfmt to the 2024 style edition (#35764) 2025-03-03 11:26:53 +00:00
object.rs Update rustfmt to the 2024 style edition (#35764) 2025-03-03 11:26:53 +00:00
performance.rs Update rustfmt to the 2024 style edition (#35764) 2025-03-03 11:26:53 +00:00
preference.rs Update rustfmt to the 2024 style edition (#35764) 2025-03-03 11:26:53 +00:00
process.rs Update rustfmt to the 2024 style edition (#35764) 2025-03-03 11:26:53 +00:00
reflow.rs Update rustfmt to the 2024 style edition (#35764) 2025-03-03 11:26:53 +00:00
root.rs Track the active tab and browsing context for devtools (#36168) 2025-03-31 17:51:28 +00:00
stylesheets.rs Update rustfmt to the 2024 style edition (#35764) 2025-03-03 11:26:53 +00:00
tab.rs devtools: Fix id collisions by using incrementing counters (#35971) 2025-04-01 09:00:40 +00:00
thread.rs DevTools: Show HTML tree (#32655) 2024-07-26 15:17:54 +00:00
timeline.rs devtools: improve ID Naming for better readability and context (#35942) 2025-03-13 07:36:54 +00:00
watcher.rs devtools: Fix id collisions by using incrementing counters (#35971) 2025-04-01 09:00:40 +00:00
worker.rs devtools: improve ID Naming for better readability and context (#35942) 2025-03-13 07:36:54 +00:00