mirror of
https://github.com/servo/servo.git
synced 2025-10-04 02:29:12 +01:00
71a013dd50
The selection API only applies to certain <input> types: https://html.spec.whatwg.org/multipage/#do-not-apply This commit ensures that we handle that correctly. Some notes: 1. TextControl::set_dom_selection_direction now calls set_selection_range(), which means that setting selectionDirection will now fire a selection event, as it should per the spec. 2. There is a test for the firing of the select event in tests/wpt/web-platform-tests/html/semantics/forms/textfieldselection/select-event.html, however the test did not run due to this syntax error: (pid:26017) "ERROR:script::dom::bindings::error: Error at http://web-platform.test:8000/html/semantics/forms/textfieldselection/select-event.html:50:11 missing = in const declaration" This happens due to the us of the "for (const foo of ...)" construct. Per https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/for...of this should actually work, so it's somewhat unsatisfying to have to change the test. 4. If an <input>'s type is unset, it defaults to a text, and the selection API applies. Also, if an <input>'s type is set to an invalid value, it defaults to a text too. I've expanded the tests to account for this second case. |
||
|---|---|---|
| .. | ||
| 2dcontext | ||
| cors | ||
| css | ||
| custom-elements | ||
| dom | ||
| domparsing | ||
| encoding | ||
| eventsource | ||
| fetch | ||
| FileAPI | ||
| fullscreen | ||
| hr-time | ||
| html | ||
| js/builtins | ||
| navigation-timing | ||
| performance-timeline | ||
| quirks-mode | ||
| referrer-policy | ||
| subresource-integrity | ||
| touch-events | ||
| uievents | ||
| url | ||
| WebCryptoAPI | ||
| WebIDL | ||
| websockets | ||
| webstorage | ||
| workers | ||
| XMLHttpRequest | ||
| MANIFEST.json | ||
| mozilla-sync | ||