mirror of
https://github.com/servo/servo.git
synced 2025-08-06 14:10:11 +01:00
71b1122e97
Don't re-resolve already-resolved generated content This fixes #7846, a failure in the "quotes-036.htm" test. Servo lays out this test correctly in its initial layout, but then messes it up in any relayout (whether it's an incremental or full layout). The problem is that the ResolveGeneratedContent traversal is not safe to run more than once on the same flow. It mutates some GeneratedContent fragments into ScannedText fragments, but leaves others unmodified (in particular, those that generate empty content). The next time layout runs, these remaining GeneratedContent fragments are processed *again* but with an incorrect correct quote nesting level (because some of the surrounding GeneratedContent fragments are gone). This patch ensures that each GeneratedContent fragment is resolved only once. r? @pcwalton <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9969) <!-- Reviewable:end --> |
||
|---|---|---|
| .. | ||
| canvas | ||
| canvas_traits | ||
| compositing | ||
| devtools | ||
| devtools_traits | ||
| gfx | ||
| gfx_traits | ||
| layout | ||
| layout_traits | ||
| msg | ||
| net | ||
| net_traits | ||
| plugins | ||
| profile | ||
| profile_traits | ||
| range | ||
| script | ||
| script_traits | ||
| servo | ||
| style | ||
| style_traits | ||
| util | ||
| webdriver_server | ||
