mirror of
https://github.com/servo/servo.git
synced 2025-07-16 03:43:38 +01:00
Client messages, which are always requests, are dispatched to Actor instances one at a time via Actor::handle_message. Each request must be paired with exactly one reply from the same actor the request was sent to, where a reply is a message with no type (if a message from the server has a type, it’s a notification, not a reply). Failing to reply to a request will almost always permanently break that actor, because either the client gets stuck waiting for a reply, or the client receives the reply for a subsequent request as if it was the reply for the current request. If an actor fails to reply to a request, we want the dispatcher (ActorRegistry::handle_message) to send an error of type `unrecognizedPacketType`, to keep the conversation for that actor in sync. Since replies come in all shapes and sizes, we want to allow Actor types to send replies without having to return them to the dispatcher. This patch adds a wrapper type around a client stream that guarantees request/reply invariants. It allows the dispatcher to check if a valid reply was sent, and guarantees that if the actor tries to send a reply, it’s actually a valid reply (see ClientRequest::is_valid_reply). It does not currently guarantee anything about messages sent via the TcpStream released via ClientRequest::try_clone_stream or the return value of ClientRequest::reply. We also send `unrecognizedPacketType`, `missingParameter`, `badParameterType`, and `noSuchActor` messages per the [protocol](https://firefox-source-docs.mozilla.org/devtools/backend/protocol.html#error-packets) [docs](https://firefox-source-docs.mozilla.org/devtools/backend/protocol.html#packets). Testing: automated tests all pass, and manual testing looks ok Fixes: #37683 and at least six bugs, plus one with a different root cause, plus three with zero impact --------- Signed-off-by: atbrakhi <atbrakhi@igalia.com> Signed-off-by: Delan Azabani <dazabani@igalia.com> Co-authored-by: delan azabani <dazabani@igalia.com> Co-authored-by: Simon Wülker <simon.wuelker@arcor.de> Co-authored-by: the6p4c <me@doggirl.gay>
127 lines
4.6 KiB
Rust
127 lines
4.6 KiB
Rust
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */
|
|
|
|
//! Liberally derived from <https://searchfox.org/mozilla-central/source/devtools/server/actors/target-configuration.js>
|
|
//! This actor manages the configuration flags that the devtools host can apply to the targets.
|
|
|
|
use std::collections::HashMap;
|
|
|
|
use embedder_traits::Theme;
|
|
use log::warn;
|
|
use serde::Serialize;
|
|
use serde_json::{Map, Value};
|
|
|
|
use crate::actor::{Actor, ActorError, ActorRegistry};
|
|
use crate::actors::browsing_context::BrowsingContextActor;
|
|
use crate::actors::tab::TabDescriptorActor;
|
|
use crate::protocol::ClientRequest;
|
|
use crate::{EmptyReplyMsg, RootActor, StreamId};
|
|
|
|
#[derive(Serialize)]
|
|
#[serde(rename_all = "camelCase")]
|
|
pub struct TargetConfigurationTraits {
|
|
supported_options: HashMap<&'static str, bool>,
|
|
}
|
|
|
|
#[derive(Serialize)]
|
|
pub struct TargetConfigurationActorMsg {
|
|
actor: String,
|
|
configuration: HashMap<&'static str, bool>,
|
|
traits: TargetConfigurationTraits,
|
|
}
|
|
|
|
pub struct TargetConfigurationActor {
|
|
name: String,
|
|
configuration: HashMap<&'static str, bool>,
|
|
supported_options: HashMap<&'static str, bool>,
|
|
}
|
|
|
|
impl Actor for TargetConfigurationActor {
|
|
fn name(&self) -> String {
|
|
self.name.clone()
|
|
}
|
|
|
|
/// The target configuration actor can handle the following messages:
|
|
///
|
|
/// - `updateConfiguration`: Receives new configuration flags from the devtools host.
|
|
fn handle_message(
|
|
&self,
|
|
request: ClientRequest,
|
|
registry: &ActorRegistry,
|
|
msg_type: &str,
|
|
msg: &Map<String, Value>,
|
|
_id: StreamId,
|
|
) -> Result<(), ActorError> {
|
|
match msg_type {
|
|
"updateConfiguration" => {
|
|
let config = msg
|
|
.get("configuration")
|
|
.ok_or(ActorError::MissingParameter)?
|
|
.as_object()
|
|
.ok_or(ActorError::BadParameterType)?;
|
|
if let Some(scheme) = config.get("colorSchemeSimulation").and_then(|v| v.as_str()) {
|
|
let theme = match scheme {
|
|
"dark" => Theme::Dark,
|
|
"light" => Theme::Light,
|
|
_ => Theme::Light,
|
|
};
|
|
let root_actor = registry.find::<RootActor>("root");
|
|
if let Some(tab_name) = root_actor.active_tab() {
|
|
let tab_actor = registry.find::<TabDescriptorActor>(&tab_name);
|
|
let browsing_context_name = tab_actor.browsing_context();
|
|
let browsing_context_actor =
|
|
registry.find::<BrowsingContextActor>(&browsing_context_name);
|
|
browsing_context_actor
|
|
.simulate_color_scheme(theme)
|
|
.map_err(|_| ActorError::Internal)?;
|
|
} else {
|
|
warn!("No active tab for updateConfiguration");
|
|
}
|
|
}
|
|
let msg = EmptyReplyMsg { from: self.name() };
|
|
request.reply_final(&msg)?
|
|
},
|
|
_ => return Err(ActorError::UnrecognizedPacketType),
|
|
};
|
|
Ok(())
|
|
}
|
|
}
|
|
|
|
impl TargetConfigurationActor {
|
|
pub fn new(name: String) -> Self {
|
|
Self {
|
|
name,
|
|
configuration: HashMap::new(),
|
|
supported_options: HashMap::from([
|
|
("cacheDisabled", false),
|
|
("colorSchemeSimulation", true),
|
|
("customFormatters", false),
|
|
("customUserAgent", false),
|
|
("javascriptEnabled", false),
|
|
("overrideDPPX", false),
|
|
("printSimulationEnabled", false),
|
|
("rdmPaneMaxTouchPoints", false),
|
|
("rdmPaneOrientation", false),
|
|
("recordAllocations", false),
|
|
("reloadOnTouchSimulationToggle", false),
|
|
("restoreFocus", false),
|
|
("serviceWorkersTestingEnabled", false),
|
|
("setTabOffline", false),
|
|
("touchEventsOverride", false),
|
|
("tracerOptions", false),
|
|
("useSimpleHighlightersForReducedMotion", false),
|
|
]),
|
|
}
|
|
}
|
|
|
|
pub fn encodable(&self) -> TargetConfigurationActorMsg {
|
|
TargetConfigurationActorMsg {
|
|
actor: self.name(),
|
|
configuration: self.configuration.clone(),
|
|
traits: TargetConfigurationTraits {
|
|
supported_options: self.supported_options.clone(),
|
|
},
|
|
}
|
|
}
|
|
}
|