mirror of
https://github.com/servo/servo.git
synced 2025-07-08 07:53:40 +01:00
ff54a58694
Refactor implementation of TextControl The intention here is to make the flow more explicit. I.e. rather than calling `self.dom_select()` and relying on the programmer to know/realise that this method is provided by a trait, we call `self.selection().dom_select()` and the programmer can inspect the definition of `self.selection()` to follow the code. This came out of a discussion with KiChjang here: https://github.com/servo/servo/pull/19544#discussion_r156167044 Note that I tried to make "selection" be a member field of HTML{Input,TextArea}Element but it opened up a whole can of worms with lifetimes, so it seemed simpler to not do that since it is not essential for this code to work. r? @jdm and @KiChjang <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19909) <!-- Reviewable:end --> |
||
|---|---|---|
| .. | ||
| docs | ||
| dom | ||
| task_source | ||
| body.rs | ||
| build.rs | ||
| Cargo.toml | ||
| clipboard_provider.rs | ||
| CMakeLists.txt | ||
| devtools.rs | ||
| document_loader.rs | ||
| fetch.rs | ||
| layout_image.rs | ||
| lib.rs | ||
| mem.rs | ||
| microtask.rs | ||
| network_listener.rs | ||
| script_runtime.rs | ||
| script_thread.rs | ||
| serviceworker_manager.rs | ||
| serviceworkerjob.rs | ||
| stylesheet_loader.rs | ||
| task.rs | ||
| test.rs | ||
| textinput.rs | ||
| timers.rs | ||
| unpremultiplytable.rs | ||
| webdriver_handlers.rs | ||
