mirror of
https://github.com/servo/servo.git
synced 2025-06-06 16:45:39 +00:00
75eb94afca
I moved away from the `Window` struct all the logic to handle task sources, into a new struct called `TaskManager`. In a happy world, I'd be able to just have there two functions, of the types: ```rust fn task_source<T: TaskSource>(&self, name: TaskSourceName) -> Box<T> fn task_source_with_canceller<T: TaskSource>(&self, name: TaskSourceName) -> (Box<T>, TaskSourceCanceller) ``` And not so much duplicated code. However, because TaskSource can't be a trait object (because it has generic type parameters), that's not possible. Instead, I decided to reduce duplicated logic through macros. For reasons[1], I have to pass both the name of the function with canceller and the name of the function without, as I'm not able to concatenate them in the macro itself. I could probably use `concat_idents` to create both types already defined and reduce the amount of arguments by one, but that macro is nightly only. At the same time, not being able to declare macros inside `impl` forces me to pass `self` as an argument. All this makes this solution more verbose than it would be ideally. It does reduce duplication, but it doesn't reduce the size of the file. [1](https://github.com/rust-lang/rust/issues/29599)
122 lines
4.1 KiB
Rust
122 lines
4.1 KiB
Rust
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
use crate::dom::audionode::{AudioNode, UnwrappedAudioNodeOptions};
|
|
use crate::dom::baseaudiocontext::BaseAudioContext;
|
|
use crate::dom::bindings::codegen::Bindings::AudioScheduledSourceNodeBinding::AudioScheduledSourceNodeMethods;
|
|
use crate::dom::bindings::error::{Error, Fallible};
|
|
use crate::dom::bindings::inheritance::Castable;
|
|
use crate::dom::bindings::num::Finite;
|
|
use crate::dom::bindings::refcounted::Trusted;
|
|
use crate::dom::bindings::reflector::DomObject;
|
|
use crate::task_source::TaskSource;
|
|
use dom_struct::dom_struct;
|
|
use servo_media::audio::node::OnEndedCallback;
|
|
use servo_media::audio::node::{AudioNodeInit, AudioNodeMessage, AudioScheduledSourceNodeMessage};
|
|
use std::cell::Cell;
|
|
|
|
#[dom_struct]
|
|
pub struct AudioScheduledSourceNode {
|
|
node: AudioNode,
|
|
has_start: Cell<bool>,
|
|
has_stop: Cell<bool>,
|
|
}
|
|
|
|
impl AudioScheduledSourceNode {
|
|
#[allow(unrooted_must_root)]
|
|
pub fn new_inherited(
|
|
node_type: AudioNodeInit,
|
|
context: &BaseAudioContext,
|
|
options: UnwrappedAudioNodeOptions,
|
|
number_of_inputs: u32,
|
|
number_of_outputs: u32,
|
|
) -> Fallible<AudioScheduledSourceNode> {
|
|
Ok(AudioScheduledSourceNode {
|
|
node: AudioNode::new_inherited(
|
|
node_type,
|
|
context,
|
|
options,
|
|
number_of_inputs,
|
|
number_of_outputs,
|
|
)?,
|
|
has_start: Cell::new(false),
|
|
has_stop: Cell::new(false),
|
|
})
|
|
}
|
|
|
|
pub fn node(&self) -> &AudioNode {
|
|
&self.node
|
|
}
|
|
|
|
pub fn has_start(&self) -> bool {
|
|
self.has_start.get()
|
|
}
|
|
}
|
|
|
|
impl AudioScheduledSourceNodeMethods for AudioScheduledSourceNode {
|
|
// https://webaudio.github.io/web-audio-api/#dom-audioscheduledsourcenode-onended
|
|
event_handler!(ended, GetOnended, SetOnended);
|
|
|
|
// https://webaudio.github.io/web-audio-api/#dom-audioscheduledsourcenode-start
|
|
fn Start(&self, when: Finite<f64>) -> Fallible<()> {
|
|
if *when < 0. {
|
|
return Err(Error::Range("'when' must be a positive value".to_owned()));
|
|
}
|
|
|
|
if self.has_start.get() || self.has_stop.get() {
|
|
return Err(Error::InvalidState);
|
|
}
|
|
|
|
let this = Trusted::new(self);
|
|
let global = self.global();
|
|
let window = global.as_window();
|
|
let (task_source, canceller) = window
|
|
.task_manager()
|
|
.dom_manipulation_task_source_with_canceller();
|
|
let callback = OnEndedCallback::new(move || {
|
|
let _ = task_source.queue_with_canceller(
|
|
task!(ended: move || {
|
|
let this = this.root();
|
|
let global = this.global();
|
|
let window = global.as_window();
|
|
window.task_manager().dom_manipulation_task_source().queue_simple_event(
|
|
this.upcast(),
|
|
atom!("ended"),
|
|
&window
|
|
);
|
|
}),
|
|
&canceller,
|
|
);
|
|
});
|
|
|
|
self.node()
|
|
.message(AudioNodeMessage::AudioScheduledSourceNode(
|
|
AudioScheduledSourceNodeMessage::RegisterOnEndedCallback(callback),
|
|
));
|
|
|
|
self.has_start.set(true);
|
|
self.node
|
|
.message(AudioNodeMessage::AudioScheduledSourceNode(
|
|
AudioScheduledSourceNodeMessage::Start(*when),
|
|
));
|
|
Ok(())
|
|
}
|
|
|
|
// https://webaudio.github.io/web-audio-api/#dom-audioscheduledsourcenode-stop
|
|
fn Stop(&self, when: Finite<f64>) -> Fallible<()> {
|
|
if *when < 0. {
|
|
return Err(Error::Range("'when' must be a positive value".to_owned()));
|
|
}
|
|
|
|
if !self.has_start.get() {
|
|
return Err(Error::InvalidState);
|
|
}
|
|
self.has_stop.set(true);
|
|
self.node
|
|
.message(AudioNodeMessage::AudioScheduledSourceNode(
|
|
AudioScheduledSourceNodeMessage::Stop(*when),
|
|
));
|
|
Ok(())
|
|
}
|
|
}
|