mirror of
https://github.com/servo/servo.git
synced 2025-10-04 02:29:12 +01:00
691c6c6f1a
Prior to this change, if none of the fonts specified in CSS contained a glyph for a codepoint, we tried only one fallback font. If that font didn't contain the glyph, we'd give up. With this change, we try multiple fonts in turn. The font names we try differ across each platform, and based on the codepoint we're trying to match. The current implementation is heavily inspired by the analogous code in Gecko, but I've used to ucd lib to make it more readable, whereas Gecko matches raw unicode ranges. This fixes some of the issues reported in #17267, although colour emoji support is not implemented. == Notes on changes to WPT metadata == === css/css-text/i18n/css3-text-line-break-opclns-* === A bunch of these have started failing on macos when they previously passed. These tests check that the browser automatically inserts line breaks near certain characters that are classified as "opening and closing punctuation". The idea is that if we have e.g. an opening parenthesis, it does not make sense for it to appear at the end of a line box; it should "stick" to the next character and go into the next line box. Before this change, a lot of these codepoints rendered as a missing glyph on Mac and Linux. In some cases, that meant that the test was passing. After this change, a bunch of these codepoints are now rendering glyphs on Mac (but not Linux). In some cases, the test should continue to pass where it previously did when rendering with the missing glyph. However, it seems this has also exposed a layout bug. The "ref" div in these tests contains a <br> element, and it seems that this, combined with these punctuation characters, makes the spacing between glyphs ever so slightly different to the "test" div. (Speculation: might be something to do with shaping?) Therefore I've had to mark a bunch of these tests failing on mac. === css/css-text/i18n/css3-text-line-break-baspglwj-* === Some of these previously passed on Mac due to a missing glyph. Now that we're rendering the correct glyph, they are failing. === css/css-text/word-break/word-break-normal-bo-000.html === The characters now render correctly on Mac, and the test is passing. But we do not find a suitable fallback font on Linux, so it is still failing on that platform. === css/css-text/word-break/word-break-break-all-007.html === This was previously passing on Mac, but only because missing character glyphs were rendered. Now that a fallback font is able to be found, it (correctly) fails. === mozilla/tests/css/font_fallback_* === These are new tests added in this commit. 01 and 02 are marked failing on Linux because the builders don't have the appropriate fonts installed (that will be a follow-up). Fix build errors from rebase FontTemplateDescriptor can no longer just derive(Hash). We need to implement it on each component part, because the components now generally wrap floats, which do not impl Hash because of NaN. However in this case we know that we won't have a NaN, so it is safe to manually impl Hash. |
||
|---|---|---|
| .. | ||
| animations | ||
| css-position-3 | ||
| iframe | ||
| __dir__.ini | ||
| abs-overflow-stackingcontext.html.ini | ||
| acid2-wrapper.html.ini | ||
| acid2_noscroll.html.ini | ||
| acid2_ref.html.ini | ||
| border-image-linear-gradient.html.ini | ||
| border_black_ridge_a.html.ini | ||
| border_black_ridge_b.html.ini | ||
| border_radius_elliptical_a.html.ini | ||
| borders_a.html.ini | ||
| canvas_linear_gradient_a.html.ini | ||
| direction_style_caching.html.ini | ||
| dirty_viewport.html.ini | ||
| filter_sepia_a.html.ini | ||
| font_fallback_01.html.ini | ||
| font_fallback_02.html.ini | ||
| hide_after_create.html.ini | ||
| incremental_trailing_whitespace_a.html.ini | ||
| inline_block_opacity_change.html.ini | ||
| jumpiness_a.html.ini | ||
| line_break_nowrap.html.ini | ||
| matchMedia.html.ini | ||
| meta_viewport_resize.html.ini | ||
| mix_blend_mode_a.html.ini | ||
| pixel_snapping_glyphs.html.ini | ||
| position_relative_stacking_context_contents_a.html.ini | ||
| position_relative_vertical_percentage_overflow_a.html.ini | ||
| stacking_context_overflow_a.html.ini | ||
| text_shadow_blur_a.html.ini | ||
| transition_calc_implicit.html.ini | ||
| vertical-lr-blocks.html.ini | ||
| viewport_meta.html.ini | ||
| viewport_rule.html.ini | ||
| white_space_intrinsic_sizes_a.html.ini | ||
| whitespace_nowrap_line_breaking_a.html.ini | ||
| word-break-keep-all-008.htm.ini | ||
| writing-mode_change_display.html.ini | ||