Add informative error messages when parsing command line options returns an error The background behind why I'm submitting this PR is slightly embarrassing. After running `./mach` with some servo options I got the following stack backtrace. ``` thread '<main>' panicked at 'called `Result::unwrap()` on an `Err` value: ParseIntError { kind: InvalidDigit }', ../src/libcore/result.rs:746 stack backtrace: 1: 0x56459001b0b0 - sys::backtrace::tracing:👿:write::hb120982054a416e35nu 2: 0x56459001e02b - panicking::default_handler::_$u7b$$u7b$closure$u7d$$u7d$::closure.42840 3: 0x56459001dc96 - panicking::default_handler::h7ae2e4523ef4c187IFy 4: 0x56459000760c - sys_common::unwind::begin_unwind_inner::h5fb19481d14902dbDgt 5: 0x564590007cf8 - sys_common::unwind::begin_unwind_fmt::hd62d57279546b0f2Jft 6: 0x56459001a701 - rust_begin_unwind 7: 0x56459004c01f - panicking::panic_fmt::h27f7225e08792f40qYL 8: 0x56458f393901 - result::unwrap_failed::h18215968003310890981 at ../src/libcore/macros.rs:29 9: 0x56458f3937b9 - result::Result<T, E>::unwrap::h10319050269194353824 at ../src/libcore/result.rs:687 10: 0x56458f383701 - opts::from_cmdline_args::h8ea8d8c87dc6ee726lg at /home/drobertson/git/servo/components/util/opts.rs:599 11: 0x56458d1f8cdf - main::h8517eb49d15e90fbNaa at /home/drobertson/git/servo/components/servo/main.rs:53 12: 0x56459001d8f4 - sys_common::unwind::try::try_fn::h9076850075504893162 13: 0x56459001a68b - __rust_try 14: 0x56459001d36e - rt::lang_start::h58a22f304b0c1e19Oxy 15: 0x56458d2f4aa9 - main 16: 0x7f370496360f - __libc_start_main 17: 0x56458d1c04a8 - _start 18: 0x0 - <unknown> Servo exited with return value 101 ``` I immediately opened up `gdb` and got to work only to realize that the error was due to a typo in an option that had been `unwrap`ed at [components/util/opts.rs:599](https://github.com/servo/servo/blob/master/components/util/opts.rs#L599). Perhaps some more informative error messages will help prevent some future face-palm moments like mine 😄 I couldn't think of a good way to add tests for this. Please let me know if I missed something. Comments and critiques are welcome! <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9600) <!-- Reviewable:end --> |
||
---|---|---|
components | ||
etc | ||
ports | ||
python | ||
resources | ||
support | ||
tests | ||
.gitattributes | ||
.gitignore | ||
.travis.yml | ||
cargo-nightly-build | ||
CONTRIBUTING.md | ||
HACKING_QUICKSTART.md | ||
Info.plist | ||
LICENSE | ||
mach | ||
ORGANIZATION.md | ||
README.md | ||
rust-nightly-date | ||
servobuild.example |
The Servo Parallel Browser Engine Project
Servo is a prototype web browser engine written in the Rust language. It is currently developed on 64bit OS X, 64bit Linux, Android, and Gonk (Firefox OS).
Servo welcomes contribution from everyone. See
CONTRIBUTING.md
and HACKING_QUICKSTART.md
for help getting started.
Visit the Servo Project page for news and guides.
Prerequisites
On OS X (homebrew):
brew install automake pkg-config python cmake
pip install virtualenv
On OS X (MacPorts):
sudo port install python27 py27-virtualenv cmake
On Debian-based Linuxes:
sudo apt-get install curl freeglut3-dev autoconf \
libfreetype6-dev libgl1-mesa-dri libglib2.0-dev xorg-dev \
gperf g++ build-essential cmake virtualenv python-pip \
libssl-dev libbz2-dev libosmesa6-dev libxmu6 libxmu-dev \
libglu1-mesa-dev libgles2-mesa-dev libegl1-mesa-dev
If you are on Ubuntu 14.04 and encountered errors on installing these dependencies involving libcheese
, see #6158 for a workaround.
If virtualenv
does not exist, try python-virtualenv
.
On Fedora:
sudo dnf install curl freeglut-devel libtool gcc-c++ libXi-devel \
freetype-devel mesa-libGL-devel mesa-libEGL-devel glib2-devel libX11-devel libXrandr-devel gperf \
fontconfig-devel cabextract ttmkfdir python python-virtualenv python-pip expat-devel \
rpm-build openssl-devel cmake bzip2-devel libXcursor-devel libXmu-devel mesa-libOSMesa-devel
On Arch Linux:
sudo pacman -S --needed base-devel git python2 python2-virtualenv python2-pip mesa cmake bzip2 libxmu
On Gentoo Linux:
sudo emerge net-misc/curl media-libs/freeglut \
media-libs/freetype media-libs/mesa dev-util/gperf \
dev-python/virtualenv dev-python/pip dev-libs/openssl \
x11-libs/libXmu media-libs/glu x11-base/xorg-server
On Windows:
Download Python for Windows here. This is required for the SpiderMonkey build on Windows.
Install MSYS2 from here. After you have done so, open an MSYS shell window and update the core libraries and install new packages:
update-core
pacman -Sy git mingw-w64-x86_64-toolchain mingw-w64-x86_64-freetype \
mingw-w64-x86_64-icu mingw-w64-x86_64-nspr mingw-w64-x86_64-ca-certificates \
mingw-w64-x86_64-expat mingw-w64-x86_64-cmake tar diffutils patch \
patchutils make python2-setuptools
easy_install-2.7 pip virtualenv
Open a new MSYS shell window as Administrator and remove the Python binaries (they
are not compatible with our mach
driver script yet, unfortunately):
cd /mingw64/bin
mv python2.exe python2-mingw64.exe
mv python2.7.exe python2.7-mingw64.exe
Now, open a MINGW64 (not MSYS!) shell window, and you should be able to build servo as usual!
Cross-compilation for Android:
Pre-installed Android tools are needed. See wiki for details
The Rust compiler
Servo's build system automatically downloads a Rust compiler to build itself.
This is normally a specific revision of Rust upstream, but sometimes has a
backported patch or two.
If you'd like to know which nightly build of Rust we use, see
rust-nightly-date
.
Building
Servo is built with Cargo, the Rust package manager. We also use Mozilla's Mach tools to orchestrate the build and other tasks.
Normal build
To build Servo in development mode. This is useful for development, but the resulting binary is very slow.
git clone https://github.com/servo/servo
cd servo
./mach build --dev
./mach run tests/html/about-mozilla.html
For benchmarking, performance testing, or
real-world use, add the --release
flag to create an optimized build:
./mach build --release
./mach run --release tests/html/about-mozilla.html
Building for Android target
git clone https://github.com/servo/servo
cd servo
ANDROID_TOOLCHAIN=/path/to/toolchain ANDROID_NDK=/path/to/ndk PATH=$PATH:/path/to/toolchain/bin ./mach build --android
cd ports/android
ANDROID_SDK=/path/to/sdk make install
Rather than setting the ANDROID_*
environment variables every time, you can
also create a .servobuild
file and then edit it to contain the correct paths
to the Android SDK/NDK tools:
cp servobuild.example .servobuild
# edit .servobuild
Running
Use ./mach run [url]
to run Servo.
Commandline Arguments
-p INTERVAL
turns on the profiler and dumps info to the console everyINTERVAL
seconds-s SIZE
sets the tile size for painting; defaults to 512-z
disables all graphical output; useful for running JS / layout tests
Keyboard Shortcuts
Ctrl--
zooms outCtrl-=
zooms inBackspace
goes backwards in the historyShift-Backspace
goes forwards in the historyEsc
exits servo
Developing
There are lots of mach commands you can use. You can list them with ./mach --help
.
The generated documentation can be found on http://doc.servo.org/servo/index.html