mirror of
https://github.com/servo/servo.git
synced 2025-08-03 12:40:06 +01:00
e217672c1a
Count threads at shutdown, warn if not all finished and optionally block On Desktop, after servo shutdown, the process exits, killing all the still-running threads. On mobile, the process doesn't necessarily shutdown, and we are left with multiple threads failing to use channels, printing warning and panicking. In the future, we'd like to do a clean shutdown, as in, shutdown only once all the threads have properly finished. For now, I'm printing a warning if all the threads are not finished, and also add an option to only exit if all the threads have finished. This only works on MacOS for now, in C, as I haven't found a Rust/multiplatform way to count running threads. I recommend trying to run servo with `--clean-shutdown` option. Interesting to see how long it takes for other threads to shutdown, and see which threads start panicking. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22092) <!-- Reviewable:end --> |
||
|---|---|---|
| .. | ||
| allocator | ||
| atoms | ||
| bluetooth | ||
| bluetooth_traits | ||
| canvas | ||
| canvas_traits | ||
| channel | ||
| compositing | ||
| config | ||
| constellation | ||
| debugger | ||
| deny_public_fields | ||
| devtools | ||
| devtools_traits | ||
| dom_struct | ||
| domobject_derive | ||
| embedder_traits | ||
| fallible | ||
| geometry | ||
| gfx | ||
| gfx_traits | ||
| hashglobe | ||
| jstraceable_derive | ||
| layout | ||
| layout_thread | ||
| layout_traits | ||
| malloc_size_of | ||
| malloc_size_of_derive | ||
| metrics | ||
| msg | ||
| net | ||
| net_traits | ||
| pixels | ||
| profile | ||
| profile_traits | ||
| rand | ||
| range | ||
| remutex | ||
| script | ||
| script_layout_interface | ||
| script_plugins | ||
| script_traits | ||
| selectors | ||
| servo | ||
| servo_arc | ||
| size_of_test | ||
| std_test_override | ||
| style | ||
| style_derive | ||
| style_traits | ||
| url | ||
| webdriver_server | ||
| webvr | ||
| webvr_traits | ||
